All of lore.kernel.org
 help / color / mirror / Atom feed
From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: "Ilpo Järvinen" <ilpo.jarvinen@linux.intel.com>
Cc: Sherry Sun <sherry.sun@nxp.com>,
	stable@vger.kernel.org, patches@lists.linux.dev,
	Sasha Levin <sashal@kernel.org>
Subject: Re: [PATCH proper backport to 5.15 1/1] tty: serial: fsl_lpuart: don't break the on-going transfer when global reset
Date: Sat, 3 Dec 2022 14:37:39 +0100	[thread overview]
Message-ID: <Y4tRI3CQL/PZj7Di@kroah.com> (raw)
In-Reply-To: <1b26798d-fdbd-9e21-b745-1ed335e75b@linux.intel.com>

On Thu, Dec 01, 2022 at 10:54:08AM +0200, Ilpo Järvinen wrote:
> [ Upstream commit 76bad3f88750f8cc465c489e6846249e0bc3d8f5 ]
> 
> lpuart_global_reset() shouldn't break the on-going transmit engine, need
> to recover the on-going data transfer after reset.
> 
> This can help earlycon here, since commit 60f361722ad2 ("serial:
> fsl_lpuart: Reset prior to registration") moved lpuart_global_reset()
> before uart_add_one_port(), earlycon is writing during global reset,
> as global reset will disable the TX and clear the baud rate register,
> which caused the earlycon cannot work any more after reset, needs to
> restore the baud rate and re-enable the transmitter to recover the
> earlycon write.
> 
> Also move the lpuart_global_reset() down, then we can reuse the
> lpuart32_tx_empty() without declaration.
> 
> Fixes: bd5305dcabbc ("tty: serial: fsl_lpuart: do software reset for imx7ulp and imx8qxp")
> Signed-off-by: Sherry Sun <sherry.sun@nxp.com>
> Link: https://lore.kernel.org/r/20221024085844.22786-1-sherry.sun@nxp.com
> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
> Signed-off-by: Sasha Levin <sashal@kernel.org>
> ---
> 
> Hi stable folks,
> 
> These two stable-deps seem to be pulled into stable only due to diff 
> context:
> 
> 07481f448b63 ("serial: fsl_lpuart: Fill in rs485_supported")
> 8925c31c1ac2 ("serial: Add rs485_supported to uart_port")
> 
> I think those two should be dropped from the stable queue and the queued 
> fix for 76bad3f88750 ("tty: serial: fsl_lpuart: don't break the on-going 
> transfer when global reset") replaced with this backport.

As the above are already applied, can you send a fix-up patch to resolve
the problems in the backport that you found?

thanks,

greg k-h

      reply	other threads:[~2022-12-03 13:37 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-12-01  8:54 [PATCH proper backport to 5.15 1/1] tty: serial: fsl_lpuart: don't break the on-going transfer when global reset Ilpo Järvinen
2022-12-03 13:37 ` Greg Kroah-Hartman [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=Y4tRI3CQL/PZj7Di@kroah.com \
    --to=gregkh@linuxfoundation.org \
    --cc=ilpo.jarvinen@linux.intel.com \
    --cc=patches@lists.linux.dev \
    --cc=sashal@kernel.org \
    --cc=sherry.sun@nxp.com \
    --cc=stable@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.