From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Badhri Jagan Sridharan <badhri@google.com>
Cc: Guenter Roeck <linux@roeck-us.net>,
Heikki Krogerus <heikki.krogerus@linux.intel.com>,
linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org,
Kyle Tso <kyletso@google.com>
Subject: Re: [PATCH v3 3/3] usb: typec: maxim_contaminant: Implement check_contaminant callback
Date: Sun, 4 Dec 2022 10:43:02 +0100 [thread overview]
Message-ID: <Y4xrpgCTqV4yAplp@kroah.com> (raw)
In-Reply-To: <20221204084844.3573800-3-badhri@google.com>
On Sun, Dec 04, 2022 at 12:48:44AM -0800, Badhri Jagan Sridharan wrote:
> +EXPORT_SYMBOL_GPL(is_contaminant);
Sorry, but this is a horrible name for the kernel global namespace.
Please properly prefix it to show exactly what subsystem this is from.
thanks,
greg k-h
next prev parent reply other threads:[~2022-12-04 9:43 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-12-04 8:48 [PATCH v3 1/3] usb: typec: tcpm: Add callbacks to mitigate wakeups due to contaminant Badhri Jagan Sridharan
2022-12-04 8:48 ` [PATCH v3 2/3] usb: typec: tcpci: Add callback for evaluating contaminant presence Badhri Jagan Sridharan
2022-12-04 8:48 ` [PATCH v3 3/3] usb: typec: maxim_contaminant: Implement check_contaminant callback Badhri Jagan Sridharan
2022-12-04 9:43 ` Greg Kroah-Hartman [this message]
2022-12-04 15:57 ` Guenter Roeck
2022-12-06 1:33 ` Badhri Jagan Sridharan
2022-12-04 9:50 ` kernel test robot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Y4xrpgCTqV4yAplp@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=badhri@google.com \
--cc=heikki.krogerus@linux.intel.com \
--cc=kyletso@google.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=linux@roeck-us.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.