From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id B9F0CC4321E for ; Sun, 4 Dec 2022 13:55:23 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230074AbiLDNzW (ORCPT ); Sun, 4 Dec 2022 08:55:22 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:55098 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229938AbiLDNzV (ORCPT ); Sun, 4 Dec 2022 08:55:21 -0500 Received: from mail-wr1-x430.google.com (mail-wr1-x430.google.com [IPv6:2a00:1450:4864:20::430]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 0DAC413E10 for ; Sun, 4 Dec 2022 05:55:20 -0800 (PST) Received: by mail-wr1-x430.google.com with SMTP id h11so14909194wrw.13 for ; Sun, 04 Dec 2022 05:55:19 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20210112; h=user-agent:in-reply-to:content-disposition:mime-version:references :message-id:subject:cc:to:from:date:from:to:cc:subject:date :message-id:reply-to; bh=Ska6TcnCsHh18hDzT75JBNFPy6gHNuvSOCpDNo61KFU=; b=EfLbdpMidStzMx8knb8USFBX/Jkp31Efue8m6oW84hSdffdF1vAT9b9xodMyj6S7dP JevTDiHMoC/piSZ+K4C2RGcwHutQCRxWzgs/L7/TsA1BL2qYkxAG66NBVs5Kb0FD/CIn G8E095n1zgbxJvQbefMssFwa1oONLDWJzM88ztCo7TlS9FKh6LIPLUpb+hiKCpmSjT4o cO3AAUpPKHjtSdpQEiIv/hfRQG1BUgchWOhAzNLUpoLiET2DvHgoN3pKgrtOKos5gljE wOS6Zr0tWT1ynqp+htCgZLpffAk4qrWg3jSaowipytHN28UNl35bDx7Qp8Ft8pVgu/Jb tgVA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=user-agent:in-reply-to:content-disposition:mime-version:references :message-id:subject:cc:to:from:date:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=Ska6TcnCsHh18hDzT75JBNFPy6gHNuvSOCpDNo61KFU=; b=NaZM8zdbdtDujIaL2uU9L9mzwewb7JuX0C9FDEXYkjCEsrn0yTa/RS78mH3S4jTViH N/XchTlqyHasEvvbDSOnY42GIP/T72O2r7g4Atdidp9TFeuhMfmbvPxrxIMyXPhhgF6O kOzoAyrZ2Rli1ya+uABxweM26aVZfXkeC28FaD4p4NMt45LLh0C/tEuXAqiPod1o6/2k Xle2NPcActudWJpXfjUm22KO1g2Rb2mNBGluv1bK/8XLhvHKW7QZ5yTl2HbaAO17IMKU wwGZ5e9L/suhd18Duju1YD5wkT3Ee63CuK2cuLaGB2WZBXd8nTRGfvjy/SbDt9yrHOhb M0JQ== X-Gm-Message-State: ANoB5pnsDvD3rNtmjCVB6qBE1Dmv5dxTkGtQhfS+B+1K71QZaunq6uzz OxILh2bknNp2aKQlyRBF+ODwsw== X-Google-Smtp-Source: AA0mqf4yrgSHn6+OCXRvUPqPLi80hqzsMSWuOm3G4mIg7NQz66yD5yPkZ61yDQ6PcHsBfepYVdwwSw== X-Received: by 2002:a5d:4d07:0:b0:242:4ab7:5a19 with SMTP id z7-20020a5d4d07000000b002424ab75a19mr5289115wrt.389.1670162118380; Sun, 04 Dec 2022 05:55:18 -0800 (PST) Received: from elver.google.com ([2a00:79e0:9c:201:74e8:6da0:c93c:6bcd]) by smtp.gmail.com with ESMTPSA id x11-20020adfec0b000000b00241f029e672sm11646137wrn.107.2022.12.04.05.55.17 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 04 Dec 2022 05:55:17 -0800 (PST) Date: Sun, 4 Dec 2022 14:55:11 +0100 From: Marco Elver To: Christophe JAILLET Cc: paulmck@kernel.org, mark.rutland@arm.com, linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org, Ingo Molnar , Joe Perches Subject: Re: [PATCH] init_task: Include in the right file Message-ID: References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/2.2.7 (2022-08-07) Precedence: bulk List-ID: X-Mailing-List: kernel-janitors@vger.kernel.org [+Cc Ingo, who had been working on lots of include improvements.] The Cc list is odd -- it appears that get_maintainers.pl is broken on init_task.c: $> ./scripts/get_maintainer.pl init/init_task.c Mark Rutland (commit_signer:1/1=100%) "Paul E. McKenney" (commit_signer:1/1=100%) Marco Elver (commit_signer:1/1=100%,authored:1/1=100%,removed_lines:5/5=100%) linux-kernel@vger.kernel.org (open list) What's going on here? On Sun, Dec 04, 2022 at 12:39PM +0100, Christophe JAILLET wrote: > There is no need to include in init_task.h. > Move it to the right place, in kernel/cred.c which uses RB_ROOT_CACHED. > > This is a follow-up of commit 4e7e3adbba52 ("Expand various INIT_* macros > and remove") which moved things from init_task.h to init_task.c > > Signed-off-by: Christophe JAILLET > --- > Let see if build-bots agree with me! > > This patch depends on [1] and [2]. > All these patches are related to init_task.h simplification. > > They are unrelated and can be applied separately, but as they modify more > or less the same place in the same file, there may be some merge conflict. > > [1]: https://lore.kernel.org/all/1a3d5bd51b7807471a913f8fa621e5a4ecd08e6a.1670100520.git.christophe.jaillet@wanadoo.fr/ > [2]: https://lore.kernel.org/all/94c8f2123a8833b61d84a662ec35f9c070cdf4dd.1670147823.git.christophe.jaillet@wanadoo.fr/ > --- > include/linux/init_task.h | 1 - > init/init_task.c | 1 + > 2 files changed, 1 insertion(+), 1 deletion(-) > > diff --git a/include/linux/init_task.h b/include/linux/init_task.h > index 6d2c4ea4c97a..e18a6c6f6fd9 100644 > --- a/include/linux/init_task.h > +++ b/include/linux/init_task.h > @@ -9,7 +9,6 @@ > #include > #include > #include > -#include > #include > #include > #include > diff --git a/init/init_task.c b/init/init_task.c > index ff6c4b9bfe6b..2392c0a67fb7 100644 > --- a/init/init_task.c > +++ b/init/init_task.c > @@ -2,6 +2,7 @@ > #include > #include > #include > +#include > #include > #include > #include > -- > 2.34.1 >