From: Al Viro <viro@zeniv.linux.org.uk>
To: "Thomas Weißschuh" <linux@weissschuh.net>
Cc: Serge Hallyn <serge@hallyn.com>, Andrey Vagin <avagin@openvz.org>,
"Eric W. Biederman" <ebiederm@xmission.com>,
linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org,
Karel Zak <kzak@redhat.com>
Subject: Re: [PATCH] nsfs: add compat ioctl handler
Date: Sun, 18 Dec 2022 21:25:13 +0000 [thread overview]
Message-ID: <Y5+FOfgNHAnRkE5q@ZenIV> (raw)
In-Reply-To: <20221214-nsfs-ioctl-compat-v1-0-b169796000b2@weissschuh.net>
On Sun, Dec 18, 2022 at 09:07:25PM +0000, Thomas Weißschuh wrote:
> As all parameters and return values of the ioctls have the same
> representation on both 32bit and 64bit we can reuse the normal ioctl
> handler for the compat handler.
>
> All nsfs ioctls return a plain "int" filedescriptor which is a signed
> 4-byte integer type on both 32bit and 64bit.
> The only parameter taken is by NS_GET_OWNER_UID and is a pointer to a
> "uid_t" which is a 4-byte unsigned integer type on both 32bit and 64bit.
>
> Fixes: 6786741dbf99 ("nsfs: add ioctl to get an owning user namespace for ns file descriptor")
> Reported-By: Karel Zak <kzak@redhat.com>
> Signed-off-by: Thomas Weißschuh <linux@weissschuh.net>
NAK. This is broken on s390; use compat_ptr_ioctl instead.
parent reply other threads:[~2022-12-18 21:25 UTC|newest]
Thread overview: expand[flat|nested] mbox.gz Atom feed
[parent not found: <20221214-nsfs-ioctl-compat-v1-0-b169796000b2@weissschuh.net>]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Y5+FOfgNHAnRkE5q@ZenIV \
--to=viro@zeniv.linux.org.uk \
--cc=avagin@openvz.org \
--cc=ebiederm@xmission.com \
--cc=kzak@redhat.com \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@weissschuh.net \
--cc=serge@hallyn.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.