All of lore.kernel.org
 help / color / mirror / Atom feed
From: Emilio Cota <cota@braap.org>
To: Aaron Lindsay <aaron@os.amperecomputing.com>
Cc: "Richard Henderson" <richard.henderson@linaro.org>,
	"Alex Bennée" <alex.bennee@linaro.org>,
	qemu-devel@nongnu.org
Subject: Re: Plugin Memory Callback Debugging
Date: Sun, 18 Dec 2022 00:24:43 -0500	[thread overview]
Message-ID: <Y56kG439aHBbKVLK@cota-l14> (raw)
In-Reply-To: <Y4Ztn91bFssBdbmR@strawberry.localdomain>

On Tue, Nov 29, 2022 at 15:37:51 -0500, Aaron Lindsay wrote:
(snip)
> > Does this hint that there are cases where reset cpu->plugin_mem_cbs to NULL is
> > getting optimized away, but not the code to set it in the first place?
> 
> Is there anyone who could help take a look at this from the code gen
> perspective?

Thanks for the report. Just adding assertions was enough to uncover
several bugs. I did not reproduce the use-after-free, but by calling
reset from a callback it's easy to see how it can occur.

I have fixes in https://github.com/cota/qemu/tree/plugins

Can you please give those a try?

BTW I created an issue on gitlab to track this
  https://gitlab.com/qemu-project/qemu/-/issues/1381

Thanks,
		Emilio


  parent reply	other threads:[~2022-12-18  5:26 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-11-15 22:05 Plugin Memory Callback Debugging Aaron Lindsay
2022-11-15 22:36 ` Alex Bennée
2022-11-18 21:58   ` Aaron Lindsay via
2022-11-18 22:02     ` Aaron Lindsay
2022-11-21 22:02       ` Alex Bennée
2022-11-22 17:05         ` Aaron Lindsay via
2022-11-21 20:18   ` Aaron Lindsay via
2022-11-21 21:51     ` Alex Bennée
2022-11-22  2:22       ` Richard Henderson
2022-11-22 15:57         ` Aaron Lindsay via
2022-11-29 20:37           ` Aaron Lindsay via
2022-12-01 19:32             ` Alex Bennée
2022-12-18  5:24             ` Emilio Cota [this message]
2022-12-19 20:11               ` Aaron Lindsay
2023-01-06 10:30                 ` Alex Bennée
2023-01-07  3:07                   ` Emilio Cota
2022-11-16  6:19 ` Emilio Cota

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=Y56kG439aHBbKVLK@cota-l14 \
    --to=cota@braap.org \
    --cc=aaron@os.amperecomputing.com \
    --cc=alex.bennee@linaro.org \
    --cc=qemu-devel@nongnu.org \
    --cc=richard.henderson@linaro.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.