All of lore.kernel.org
 help / color / mirror / Atom feed
From: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
To: Adam Ford <aford173@gmail.com>
Cc: linux-arm-kernel@lists.infradead.org, aford@beaconembedded.com,
	Rob Herring <robh+dt@kernel.org>,
	Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
	Shawn Guo <shawnguo@kernel.org>,
	Sascha Hauer <s.hauer@pengutronix.de>,
	Pengutronix Kernel Team <kernel@pengutronix.de>,
	Fabio Estevam <festevam@gmail.com>,
	NXP Linux Team <linux-imx@nxp.com>,
	Lucas Stach <l.stach@pengutronix.de>,
	devicetree@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/2] arm64: dts: imx8mp: Fix power-domain typo
Date: Sun, 18 Dec 2022 17:02:52 +0200	[thread overview]
Message-ID: <Y58rnBMSLHtELIU4@pendragon.ideasonboard.com> (raw)
In-Reply-To: <20221217180849.775718-2-aford173@gmail.com>

Hi Adam,

Thank you for the patch.

On Sat, Dec 17, 2022 at 12:08:49PM -0600, Adam Ford wrote:
> dt_binding_check detects an issue with the pgc_hsiomix power
> domain:
>   pgc: 'power-domains@17' does not match any of the regexes
> 
> This is because 'power-domains' should be 'power-domain'

Oops.

Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>

> Fixes: 2ae42e0c0b67 ("arm64: dts: imx8mp: add HSIO power-domains")
> Signed-off-by: Adam Ford <aford173@gmail.com>
> 
> diff --git a/arch/arm64/boot/dts/freescale/imx8mp.dtsi b/arch/arm64/boot/dts/freescale/imx8mp.dtsi
> index 7a8ca56e48b6..19609ef0560a 100644
> --- a/arch/arm64/boot/dts/freescale/imx8mp.dtsi
> +++ b/arch/arm64/boot/dts/freescale/imx8mp.dtsi
> @@ -591,7 +591,7 @@ pgc_mipi_phy2: power-domain@16 {
>  						reg = <IMX8MP_POWER_DOMAIN_MIPI_PHY2>;
>  					};
>  
> -					pgc_hsiomix: power-domains@17 {
> +					pgc_hsiomix: power-domain@17 {
>  						#power-domain-cells = <0>;
>  						reg = <IMX8MP_POWER_DOMAIN_HSIOMIX>;
>  						clocks = <&clk IMX8MP_CLK_HSIO_AXI>,

-- 
Regards,

Laurent Pinchart

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

WARNING: multiple messages have this Message-ID (diff)
From: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
To: Adam Ford <aford173@gmail.com>
Cc: linux-arm-kernel@lists.infradead.org, aford@beaconembedded.com,
	Rob Herring <robh+dt@kernel.org>,
	Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
	Shawn Guo <shawnguo@kernel.org>,
	Sascha Hauer <s.hauer@pengutronix.de>,
	Pengutronix Kernel Team <kernel@pengutronix.de>,
	Fabio Estevam <festevam@gmail.com>,
	NXP Linux Team <linux-imx@nxp.com>,
	Lucas Stach <l.stach@pengutronix.de>,
	devicetree@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/2] arm64: dts: imx8mp: Fix power-domain typo
Date: Sun, 18 Dec 2022 17:02:52 +0200	[thread overview]
Message-ID: <Y58rnBMSLHtELIU4@pendragon.ideasonboard.com> (raw)
In-Reply-To: <20221217180849.775718-2-aford173@gmail.com>

Hi Adam,

Thank you for the patch.

On Sat, Dec 17, 2022 at 12:08:49PM -0600, Adam Ford wrote:
> dt_binding_check detects an issue with the pgc_hsiomix power
> domain:
>   pgc: 'power-domains@17' does not match any of the regexes
> 
> This is because 'power-domains' should be 'power-domain'

Oops.

Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>

> Fixes: 2ae42e0c0b67 ("arm64: dts: imx8mp: add HSIO power-domains")
> Signed-off-by: Adam Ford <aford173@gmail.com>
> 
> diff --git a/arch/arm64/boot/dts/freescale/imx8mp.dtsi b/arch/arm64/boot/dts/freescale/imx8mp.dtsi
> index 7a8ca56e48b6..19609ef0560a 100644
> --- a/arch/arm64/boot/dts/freescale/imx8mp.dtsi
> +++ b/arch/arm64/boot/dts/freescale/imx8mp.dtsi
> @@ -591,7 +591,7 @@ pgc_mipi_phy2: power-domain@16 {
>  						reg = <IMX8MP_POWER_DOMAIN_MIPI_PHY2>;
>  					};
>  
> -					pgc_hsiomix: power-domains@17 {
> +					pgc_hsiomix: power-domain@17 {
>  						#power-domain-cells = <0>;
>  						reg = <IMX8MP_POWER_DOMAIN_HSIOMIX>;
>  						clocks = <&clk IMX8MP_CLK_HSIO_AXI>,

-- 
Regards,

Laurent Pinchart

  reply	other threads:[~2022-12-18 15:03 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-12-17 18:08 [PATCH 1/2] arm64: dts: imx8mp: Fix missing GPC Interrupt Adam Ford
2022-12-17 18:08 ` Adam Ford
2022-12-17 18:08 ` [PATCH 2/2] arm64: dts: imx8mp: Fix power-domain typo Adam Ford
2022-12-17 18:08   ` Adam Ford
2022-12-18 15:02   ` Laurent Pinchart [this message]
2022-12-18 15:02     ` Laurent Pinchart
2022-12-18 15:00 ` [PATCH 1/2] arm64: dts: imx8mp: Fix missing GPC Interrupt Laurent Pinchart
2022-12-18 15:00   ` Laurent Pinchart
2022-12-18 15:58   ` Adam Ford
2022-12-18 15:58     ` Adam Ford
2023-01-01  3:37 ` Shawn Guo
2023-01-01  3:37   ` Shawn Guo

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=Y58rnBMSLHtELIU4@pendragon.ideasonboard.com \
    --to=laurent.pinchart@ideasonboard.com \
    --cc=aford173@gmail.com \
    --cc=aford@beaconembedded.com \
    --cc=devicetree@vger.kernel.org \
    --cc=festevam@gmail.com \
    --cc=kernel@pengutronix.de \
    --cc=krzysztof.kozlowski+dt@linaro.org \
    --cc=l.stach@pengutronix.de \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-imx@nxp.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=robh+dt@kernel.org \
    --cc=s.hauer@pengutronix.de \
    --cc=shawnguo@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.