From: Mark Brown <broonie@kernel.org>
To: Dhruva Gole <d-gole@ti.com>
Cc: Han Xu <han.xu@nxp.com>,
linux-spi@vger.kernel.org, linux-kernel@vger.kernel.org,
robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org
Subject: Re: [PATCH 1/2] spi: spi-fsl-lpspi: support multiple cs for lpspi
Date: Wed, 7 Dec 2022 13:44:16 +0000 [thread overview]
Message-ID: <Y5CYsDFdAEduswvm@sirena.org.uk> (raw)
In-Reply-To: <4ed39c8f-3736-30d6-8d8c-92a4882b72e7@ti.com>
[-- Attachment #1: Type: text/plain, Size: 543 bytes --]
On Wed, Dec 07, 2022 at 12:08:43PM +0530, Dhruva Gole wrote:
> On 07/12/22 04:24, Han Xu wrote:
> > support to get chip select number from DT file.
> > + fsl_lpspi->num_cs = 1;
> I am not sure I understand why you are setting this to 1 here?
> I am assuming it is because you want num_cs to default to 1 if
> it is not specified in DT.
> Please can you also add a dev_err and be sure to warn about this?
The binding says that this property is optional with a default of 1 so
it should be totally fine for a system to not specify anything.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
next prev parent reply other threads:[~2022-12-07 13:44 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-12-06 22:54 [PATCH 1/2] spi: spi-fsl-lpspi: support multiple cs for lpspi Han Xu
2022-12-06 22:54 ` [PATCH 2/2] dt-bindings: spi: spi-fsl-lpspi: add num-cs " Han Xu
2022-12-07 8:33 ` Krzysztof Kozlowski
2022-12-07 6:38 ` [PATCH 1/2] spi: spi-fsl-lpspi: support multiple cs " Dhruva Gole
2022-12-07 13:44 ` Mark Brown [this message]
2022-12-07 16:21 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Y5CYsDFdAEduswvm@sirena.org.uk \
--to=broonie@kernel.org \
--cc=d-gole@ti.com \
--cc=han.xu@nxp.com \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-spi@vger.kernel.org \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.