From: Jason Gunthorpe <jgg@nvidia.com>
To: Robin Murphy <robin.murphy@arm.com>
Cc: Baolu Lu <baolu.lu@linux.intel.com>,
Niklas Schnelle <schnelle@linux.ibm.com>,
Matthew Rosato <mjrosato@linux.ibm.com>,
Gerd Bayer <gbayer@linux.ibm.com>,
iommu@lists.linux.dev, Joerg Roedel <joro@8bytes.org>,
Will Deacon <will@kernel.org>,
Wenjia Zhang <wenjia@linux.ibm.com>,
Pierre Morel <pmorel@linux.ibm.com>,
linux-s390@vger.kernel.org, borntraeger@linux.ibm.com,
hca@linux.ibm.com, gor@linux.ibm.com,
gerald.schaefer@linux.ibm.com, agordeev@linux.ibm.com,
svens@linux.ibm.com, linux-kernel@vger.kernel.org,
Julian Ruess <julianr@linux.ibm.com>
Subject: Re: [PATCH v2 4/7] iommu: Let iommu.strict override ops->def_domain_type
Date: Wed, 7 Dec 2022 10:30:42 -0400 [thread overview]
Message-ID: <Y5CjklN39iYeUDX9@nvidia.com> (raw)
In-Reply-To: <73a033d6-c1fe-c012-4648-774aa5b93a61@arm.com>
On Wed, Dec 07, 2022 at 02:18:36PM +0000, Robin Murphy wrote:
> On 2022-12-07 13:23, Jason Gunthorpe wrote:
> > On Wed, Dec 07, 2022 at 09:18:19PM +0800, Baolu Lu wrote:
> >
> > > > - /* Check if the device in the group still has a driver bound to it */
> > > > - device_lock(dev);
> > >
> > > With device_lock() removed, this probably races with the
> > > iommu_release_device() path? group->mutex seems insufficient to avoid
> > > the race. Perhaps I missed anything.
> >
> > This path only deals with group, so there is no 'dev' and no race with
> > removal.
>
> If we can now use the ownership mechanism to enforce the required
> constraints for change_dev_def_domain, that would be worthwhile (and a lot
> clearer) as a separate patch in its own right.
Oh for sure, this is just a brain dump to share
I have a few other patches streamlining things in this file, just need time...
Jason
next prev parent reply other threads:[~2022-12-07 14:30 UTC|newest]
Thread overview: 39+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-11-16 17:16 [PATCH v2 0/7] iommu/dma: s390 DMA API conversion and optimized IOTLB flushing Niklas Schnelle
2022-11-16 17:16 ` [PATCH v2 1/7] s390/ism: Set DMA coherent mask Niklas Schnelle
2022-11-16 17:16 ` [PATCH v2 2/7] s390/pci: prepare is_passed_through() for dma-iommu Niklas Schnelle
2022-11-16 17:16 ` [PATCH v2 3/7] s390/pci: Use dma-iommu layer Niklas Schnelle
2022-11-28 18:03 ` Robin Murphy
2022-12-19 15:17 ` Niklas Schnelle
2022-11-16 17:16 ` [PATCH v2 4/7] iommu: Let iommu.strict override ops->def_domain_type Niklas Schnelle
2022-11-17 1:55 ` Baolu Lu
2022-11-28 11:10 ` Niklas Schnelle
2022-11-28 13:00 ` Baolu Lu
2022-11-28 13:29 ` Jason Gunthorpe
2022-11-28 15:54 ` Niklas Schnelle
2022-11-28 16:35 ` Jason Gunthorpe
2022-11-28 21:01 ` Robin Murphy
2022-11-29 17:33 ` Jason Gunthorpe
2022-11-29 18:41 ` Robin Murphy
2022-11-29 20:09 ` Jason Gunthorpe
2022-11-30 1:28 ` Baolu Lu
2022-12-05 15:34 ` Niklas Schnelle
2022-12-06 23:09 ` Jason Gunthorpe
2022-12-07 13:18 ` Baolu Lu
2022-12-07 13:23 ` Jason Gunthorpe
2022-12-07 14:18 ` Robin Murphy
2022-12-07 14:30 ` Jason Gunthorpe [this message]
2022-11-28 16:56 ` Robin Murphy
2022-11-16 17:16 ` [PATCH v2 5/7] iommu/dma: Allow a single FQ in addition to per-CPU FQs Niklas Schnelle
2022-11-16 17:16 ` [PATCH v2 6/7] iommu/dma: Enable variable queue size and use larger single queue Niklas Schnelle
2022-11-16 17:16 ` [PATCH v2 7/7] iommu/s390: flush queued IOVAs on RPCIT out of resource indication Niklas Schnelle
2022-11-28 14:52 ` Robin Murphy
2022-11-29 12:00 ` Niklas Schnelle
2022-11-29 12:53 ` Robin Murphy
2022-11-29 14:40 ` Niklas Schnelle
2022-12-02 14:29 ` Niklas Schnelle
2022-12-02 14:42 ` Jason Gunthorpe
2022-12-02 15:12 ` Niklas Schnelle
2022-12-02 15:24 ` Jason Gunthorpe
2022-12-05 18:24 ` Robin Murphy
2022-12-06 10:13 ` Niklas Schnelle
2022-11-29 13:51 ` Matthew Rosato
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Y5CjklN39iYeUDX9@nvidia.com \
--to=jgg@nvidia.com \
--cc=agordeev@linux.ibm.com \
--cc=baolu.lu@linux.intel.com \
--cc=borntraeger@linux.ibm.com \
--cc=gbayer@linux.ibm.com \
--cc=gerald.schaefer@linux.ibm.com \
--cc=gor@linux.ibm.com \
--cc=hca@linux.ibm.com \
--cc=iommu@lists.linux.dev \
--cc=joro@8bytes.org \
--cc=julianr@linux.ibm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-s390@vger.kernel.org \
--cc=mjrosato@linux.ibm.com \
--cc=pmorel@linux.ibm.com \
--cc=robin.murphy@arm.com \
--cc=schnelle@linux.ibm.com \
--cc=svens@linux.ibm.com \
--cc=wenjia@linux.ibm.com \
--cc=will@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.