From: Taylor Blau <me@ttaylorr.com>
To: Johannes Schindelin via GitGitGadget <gitgitgadget@gmail.com>
Cc: git@vger.kernel.org, Johannes Schindelin <johannes.schindelin@gmx.de>
Subject: Re: [PATCH 1/4] ci: use a newer `github-script` version
Date: Wed, 7 Dec 2022 17:22:33 -0500 [thread overview]
Message-ID: <Y5ESKYvOyrnbCV+B@nand.local> (raw)
In-Reply-To: <472481561f03900fb519065d88ae8af910bea794.1670423680.git.gitgitgadget@gmail.com>
On Wed, Dec 07, 2022 at 02:34:37PM +0000, Johannes Schindelin via GitGitGadget wrote:
> From: Johannes Schindelin <johannes.schindelin@gmx.de>
>
> The old version we currently use runs in node.js v12.x, which is being
> deprecated in GitHub Actions. The new version uses node.js v16.x.
>
> Incidentally, this also avoids the warning about the deprecated
> `::set-output::` workflow command because the newer version of the
> `github-script` Action uses the recommended new way to specify outputs.
>
> Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de>
> Signed-off-by: Taylor Blau <me@ttaylorr.com>
It took me a second to remember why my S-o-b was here, but it looks like
this is from when I queued this patch in [1], which is on 'master' as of
63357b79c9 (ci: use a newer `github-script` version, 2022-11-08).
So having my S-o-b here is definitely OK (since I was the one who put it
there in the first place!), but I don't think we need to re-queue this
patch, unless it was reverted out in the meantime (which it doesn't
appear to be).
Thanks,
Taylor
[1]: https://lore.kernel.org/git/Y2q9723uEtfkJrah@nand.local/
next prev parent reply other threads:[~2022-12-07 22:22 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-12-07 14:34 [PATCH 0/4] Avoid using deprecated features in Git's GitHub workflows Johannes Schindelin via GitGitGadget
2022-12-07 14:34 ` [PATCH 1/4] ci: use a newer `github-script` version Johannes Schindelin via GitGitGadget
2022-12-07 22:22 ` Taylor Blau [this message]
2022-12-07 14:34 ` [PATCH 2/4] ci: avoid deprecated `set-output` workflow command Johannes Schindelin via GitGitGadget
2022-12-07 22:24 ` Taylor Blau
2022-12-07 14:34 ` [PATCH 3/4] ci: avoid using deprecated {up,down}load-artifacts Action Johannes Schindelin via GitGitGadget
2022-12-07 14:34 ` [PATCH 4/4] ci(l10n): avoid using the deprecated `set-output` workflow command Johannes Schindelin via GitGitGadget
2022-12-07 22:40 ` [PATCH 0/4] Avoid using deprecated features in Git's GitHub workflows Taylor Blau
2022-12-07 23:58 ` Junio C Hamano
2022-12-08 5:50 ` Junio C Hamano
2022-12-07 22:42 ` Ævar Arnfjörð Bjarmason
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Y5ESKYvOyrnbCV+B@nand.local \
--to=me@ttaylorr.com \
--cc=git@vger.kernel.org \
--cc=gitgitgadget@gmail.com \
--cc=johannes.schindelin@gmx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.