All of lore.kernel.org
 help / color / mirror / Atom feed
From: Taylor Blau <me@ttaylorr.com>
To: Johannes Schindelin via GitGitGadget <gitgitgadget@gmail.com>
Cc: git@vger.kernel.org, Johannes Schindelin <johannes.schindelin@gmx.de>
Subject: Re: [PATCH 2/4] ci: avoid deprecated `set-output` workflow command
Date: Wed, 7 Dec 2022 17:24:18 -0500	[thread overview]
Message-ID: <Y5ESknffj5iWF0IY@nand.local> (raw)
In-Reply-To: <1693393443975bc25f3020e61a29944804e35601.1670423680.git.gitgitgadget@gmail.com>

On Wed, Dec 07, 2022 at 02:34:38PM +0000, Johannes Schindelin via GitGitGadget wrote:
> From: Johannes Schindelin <johannes.schindelin@gmx.de>
>
> Due to security concerns, this command was deprecated and we need to
> write into `$GITHUB_OUTPUT` instead. For more details, see
> https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/

OK, this one and [1] are pretty similar. I don't have a strong
preference between one or the other, though I suspect it will be easier
for the maintainer to pick them all up from the same series.

So in that sense I guess I have a slight preference for this one, though
I admit to not feeling very strongly about it ;-).

Thanks,
Taylor

[1]: https://lore.kernel.org/git/patch-1.1-deb65805345-20221206T195811Z-avarab@gmail.com/

  reply	other threads:[~2022-12-07 22:24 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-12-07 14:34 [PATCH 0/4] Avoid using deprecated features in Git's GitHub workflows Johannes Schindelin via GitGitGadget
2022-12-07 14:34 ` [PATCH 1/4] ci: use a newer `github-script` version Johannes Schindelin via GitGitGadget
2022-12-07 22:22   ` Taylor Blau
2022-12-07 14:34 ` [PATCH 2/4] ci: avoid deprecated `set-output` workflow command Johannes Schindelin via GitGitGadget
2022-12-07 22:24   ` Taylor Blau [this message]
2022-12-07 14:34 ` [PATCH 3/4] ci: avoid using deprecated {up,down}load-artifacts Action Johannes Schindelin via GitGitGadget
2022-12-07 14:34 ` [PATCH 4/4] ci(l10n): avoid using the deprecated `set-output` workflow command Johannes Schindelin via GitGitGadget
2022-12-07 22:40 ` [PATCH 0/4] Avoid using deprecated features in Git's GitHub workflows Taylor Blau
2022-12-07 23:58   ` Junio C Hamano
2022-12-08  5:50     ` Junio C Hamano
2022-12-07 22:42 ` Ævar Arnfjörð Bjarmason

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=Y5ESknffj5iWF0IY@nand.local \
    --to=me@ttaylorr.com \
    --cc=git@vger.kernel.org \
    --cc=gitgitgadget@gmail.com \
    --cc=johannes.schindelin@gmx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.