From: Lee Jones <lee@kernel.org>
To: Yang Yingliang <yangyingliang@huawei.com>
Cc: agross@kernel.org, andersson@kernel.org,
konrad.dybcio@somainline.org, gurus@codeaurora.org,
linux-arm-msm@vger.kernel.org
Subject: Re: [PATCH resend] mfd: pm8008: Fix return value check in pm8008_probe()
Date: Thu, 8 Dec 2022 14:39:19 +0000 [thread overview]
Message-ID: <Y5H3AFT08cr8adUK@google.com> (raw)
In-Reply-To: <20221125073626.1868229-1-yangyingliang@huawei.com>
On Fri, 25 Nov 2022, Yang Yingliang wrote:
> In case of error, the function devm_regmap_init_i2c() returns
> ERR_PTR() and never returns NULL. The NULL test in the return
> value check should be replaced with IS_ERR().
>
> Fixes: 6b149f3310a4 ("mfd: pm8008: Add driver for QCOM PM8008 PMIC")
> Signed-off-by: Yang Yingliang <yangyingliang@huawei.com>
> Reviewed-by: Bjorn Andersson <bjorn.andersson@linaro.org>
> Acked-by: Guru Das Srinagesh <gurus@codeaurora.org>
> ---
> The previous patch link:
> https://lore.kernel.org/lkml/20210605022446.4119978-1-yangyingliang@huawei.com/
> ---
> drivers/mfd/qcom-pm8008.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
Applied, thanks.
--
Lee Jones [李琼斯]
prev parent reply other threads:[~2022-12-08 14:40 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-11-25 7:36 [PATCH resend] mfd: pm8008: Fix return value check in pm8008_probe() Yang Yingliang
2022-12-08 14:39 ` Lee Jones [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Y5H3AFT08cr8adUK@google.com \
--to=lee@kernel.org \
--cc=agross@kernel.org \
--cc=andersson@kernel.org \
--cc=gurus@codeaurora.org \
--cc=konrad.dybcio@somainline.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=yangyingliang@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.