From: Lee Jones <lee@kernel.org>
To: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
Cc: Andy Gross <agross@kernel.org>,
Bjorn Andersson <andersson@kernel.org>,
Konrad Dybcio <konrad.dybcio@linaro.org>,
Linus Walleij <linus.walleij@linaro.org>,
linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org,
Lee Jones <lee.jones@linaro.org>,
linux-arm-msm@vger.kernel.org
Subject: Re: [PATCH 1/2] mfd: qcom_rpm: Fix an error handling path in qcom_rpm_probe()
Date: Thu, 8 Dec 2022 12:41:13 +0000 [thread overview]
Message-ID: <Y5Hbado70xVuy3iq@google.com> (raw)
In-Reply-To: <e39752476d02605b2be46cab7115f71255ce13a8.1668949256.git.christophe.jaillet@wanadoo.fr>
On Sun, 20 Nov 2022, Christophe JAILLET wrote:
> If an error occurs after the clk_prepare_enable() call, a corresponding
> clk_disable_unprepare() should be called.
>
> Simplify code and switch to devm_clk_get_enabled() to fix it.
>
> Fixes: 3526403353c2 ("mfd: qcom_rpm: Handle message RAM clock")
> Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
> ---
> This changes the order of the clean-ups if the .remove() function is called
> but it looks fine to me.
> ---
> drivers/mfd/qcom_rpm.c | 4 +---
> 1 file changed, 1 insertion(+), 3 deletions(-)
Applied, thanks.
--
Lee Jones [李琼斯]
prev parent reply other threads:[~2022-12-08 12:41 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-11-20 13:01 [PATCH 1/2] mfd: qcom_rpm: Fix an error handling path in qcom_rpm_probe() Christophe JAILLET
2022-11-20 17:19 ` Christophe JAILLET
2022-11-20 17:05 ` Christophe JAILLET
2022-11-20 13:01 ` [PATCH 2/2] mfd: qcom_rpm: Use devm_of_platform_populate() to simplify code Christophe JAILLET
2022-12-08 12:41 ` Lee Jones
2022-11-20 17:19 ` [PATCH] cpufreq: tegra186: Use flexible array to simplify memory allocation Christophe JAILLET
2022-12-01 9:20 ` Viresh Kumar
2022-12-08 12:30 ` [PATCH 1/2] mfd: qcom_rpm: Fix an error handling path in qcom_rpm_probe() Lee Jones
2022-12-08 18:31 ` Christophe JAILLET
2022-12-08 12:41 ` Lee Jones [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Y5Hbado70xVuy3iq@google.com \
--to=lee@kernel.org \
--cc=agross@kernel.org \
--cc=andersson@kernel.org \
--cc=christophe.jaillet@wanadoo.fr \
--cc=kernel-janitors@vger.kernel.org \
--cc=konrad.dybcio@linaro.org \
--cc=lee.jones@linaro.org \
--cc=linus.walleij@linaro.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.