From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Matt Jan <zoo868e@gmail.com>
Cc: Martyn Welch <martyn@welchs.me.uk>,
Manohar Vanga <manohar.vanga@gmail.com>,
linux-kernel@vger.kernel.org, linux-staging@lists.linux.dev
Subject: Re: [PATCH v2 1/3] staging: vme_user: add the spaces around the "*"
Date: Thu, 8 Dec 2022 14:17:58 +0100 [thread overview]
Message-ID: <Y5HkBnptiY06DtRL@kroah.com> (raw)
In-Reply-To: <20221208103813.GA100066@zoo868e>
On Thu, Dec 08, 2022 at 06:38:13PM +0800, Matt Jan wrote:
> Add a space around the "*" at vme_bridge.h to clear up a checkpatch
> check.
>
> Signed-off-by: Matt Jan <zoo868e@gmail.com>
> ---
> drivers/staging/vme_user/vme_bridge.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/staging/vme_user/vme_bridge.h b/drivers/staging/vme_user/vme_bridge.h
> index 0bbefe9851d7..e17a8f7de165 100644
> --- a/drivers/staging/vme_user/vme_bridge.h
> +++ b/drivers/staging/vme_user/vme_bridge.h
> @@ -4,7 +4,7 @@
>
> #include "vme.h"
>
> -#define VME_CRCSR_BUF_SIZE (508*1024)
> +#define VME_CRCSR_BUF_SIZE (508 * 1024)
> /*
> * Resource structures
> */
> --
> 2.25.1
> v2: Resend the correct patch set, noted by Greg Kroah-Hartmamn <gregkh@linuxfoundation.org>
This "v2" stuff goes below the "---" line, not down here below the patch
itself.
Also this series is not properly threaded at all, please use 'git
send-email' to do so so that our tools will properly pick up the whole
thread, and not just individual emails.
Can you fix this all up and send a v3 please?
thanks,
greg k-h
prev parent reply other threads:[~2022-12-08 13:18 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-12-08 10:38 [PATCH v2 1/3] staging: vme_user: add the spaces around the "*" Matt Jan
2022-12-08 13:17 ` Greg Kroah-Hartman [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Y5HkBnptiY06DtRL@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-staging@lists.linux.dev \
--cc=manohar.vanga@gmail.com \
--cc=martyn@welchs.me.uk \
--cc=zoo868e@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.