From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id AF1BBC4332F for ; Fri, 9 Dec 2022 16:46:10 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229634AbiLIQqI (ORCPT ); Fri, 9 Dec 2022 11:46:08 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:39974 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229704AbiLIQpx (ORCPT ); Fri, 9 Dec 2022 11:45:53 -0500 Received: from orbyte.nwl.cc (orbyte.nwl.cc [IPv6:2001:41d0:e:133a::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 4D3912E6A1 for ; Fri, 9 Dec 2022 08:45:50 -0800 (PST) Received: from n0-1 by orbyte.nwl.cc with local (Exim 4.94.2) (envelope-from ) id 1p3gVQ-0004jx-Mm; Fri, 09 Dec 2022 17:45:48 +0100 Date: Fri, 9 Dec 2022 17:45:48 +0100 From: Phil Sutter To: Pablo Neira Ayuso Cc: netfilter-devel@vger.kernel.org, Florian Westphal Subject: Re: [nft PATCH 3/4] xt: Rewrite unsupported compat expression dumping Message-ID: Mail-Followup-To: Phil Sutter , Pablo Neira Ayuso , netfilter-devel@vger.kernel.org, Florian Westphal References: <20221124165641.26921-1-phil@nwl.cc> <20221124165641.26921-4-phil@nwl.cc> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: netfilter-devel@vger.kernel.org On Fri, Dec 09, 2022 at 05:07:18PM +0100, Pablo Neira Ayuso wrote: > On Thu, Nov 24, 2022 at 05:56:40PM +0100, Phil Sutter wrote: > > Choose a format which provides more information and is easily parseable. > > Then teach parsers about it and make it explicitly reject the ruleset > > giving a meaningful explanation. Also update the man pages with some > > more details. > > There is a bugzilla ticket related to xt and json support, you can > probably add a Closes: tag link. This should be nfbz#1621, but it's about translating xt to native in JSON format. All my patch does is extend the xt JSON format a bit. AIUI, we would have to extend libxtables to provide translations into JSON. So even with perfect two-ways translation available, JSON interface is unusable if iptables-nft is in use. Cheers, Phil