From mboxrd@z Thu Jan 1 00:00:00 1970 From: Oliver Upton Date: Fri, 9 Dec 2022 17:31:53 +0000 Subject: [RFC PATCH 23/37] KVM: MMU: Move VM-level TDP MMU state to struct kvm In-Reply-To: <20221208193857.4090582-24-dmatlack@google.com> References: <20221208193857.4090582-1-dmatlack@google.com> <20221208193857.4090582-24-dmatlack@google.com> Message-ID: List-Id: To: kvm-riscv@lists.infradead.org MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Hey David, On Thu, Dec 08, 2022 at 11:38:43AM -0800, David Matlack wrote: > Move VM-level TDP MMU state to struct kvm so it can be accessed by > common code in a future commit. > > No functional change intended. Could you instead introduce a structure to hold all of the MMU state and stick that in struct kvm? If the goal is to eventually supersede all uses of the arm64 pgtable library we are going to need the ability to operate outside of a KVM VM context. -- Thanks, Oliver From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mm01.cs.columbia.edu (mm01.cs.columbia.edu [128.59.11.253]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0F12BC4332F for ; Fri, 9 Dec 2022 17:32:07 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by mm01.cs.columbia.edu (Postfix) with ESMTP id 69E814B9AB; Fri, 9 Dec 2022 12:32:07 -0500 (EST) X-Virus-Scanned: at lists.cs.columbia.edu Authentication-Results: mm01.cs.columbia.edu (amavisd-new); dkim=softfail (fail, message has been altered) header.i=@linux.dev Received: from mm01.cs.columbia.edu ([127.0.0.1]) by localhost (mm01.cs.columbia.edu [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id yMovzIUn2fhr; Fri, 9 Dec 2022 12:32:06 -0500 (EST) Received: from mm01.cs.columbia.edu (localhost [127.0.0.1]) by mm01.cs.columbia.edu (Postfix) with ESMTP id 530AB4B9EE; Fri, 9 Dec 2022 12:32:06 -0500 (EST) Received: from localhost (localhost [127.0.0.1]) by mm01.cs.columbia.edu (Postfix) with ESMTP id B46D34B9AB for ; Fri, 9 Dec 2022 12:32:04 -0500 (EST) X-Virus-Scanned: at lists.cs.columbia.edu Received: from mm01.cs.columbia.edu ([127.0.0.1]) by localhost (mm01.cs.columbia.edu [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id En+3JW2cPxdx for ; Fri, 9 Dec 2022 12:32:03 -0500 (EST) Received: from out2.migadu.com (out2.migadu.com [188.165.223.204]) by mm01.cs.columbia.edu (Postfix) with ESMTPS id 4A5664B9D0 for ; Fri, 9 Dec 2022 12:32:03 -0500 (EST) Date: Fri, 9 Dec 2022 17:31:53 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.dev; s=key1; t=1670607121; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=Quc9rtPvjsg9ew9MEiiQXhgVWUDAsktBrFeTkewNKkw=; b=S3aITMWC9VbOiaYPYv282HLl69TTYT2DXs1taXC8F5AvLpueQkCZpRcqJJZ7MEQ/z1ikxk 7SzK+vSIPm3olMNUfZjwywjGs/lA9BCHsEmRUTaRS9hVsFlgnqS/uvWtj6U8PgwtrWn919 I22lC+tRKRHudvDQNy7Z+U+0R6DGNBs= X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. From: Oliver Upton To: David Matlack Subject: Re: [RFC PATCH 23/37] KVM: MMU: Move VM-level TDP MMU state to struct kvm Message-ID: References: <20221208193857.4090582-1-dmatlack@google.com> <20221208193857.4090582-24-dmatlack@google.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20221208193857.4090582-24-dmatlack@google.com> X-Migadu-Flow: FLOW_OUT Cc: Anshuman Khandual , Hugh Dickins , Paul Walmsley , Nadav Amit , Ben Gardon , linux-riscv@lists.infradead.org, kvmarm@lists.cs.columbia.edu, Yu Zhao , xu xin , Huacai Chen , "Matthew Wilcox \(Oracle\)" , Aleksandar Markovic , Krish Sadhukhan , Palmer Dabbelt , Mingwei Zhang , Albert Ou , Arnd Bergmann , "Liam R. Howlett" , kvm@vger.kernel.org, Atish Patra , kvmarm@lists.linux.dev, Suren Baghdasaryan , Vlastimil Babka , linux-arm-kernel@lists.infradead.org, linux-mips@vger.kernel.org, Colin Cross , kvm-riscv@lists.infradead.org, Marc Zyngier , Paolo Bonzini , Andrew Morton X-BeenThere: kvmarm@lists.cs.columbia.edu X-Mailman-Version: 2.1.14 Precedence: list List-Id: Where KVM/ARM decisions are made List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: kvmarm-bounces@lists.cs.columbia.edu Sender: kvmarm-bounces@lists.cs.columbia.edu Hey David, On Thu, Dec 08, 2022 at 11:38:43AM -0800, David Matlack wrote: > Move VM-level TDP MMU state to struct kvm so it can be accessed by > common code in a future commit. > > No functional change intended. Could you instead introduce a structure to hold all of the MMU state and stick that in struct kvm? If the goal is to eventually supersede all uses of the arm64 pgtable library we are going to need the ability to operate outside of a KVM VM context. -- Thanks, Oliver _______________________________________________ kvmarm mailing list kvmarm@lists.cs.columbia.edu https://lists.cs.columbia.edu/mailman/listinfo/kvmarm From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from out2.migadu.com (out2.migadu.com [188.165.223.204]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id DDB0763C5 for ; Fri, 9 Dec 2022 17:32:03 +0000 (UTC) Date: Fri, 9 Dec 2022 17:31:53 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.dev; s=key1; t=1670607121; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=Quc9rtPvjsg9ew9MEiiQXhgVWUDAsktBrFeTkewNKkw=; b=S3aITMWC9VbOiaYPYv282HLl69TTYT2DXs1taXC8F5AvLpueQkCZpRcqJJZ7MEQ/z1ikxk 7SzK+vSIPm3olMNUfZjwywjGs/lA9BCHsEmRUTaRS9hVsFlgnqS/uvWtj6U8PgwtrWn919 I22lC+tRKRHudvDQNy7Z+U+0R6DGNBs= X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. From: Oliver Upton To: David Matlack Cc: Paolo Bonzini , Marc Zyngier , James Morse , Alexandru Elisei , Suzuki K Poulose , Huacai Chen , Aleksandar Markovic , Anup Patel , Atish Patra , Paul Walmsley , Palmer Dabbelt , Albert Ou , Sean Christopherson , Andrew Morton , Anshuman Khandual , Nadav Amit , "Matthew Wilcox (Oracle)" , Vlastimil Babka , "Liam R. Howlett" , Suren Baghdasaryan , Peter Xu , xu xin , Arnd Bergmann , Yu Zhao , Colin Cross , Hugh Dickins , Ben Gardon , Mingwei Zhang , Krish Sadhukhan , Ricardo Koller , Jing Zhang , linux-arm-kernel@lists.infradead.org, kvmarm@lists.linux.dev, kvmarm@lists.cs.columbia.edu, linux-mips@vger.kernel.org, kvm@vger.kernel.org, kvm-riscv@lists.infradead.org, linux-riscv@lists.infradead.org Subject: Re: [RFC PATCH 23/37] KVM: MMU: Move VM-level TDP MMU state to struct kvm Message-ID: References: <20221208193857.4090582-1-dmatlack@google.com> <20221208193857.4090582-24-dmatlack@google.com> Precedence: bulk X-Mailing-List: kvmarm@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20221208193857.4090582-24-dmatlack@google.com> X-Migadu-Flow: FLOW_OUT Message-ID: <20221209173153.NAhbovEnsmX3IePIN3J53A3BbtUPqet0iAVwTFfv6jQ@z> Hey David, On Thu, Dec 08, 2022 at 11:38:43AM -0800, David Matlack wrote: > Move VM-level TDP MMU state to struct kvm so it can be accessed by > common code in a future commit. > > No functional change intended. Could you instead introduce a structure to hold all of the MMU state and stick that in struct kvm? If the goal is to eventually supersede all uses of the arm64 pgtable library we are going to need the ability to operate outside of a KVM VM context. -- Thanks, Oliver From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 3B170C4332F for ; Fri, 9 Dec 2022 17:32:26 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=c3flFBOgBATdXTIGCUy1qjF1va6tdrkw1b8Zq3fmX2U=; b=nZK8k+TaGwaPZD PTMSkiGuafu8GBvN9Rs5cVzuEkp1F1RQKzY5v/MDbzHL2L8m8tuQQpHYxYVx4eOqEDKEnliUS2101 1U51SH9Ch/9WyA+6QsCzsBPrYNPHLrvHVpedQlagejHEfmn4eJmjumO3h3oYtnSqXWjeNWtDYA51l pH1FD2CopoGfmZxQ/3RQ+LluReixmnRQQu6FEnUCsXug4VLnFPPFKJCltJumpDCmXEKwSriJQYOTK Eq3DJ4olFjRFn6SyCwcTNEZqE7abkjJWrJLcBuxEHNUbIB/De9G8/uUWdnA2E8DIIvUpkf/KDNdFb 29nYtXGYxRlcvh69C73A==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1p3hEQ-009wXM-7S; Fri, 09 Dec 2022 17:32:18 +0000 Received: from out2.migadu.com ([188.165.223.204]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1p3hEE-009wTG-2D; Fri, 09 Dec 2022 17:32:07 +0000 Date: Fri, 9 Dec 2022 17:31:53 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.dev; s=key1; t=1670607121; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=Quc9rtPvjsg9ew9MEiiQXhgVWUDAsktBrFeTkewNKkw=; b=S3aITMWC9VbOiaYPYv282HLl69TTYT2DXs1taXC8F5AvLpueQkCZpRcqJJZ7MEQ/z1ikxk 7SzK+vSIPm3olMNUfZjwywjGs/lA9BCHsEmRUTaRS9hVsFlgnqS/uvWtj6U8PgwtrWn919 I22lC+tRKRHudvDQNy7Z+U+0R6DGNBs= X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. From: Oliver Upton To: David Matlack Cc: Paolo Bonzini , Marc Zyngier , James Morse , Alexandru Elisei , Suzuki K Poulose , Huacai Chen , Aleksandar Markovic , Anup Patel , Atish Patra , Paul Walmsley , Palmer Dabbelt , Albert Ou , Sean Christopherson , Andrew Morton , Anshuman Khandual , Nadav Amit , "Matthew Wilcox (Oracle)" , Vlastimil Babka , "Liam R. Howlett" , Suren Baghdasaryan , Peter Xu , xu xin , Arnd Bergmann , Yu Zhao , Colin Cross , Hugh Dickins , Ben Gardon , Mingwei Zhang , Krish Sadhukhan , Ricardo Koller , Jing Zhang , linux-arm-kernel@lists.infradead.org, kvmarm@lists.linux.dev, kvmarm@lists.cs.columbia.edu, linux-mips@vger.kernel.org, kvm@vger.kernel.org, kvm-riscv@lists.infradead.org, linux-riscv@lists.infradead.org Subject: Re: [RFC PATCH 23/37] KVM: MMU: Move VM-level TDP MMU state to struct kvm Message-ID: References: <20221208193857.4090582-1-dmatlack@google.com> <20221208193857.4090582-24-dmatlack@google.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20221208193857.4090582-24-dmatlack@google.com> X-Migadu-Flow: FLOW_OUT X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20221209_093206_286539_B3EE2AAE X-CRM114-Status: UNSURE ( 9.08 ) X-CRM114-Notice: Please train this message. X-BeenThere: linux-riscv@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-riscv" Errors-To: linux-riscv-bounces+linux-riscv=archiver.kernel.org@lists.infradead.org Hey David, On Thu, Dec 08, 2022 at 11:38:43AM -0800, David Matlack wrote: > Move VM-level TDP MMU state to struct kvm so it can be accessed by > common code in a future commit. > > No functional change intended. Could you instead introduce a structure to hold all of the MMU state and stick that in struct kvm? If the goal is to eventually supersede all uses of the arm64 pgtable library we are going to need the ability to operate outside of a KVM VM context. -- Thanks, Oliver _______________________________________________ linux-riscv mailing list linux-riscv@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-riscv From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 0E488C4167B for ; Fri, 9 Dec 2022 17:33:14 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=vQSTn6cw5ysCkIfShwztfaaHqcxhLZgiP12jTxDhLkM=; b=p74J8xnZuO/tXq 3oM9IvjjNZfMBEs22K3rONl5he7AVPDFy4u4QULjMzpVNdNJigXQkiqs7HKVh9bxutowkWZSuM6Lr yJlCNIwtU7aYU+viGYqdMnyE0SFa7biMApfMjwQpNZABGNDkz9rUHnsR/8Ss4++9YOIo28w93G8yN KGFzfqxr6x1US3FPgA33+bSd4mhUxTewyPK7EUSiOTFJf/Tve5QJle88vQQWUrImpVlpD24aq5aVY HSpfIVfli+cm9pQD95Qt5PXCefyJF+vzVAbPQUFv9P18aoiK1/BsWbBPkmpLSU/ZZHbYUDhW4D81j shD8a0gxzPYjZK4WCdSg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1p3hEI-009wVL-HK; Fri, 09 Dec 2022 17:32:10 +0000 Received: from out2.migadu.com ([188.165.223.204]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1p3hEE-009wTG-2D; Fri, 09 Dec 2022 17:32:07 +0000 Date: Fri, 9 Dec 2022 17:31:53 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.dev; s=key1; t=1670607121; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=Quc9rtPvjsg9ew9MEiiQXhgVWUDAsktBrFeTkewNKkw=; b=S3aITMWC9VbOiaYPYv282HLl69TTYT2DXs1taXC8F5AvLpueQkCZpRcqJJZ7MEQ/z1ikxk 7SzK+vSIPm3olMNUfZjwywjGs/lA9BCHsEmRUTaRS9hVsFlgnqS/uvWtj6U8PgwtrWn919 I22lC+tRKRHudvDQNy7Z+U+0R6DGNBs= X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. From: Oliver Upton To: David Matlack Cc: Paolo Bonzini , Marc Zyngier , James Morse , Alexandru Elisei , Suzuki K Poulose , Huacai Chen , Aleksandar Markovic , Anup Patel , Atish Patra , Paul Walmsley , Palmer Dabbelt , Albert Ou , Sean Christopherson , Andrew Morton , Anshuman Khandual , Nadav Amit , "Matthew Wilcox (Oracle)" , Vlastimil Babka , "Liam R. Howlett" , Suren Baghdasaryan , Peter Xu , xu xin , Arnd Bergmann , Yu Zhao , Colin Cross , Hugh Dickins , Ben Gardon , Mingwei Zhang , Krish Sadhukhan , Ricardo Koller , Jing Zhang , linux-arm-kernel@lists.infradead.org, kvmarm@lists.linux.dev, kvmarm@lists.cs.columbia.edu, linux-mips@vger.kernel.org, kvm@vger.kernel.org, kvm-riscv@lists.infradead.org, linux-riscv@lists.infradead.org Subject: Re: [RFC PATCH 23/37] KVM: MMU: Move VM-level TDP MMU state to struct kvm Message-ID: References: <20221208193857.4090582-1-dmatlack@google.com> <20221208193857.4090582-24-dmatlack@google.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20221208193857.4090582-24-dmatlack@google.com> X-Migadu-Flow: FLOW_OUT X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20221209_093206_286539_B3EE2AAE X-CRM114-Status: UNSURE ( 9.08 ) X-CRM114-Notice: Please train this message. X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hey David, On Thu, Dec 08, 2022 at 11:38:43AM -0800, David Matlack wrote: > Move VM-level TDP MMU state to struct kvm so it can be accessed by > common code in a future commit. > > No functional change intended. Could you instead introduce a structure to hold all of the MMU state and stick that in struct kvm? If the goal is to eventually supersede all uses of the arm64 pgtable library we are going to need the ability to operate outside of a KVM VM context. -- Thanks, Oliver _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel