From: Saeed Mahameed <saeed@kernel.org>
To: Vladimir Oltean <vladimir.oltean@nxp.com>
Cc: netdev@vger.kernel.org, Andrew Lunn <andrew@lunn.ch>,
Florian Fainelli <f.fainelli@gmail.com>,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
"Hans J. Schultz" <netdev@kapio-technology.com>
Subject: Re: [PATCH v2 net-next 3/4] net: dsa: mv88e6xxx: replace ATU violation prints with trace points
Date: Fri, 9 Dec 2022 11:38:41 -0800 [thread overview]
Message-ID: <Y5OOwWIT/TL800aw@x130> (raw)
In-Reply-To: <20221209172817.371434-4-vladimir.oltean@nxp.com>
On 09 Dec 19:28, Vladimir Oltean wrote:
>In applications where the switch ports must perform 802.1X based
>authentication and are therefore locked, ATU violation interrupts are
>quite to be expected as part of normal operation. The problem is that
>they currently spam the kernel log, even if rate limited.
>
>Create a series of trace points, all derived from the same event class,
>which log these violations to the kernel's trace buffer, which is both
>much faster and much easier to ignore than printing to a serial console.
>
>New usage model:
>
>$ trace-cmd list | grep mv88e6xxx
>mv88e6xxx
>mv88e6xxx:mv88e6xxx_atu_full_violation
>mv88e6xxx:mv88e6xxx_atu_miss_violation
>mv88e6xxx:mv88e6xxx_atu_member_violation
>$ trace-cmd record -e mv88e6xxx sleep 10
>
>Signed-off-by: Vladimir Oltean <vladimir.oltean@nxp.com>
My knowledge on dsa is very limited but for the tracepoints logic:
Reviewed-by: Saeed Mahameed <saeed@kernel.org>
next prev parent reply other threads:[~2022-12-09 19:38 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-12-09 17:28 [PATCH v2 net-next 0/4] Trace points for mv88e6xxx Vladimir Oltean
2022-12-09 17:28 ` [PATCH v2 net-next 1/4] net: dsa: mv88e6xxx: remove ATU age out violation print Vladimir Oltean
2022-12-10 0:05 ` Florian Fainelli
2022-12-09 17:28 ` [PATCH v2 net-next 2/4] net: dsa: mv88e6xxx: read FID when handling ATU violations Vladimir Oltean
2022-12-10 0:05 ` Florian Fainelli
2022-12-09 17:28 ` [PATCH v2 net-next 3/4] net: dsa: mv88e6xxx: replace ATU violation prints with trace points Vladimir Oltean
2022-12-09 19:38 ` Saeed Mahameed [this message]
2022-12-09 19:40 ` Vladimir Oltean
2022-12-10 0:07 ` Florian Fainelli
2022-12-09 17:28 ` [PATCH v2 net-next 4/4] net: dsa: mv88e6xxx: replace VTU " Vladimir Oltean
2022-12-09 19:39 ` Saeed Mahameed
2022-12-10 0:07 ` Florian Fainelli
2022-12-12 23:10 ` [PATCH v2 net-next 0/4] Trace points for mv88e6xxx patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Y5OOwWIT/TL800aw@x130 \
--to=saeed@kernel.org \
--cc=andrew@lunn.ch \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=f.fainelli@gmail.com \
--cc=kuba@kernel.org \
--cc=netdev@kapio-technology.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=vladimir.oltean@nxp.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.