From: Jason Gunthorpe <jgg@nvidia.com>
To: Bob Pearson <rpearsonhpe@gmail.com>
Cc: linux-rdma@vger.kernel.org
Subject: Re: [PATCH for-next] RDMA/rxe: Fix incorrect responder length checking
Date: Fri, 9 Dec 2022 19:30:33 -0400 [thread overview]
Message-ID: <Y5PFGUCjCc7hBo/e@nvidia.com> (raw)
In-Reply-To: <20221208210945.28607-1-rpearsonhpe@gmail.com>
On Thu, Dec 08, 2022 at 03:09:46PM -0600, Bob Pearson wrote:
> The code in rxe_resp.c at check_length() is incorrect as it
> compares pkt->opcode an 8 bit value against various mask bits
> which are all higher than 256 so nothing is ever reported.
>
> This patch rewrites this to compare against pkt->mask which is
> correct. However this now exposes another error. For UD send
> packets the value of the pmtu cannot be determined from qp->mtu.
> All that is required here is to later check if the payload fits
> into the posted receive buffer in that case.
>
> Fixes: 837a55847ead ("RDMA/rxe: Implement packet length validation on responder")
> Signed-off-by: Bob Pearson <rpearsonhpe@gmail.com>
> Reviewed-by: Daisuke Matsuda <matsuda-daisuke@fujitsu.com>
> ---
> drivers/infiniband/sw/rxe/rxe_resp.c | 62 ++++++++++++++++------------
> 1 file changed, 36 insertions(+), 26 deletions(-)
Applied to for next, thanks
Jason
prev parent reply other threads:[~2022-12-09 23:30 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-12-08 21:09 [PATCH for-next] RDMA/rxe: Fix incorrect responder length checking Bob Pearson
2022-12-09 6:49 ` Daisuke Matsuda (Fujitsu)
2022-12-09 23:30 ` Jason Gunthorpe [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Y5PFGUCjCc7hBo/e@nvidia.com \
--to=jgg@nvidia.com \
--cc=linux-rdma@vger.kernel.org \
--cc=rpearsonhpe@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.