From: Al Viro <viro@zeniv.linux.org.uk>
To: Chuang Wang <nashuiliang@gmail.com>
Cc: linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] mount: rebuild error handling in do_new_mount
Date: Sat, 10 Dec 2022 23:39:35 +0000 [thread overview]
Message-ID: <Y5UYt538lOFTwr5R@ZenIV> (raw)
In-Reply-To: <20221204150006.753148-1-nashuiliang@gmail.com>
On Sun, Dec 04, 2022 at 11:00:05PM +0800, Chuang Wang wrote:
> When a function execution error is detected in do_new_mount, it should
> return immediately. Using this can make the code easier to understand.
Your piles of goto make it harder to follow and reason about.
NAKed-by: Al Viro <viro@zeniv.linux.org.uk>
prev parent reply other threads:[~2022-12-10 23:39 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-12-04 15:00 [PATCH] mount: rebuild error handling in do_new_mount Chuang Wang
2022-12-10 23:39 ` Al Viro [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Y5UYt538lOFTwr5R@ZenIV \
--to=viro@zeniv.linux.org.uk \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=nashuiliang@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.