From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 14E06C001B2 for ; Sun, 11 Dec 2022 11:29:07 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230085AbiLKL3E (ORCPT ); Sun, 11 Dec 2022 06:29:04 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:58032 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229960AbiLKL3B (ORCPT ); Sun, 11 Dec 2022 06:29:01 -0500 Received: from vps0.lunn.ch (vps0.lunn.ch [156.67.10.101]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 72CFB9598 for ; Sun, 11 Dec 2022 03:28:55 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lunn.ch; s=20171124; h=In-Reply-To:Content-Disposition:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:From:Sender:Reply-To:Subject: Date:Message-ID:To:Cc:MIME-Version:Content-Type:Content-Transfer-Encoding: Content-ID:Content-Description:Content-Disposition:In-Reply-To:References; bh=X2+1onL9PR3dRGzBMY2tcgXIhjI7vkSx6BhzYKN0/OE=; b=D6SXWhUUqFamxEEtKObyoi8ta9 pcXqwiQ+OHoJgSe1ORo7zt0X6CHENSTjOfEQv0IVZ9bjzaTH+Pb1P4FL7hrI+e29PQqBgKDoMVNVJ Txx3x5NXs4R9IowMiTHHSg6L1tht4iR4J0EhO+B0SttKhXgdGMMNHYsV62bVaTbiefPo=; Received: from andrew by vps0.lunn.ch with local (Exim 4.94.2) (envelope-from ) id 1p4KVn-0050ry-Cz; Sun, 11 Dec 2022 12:28:51 +0100 Date: Sun, 11 Dec 2022 12:28:51 +0100 From: Andrew Lunn To: "mengyuanlou@net-swift.com" Cc: netdev@vger.kernel.org, jiawenwu@trustnetic.com Subject: Re: [PATCH net-next v2] net: ngbe: Add ngbe mdio bus driver. Message-ID: References: <20221206114035.66260-1-mengyuanlou@net-swift.com> <8BEEC6D9-EB5F-4A66-8BFD-E8FEE4EB723F@net-swift.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <8BEEC6D9-EB5F-4A66-8BFD-E8FEE4EB723F@net-swift.com> Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org > >> +static void ngbe_up(struct ngbe_adapter *adapter) > >> +{ > >> + struct ngbe_hw *hw = &adapter->hw; > >> + > >> + pci_set_master(adapter->pdev); > >> + if (hw->gpio_ctrl) > >> + /* gpio0 is used to power on control*/ > >> + wr32(&hw->wxhw, NGBE_GPIO_DR, 0); > > > > Control of what? > Control for sfp modules power down/up. > The chip has not i2c interface, so I do not use phylink. Please give this a better name. Is this connected to the TX_DISABLE pin of the SFP, or the transmit and receiver power pins? If you don't have the I2C bus, i'm wondering how you can actually driver the SFP and the MAC. You have no idea what has been inserted. Is it actually an SFF, not an SFP? Do you have any of the GPIOs normally associated with an SFP? TX_DISABLE, LOS, TX_FAULT? Andrew