From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 1DAAA1C16; Sun, 11 Dec 2022 13:31:33 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1670765493; x=1702301493; h=date:from:to:cc:subject:message-id:references: mime-version:content-transfer-encoding:in-reply-to; bh=mzHG/pVGmg236g4ocCottXwf/Vck+AOplcQMPTkzoug=; b=LFRuBEdhdHhddmTY9KdMavYFbOK4EmjwhccQC5PxLgLjjwLXiC62Z4Yv +Y0mXzfPRqIYX+lxZzSMbxKxTY8NbJcaiKTHJPKEXR6YXznIyDUrfnfpr nMqT025Aet/Fy8TAZD7UbhC5nnyeMIJ5iaSB1ZqTccZ5Wy08pc5XtZNGG HZw/gg6VA65Yh2u+PF6lNzx50VkKAgUK0mhba1CuBehktJ/+qgEuC1DQK 7dnUN+T7C1I7UhjBm/yZSfrC3Fncei9s0ZkCMvF/Iw+RMjGAin2B4LFln rxxU9oNBF5rJ0qPkvU6sXSEZ7uvhADQy1wo1B496Qy419Ossn53F3M8fM g==; X-IronPort-AV: E=McAfee;i="6500,9779,10558"; a="318847052" X-IronPort-AV: E=Sophos;i="5.96,236,1665471600"; d="scan'208";a="318847052" Received: from orsmga008.jf.intel.com ([10.7.209.65]) by orsmga102.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 11 Dec 2022 05:31:32 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6500,9779,10558"; a="678628772" X-IronPort-AV: E=Sophos;i="5.96,236,1665471600"; d="scan'208";a="678628772" Received: from smile.fi.intel.com ([10.237.72.54]) by orsmga008.jf.intel.com with ESMTP; 11 Dec 2022 05:31:28 -0800 Received: from andy by smile.fi.intel.com with local (Exim 4.96) (envelope-from ) id 1p4MQQ-0080Nz-0b; Sun, 11 Dec 2022 15:31:26 +0200 Date: Sun, 11 Dec 2022 15:31:25 +0200 From: Andy Shevchenko To: Uwe =?iso-8859-1?Q?Kleine-K=F6nig?= Cc: Thierry Reding , linux-pwm@vger.kernel.org, linux-gpio@vger.kernel.org, dri-devel@lists.freedesktop.org, linux-leds@vger.kernel.org, linux-arm-kernel@lists.infradead.org, chrome-platform@lists.linux.dev, linux-amlogic@lists.infradead.org, linux-mediatek@lists.infradead.org, linux-rpi-kernel@lists.infradead.org, linux-rockchip@lists.infradead.org, linux-riscv@lists.infradead.org, linux-stm32@st-md-mailman.stormreply.com, linux-sunxi@lists.linux.dev Subject: Re: [PATCH v2 00/11] pwm: Allow .get_state to fail Message-ID: References: <20221130152148.2769768-1-u.kleine-koenig@pengutronix.de> <20221210091833.vdfir63nq4kpj5cm@pengutronix.de> <20221210224154.733cd5qnrkpexq22@pengutronix.de> Precedence: bulk X-Mailing-List: chrome-platform@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20221210224154.733cd5qnrkpexq22@pengutronix.de> Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo On Sat, Dec 10, 2022 at 11:41:54PM +0100, Uwe Kleine-König wrote: > On Sat, Dec 10, 2022 at 10:57:16PM +0200, Andy Shevchenko wrote: > > On Sat, Dec 10, 2022 at 10:18:33AM +0100, Uwe Kleine-König wrote: > > > On Fri, Dec 09, 2022 at 11:47:54PM +0200, Andy Shevchenko wrote: > > > > On Wed, Nov 30, 2022 at 04:21:37PM +0100, Uwe Kleine-König wrote: ... > > > > I'm wondering why we didn't see a compiler warning about mistyped function > > > > prototypes in some drivers. > > > > > > I don't understand where you expected a warning. Care to elaborate? > > > > intel-lpss.c has the prototype that returns an int. IIRC it was like this > > Do you mean drivers/mfd/intel-lpss.c? That one doesn't implement a PWM?! Nope, I meant pwm-lpss.c. > And drivers/pwm/pwm-lpss.c is adapted by this series. That's what I didn't see how. > One of us is confused ... Yes, because when I have checked the branch based on Linux Next I already saw that get_state() returns a code and I wasn't aware that the series is already there. -- With Best Regards, Andy Shevchenko From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 1F6CAC4167B for ; Sun, 11 Dec 2022 13:32:27 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=ATGIOXf1ki8C01+y2QPME0z8QFHwgvbhvubf4fAPv20=; b=TUkSC8mxERYP93 zk9IhpfAJeNTMV9io6E9yxo4+jmYr8DdPcoaQvZP4s9umWL/t3LQykTZjSxxDYZIi8DUlnWMbLwch ockxTR0GeGh7DbmczxvXcWifPeZ3UGIG0WopZGZIAaYpv+GMGxCpKJgjjbwGU18sdiqRy9muZIeIh tfxw3xeZjTgGqcpYXXnBkbEMpb7l4lhxYJGHgCODNIOUxH8ia+9mMDqldAEsE6MhGVkFT7rtArzap Tx2rw/cBhuDcxmvidZM7PvZkvXHODDt22kgoR74HH6UDlfHmNRcc9u7IW94pWqv8PhJF4ulPgERGg Fpl2NS1/l2+LqMwgVlxA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1p4MQq-000ljw-2y; Sun, 11 Dec 2022 13:31:53 +0000 Received: from mga09.intel.com ([134.134.136.24]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1p4MQZ-000lWC-U2; Sun, 11 Dec 2022 13:31:38 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1670765495; x=1702301495; h=date:from:to:cc:subject:message-id:references: mime-version:content-transfer-encoding:in-reply-to; bh=mzHG/pVGmg236g4ocCottXwf/Vck+AOplcQMPTkzoug=; b=MNc7YmhZ6X9At/PueJnc3JuWtS43xq9KTKOfp1I/qJANVCPXFxux4iSc DaPOfD9Rd+c//t8M5gQPDJsx/0QXvLuCCVAagsPg+CkaFvWQU49kD1zim lJQ7Y5brrDN2vNWQyAV7nEBURwfxmXatCQBYoQs/UTUs76k8d0x/oujsf KY26WZV12DUB7zzC1kMVbYrvlLVn1nwaplo7DbVq+u9Ay0hbnB7Dk65qH uZfFAkQiJBf0zGd4CCOWIoqUczDBKacWjkmVzXAg1KD19cxDr/ykkeF43 Y9K0VrFmpoyja/z0yXWYMWdZJPka4V8LxkSXwYJgz6kdZ5BQYBX6er48j w==; X-IronPort-AV: E=McAfee;i="6500,9779,10558"; a="318847053" X-IronPort-AV: E=Sophos;i="5.96,236,1665471600"; d="scan'208";a="318847053" Received: from orsmga008.jf.intel.com ([10.7.209.65]) by orsmga102.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 11 Dec 2022 05:31:32 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6500,9779,10558"; a="678628772" X-IronPort-AV: E=Sophos;i="5.96,236,1665471600"; d="scan'208";a="678628772" Received: from smile.fi.intel.com ([10.237.72.54]) by orsmga008.jf.intel.com with ESMTP; 11 Dec 2022 05:31:28 -0800 Received: from andy by smile.fi.intel.com with local (Exim 4.96) (envelope-from ) id 1p4MQQ-0080Nz-0b; Sun, 11 Dec 2022 15:31:26 +0200 Date: Sun, 11 Dec 2022 15:31:25 +0200 From: Andy Shevchenko To: Uwe =?iso-8859-1?Q?Kleine-K=F6nig?= Cc: Thierry Reding , linux-pwm@vger.kernel.org, linux-gpio@vger.kernel.org, dri-devel@lists.freedesktop.org, linux-leds@vger.kernel.org, linux-arm-kernel@lists.infradead.org, chrome-platform@lists.linux.dev, linux-amlogic@lists.infradead.org, linux-mediatek@lists.infradead.org, linux-rpi-kernel@lists.infradead.org, linux-rockchip@lists.infradead.org, linux-riscv@lists.infradead.org, linux-stm32@st-md-mailman.stormreply.com, linux-sunxi@lists.linux.dev Subject: Re: [PATCH v2 00/11] pwm: Allow .get_state to fail Message-ID: References: <20221130152148.2769768-1-u.kleine-koenig@pengutronix.de> <20221210091833.vdfir63nq4kpj5cm@pengutronix.de> <20221210224154.733cd5qnrkpexq22@pengutronix.de> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20221210224154.733cd5qnrkpexq22@pengutronix.de> Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20221211_053137_217025_A1EA3463 X-CRM114-Status: GOOD ( 17.24 ) X-BeenThere: linux-amlogic@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Sender: "linux-amlogic" Errors-To: linux-amlogic-bounces+linux-amlogic=archiver.kernel.org@lists.infradead.org On Sat, Dec 10, 2022 at 11:41:54PM +0100, Uwe Kleine-K=F6nig wrote: > On Sat, Dec 10, 2022 at 10:57:16PM +0200, Andy Shevchenko wrote: > > On Sat, Dec 10, 2022 at 10:18:33AM +0100, Uwe Kleine-K=F6nig wrote: > > > On Fri, Dec 09, 2022 at 11:47:54PM +0200, Andy Shevchenko wrote: > > > > On Wed, Nov 30, 2022 at 04:21:37PM +0100, Uwe Kleine-K=F6nig wrote: ... > > > > I'm wondering why we didn't see a compiler warning about mistyped f= unction > > > > prototypes in some drivers. > > > = > > > I don't understand where you expected a warning. Care to elaborate? > > = > > intel-lpss.c has the prototype that returns an int. IIRC it was like th= is > = > Do you mean drivers/mfd/intel-lpss.c? That one doesn't implement a PWM?! Nope, I meant pwm-lpss.c. > And drivers/pwm/pwm-lpss.c is adapted by this series. That's what I didn't see how. > One of us is confused ... Yes, because when I have checked the branch based on Linux Next I already s= aw that get_state() returns a code and I wasn't aware that the series is alrea= dy there. -- = With Best Regards, Andy Shevchenko _______________________________________________ linux-amlogic mailing list linux-amlogic@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-amlogic From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 4B959C4332F for ; Sun, 11 Dec 2022 13:32:31 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=Tp7nNmIiFm511gHzDSmgOZgq2XxSiLVavLO8QclPqJg=; b=ncr628hdmdLCmE bcrzw5xrTtfuxhAF0FyV1YSLypK8kGQbfQgUZU3fIV+b/xpBuD/oguQLI1JkvQ3LbvcBgZPHCtK+5 Ytsvn+WwU6Zp88dcpNnjXZXRzmVbYWVAl00SXpiKGcwwwuG8Gjt7qaV22My+AWyxPFyBU0ub1b5FY nBJUndT6bcg0QjwUJbzw21KwPMiJM2/19yfkNfRDhfSZrO6HzPdxe7i9g5nIstcBtkf3Dr2rAOLUR l1U3eGtefF99geA9oWb1QoPhW+hmBrAkjJyfeadtGw+Zw7YaHS7N23+7/3Bk/vqYGWI6xxgfHQCu+ f0rW2C2k0RLw/3kegaFw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1p4MQv-000lpD-7c; Sun, 11 Dec 2022 13:31:57 +0000 Received: from mga09.intel.com ([134.134.136.24]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1p4MQZ-000lWC-U2; Sun, 11 Dec 2022 13:31:38 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1670765495; x=1702301495; h=date:from:to:cc:subject:message-id:references: mime-version:content-transfer-encoding:in-reply-to; bh=mzHG/pVGmg236g4ocCottXwf/Vck+AOplcQMPTkzoug=; b=MNc7YmhZ6X9At/PueJnc3JuWtS43xq9KTKOfp1I/qJANVCPXFxux4iSc DaPOfD9Rd+c//t8M5gQPDJsx/0QXvLuCCVAagsPg+CkaFvWQU49kD1zim lJQ7Y5brrDN2vNWQyAV7nEBURwfxmXatCQBYoQs/UTUs76k8d0x/oujsf KY26WZV12DUB7zzC1kMVbYrvlLVn1nwaplo7DbVq+u9Ay0hbnB7Dk65qH uZfFAkQiJBf0zGd4CCOWIoqUczDBKacWjkmVzXAg1KD19cxDr/ykkeF43 Y9K0VrFmpoyja/z0yXWYMWdZJPka4V8LxkSXwYJgz6kdZ5BQYBX6er48j w==; X-IronPort-AV: E=McAfee;i="6500,9779,10558"; a="318847053" X-IronPort-AV: E=Sophos;i="5.96,236,1665471600"; d="scan'208";a="318847053" Received: from orsmga008.jf.intel.com ([10.7.209.65]) by orsmga102.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 11 Dec 2022 05:31:32 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6500,9779,10558"; a="678628772" X-IronPort-AV: E=Sophos;i="5.96,236,1665471600"; d="scan'208";a="678628772" Received: from smile.fi.intel.com ([10.237.72.54]) by orsmga008.jf.intel.com with ESMTP; 11 Dec 2022 05:31:28 -0800 Received: from andy by smile.fi.intel.com with local (Exim 4.96) (envelope-from ) id 1p4MQQ-0080Nz-0b; Sun, 11 Dec 2022 15:31:26 +0200 Date: Sun, 11 Dec 2022 15:31:25 +0200 From: Andy Shevchenko To: Uwe =?iso-8859-1?Q?Kleine-K=F6nig?= Cc: Thierry Reding , linux-pwm@vger.kernel.org, linux-gpio@vger.kernel.org, dri-devel@lists.freedesktop.org, linux-leds@vger.kernel.org, linux-arm-kernel@lists.infradead.org, chrome-platform@lists.linux.dev, linux-amlogic@lists.infradead.org, linux-mediatek@lists.infradead.org, linux-rpi-kernel@lists.infradead.org, linux-rockchip@lists.infradead.org, linux-riscv@lists.infradead.org, linux-stm32@st-md-mailman.stormreply.com, linux-sunxi@lists.linux.dev Subject: Re: [PATCH v2 00/11] pwm: Allow .get_state to fail Message-ID: References: <20221130152148.2769768-1-u.kleine-koenig@pengutronix.de> <20221210091833.vdfir63nq4kpj5cm@pengutronix.de> <20221210224154.733cd5qnrkpexq22@pengutronix.de> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20221210224154.733cd5qnrkpexq22@pengutronix.de> Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20221211_053137_217025_A1EA3463 X-CRM114-Status: GOOD ( 17.24 ) X-BeenThere: linux-rockchip@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Upstream kernel work for Rockchip platforms List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Sender: "Linux-rockchip" Errors-To: linux-rockchip-bounces+linux-rockchip=archiver.kernel.org@lists.infradead.org On Sat, Dec 10, 2022 at 11:41:54PM +0100, Uwe Kleine-K=F6nig wrote: > On Sat, Dec 10, 2022 at 10:57:16PM +0200, Andy Shevchenko wrote: > > On Sat, Dec 10, 2022 at 10:18:33AM +0100, Uwe Kleine-K=F6nig wrote: > > > On Fri, Dec 09, 2022 at 11:47:54PM +0200, Andy Shevchenko wrote: > > > > On Wed, Nov 30, 2022 at 04:21:37PM +0100, Uwe Kleine-K=F6nig wrote: ... > > > > I'm wondering why we didn't see a compiler warning about mistyped f= unction > > > > prototypes in some drivers. > > > = > > > I don't understand where you expected a warning. Care to elaborate? > > = > > intel-lpss.c has the prototype that returns an int. IIRC it was like th= is > = > Do you mean drivers/mfd/intel-lpss.c? That one doesn't implement a PWM?! Nope, I meant pwm-lpss.c. > And drivers/pwm/pwm-lpss.c is adapted by this series. That's what I didn't see how. > One of us is confused ... Yes, because when I have checked the branch based on Linux Next I already s= aw that get_state() returns a code and I wasn't aware that the series is alrea= dy there. -- = With Best Regards, Andy Shevchenko _______________________________________________ Linux-rockchip mailing list Linux-rockchip@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-rockchip From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id E8E5EC4332F for ; Sun, 11 Dec 2022 13:32:26 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=GjlCjNOHT+gWAhgm0Q8MLNvYt35laldhcQ+C8peKn+0=; b=m+GwFRf5TsJTWJ LXFZnbM34mgZqDmnKgGDjv+sIeoLuyGwjCkUkh06cl/pOGHFUEKZpZEuEpORhInDaoU8e4KwHMyLx zkah/+NDekWAaHfrpxQVlIAMXTTFymBvMGaDE+2LrpFOOMA/95298oFaYL6XIlREljm6Qc87CW2ZS YmYX3rFxEJGCWtQsAE3BFerzy0iTrL3LY+9McNxwmQTV0LlrODTMBXUiusTX0Ne/LudwjnKuM71a3 2uzGiMH50N2xu02lCyTor7UeE01u3gyj3dRxF7Pa+0ccB2TYmDF8y0e7vHmzPcaRDRnjNzZJx5gaw 74kGNked11jYVVim8bNg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1p4MQy-000lr9-54; Sun, 11 Dec 2022 13:32:00 +0000 Received: from mga09.intel.com ([134.134.136.24]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1p4MQZ-000lWC-U2; Sun, 11 Dec 2022 13:31:38 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1670765495; x=1702301495; h=date:from:to:cc:subject:message-id:references: mime-version:content-transfer-encoding:in-reply-to; bh=mzHG/pVGmg236g4ocCottXwf/Vck+AOplcQMPTkzoug=; b=MNc7YmhZ6X9At/PueJnc3JuWtS43xq9KTKOfp1I/qJANVCPXFxux4iSc DaPOfD9Rd+c//t8M5gQPDJsx/0QXvLuCCVAagsPg+CkaFvWQU49kD1zim lJQ7Y5brrDN2vNWQyAV7nEBURwfxmXatCQBYoQs/UTUs76k8d0x/oujsf KY26WZV12DUB7zzC1kMVbYrvlLVn1nwaplo7DbVq+u9Ay0hbnB7Dk65qH uZfFAkQiJBf0zGd4CCOWIoqUczDBKacWjkmVzXAg1KD19cxDr/ykkeF43 Y9K0VrFmpoyja/z0yXWYMWdZJPka4V8LxkSXwYJgz6kdZ5BQYBX6er48j w==; X-IronPort-AV: E=McAfee;i="6500,9779,10558"; a="318847053" X-IronPort-AV: E=Sophos;i="5.96,236,1665471600"; d="scan'208";a="318847053" Received: from orsmga008.jf.intel.com ([10.7.209.65]) by orsmga102.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 11 Dec 2022 05:31:32 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6500,9779,10558"; a="678628772" X-IronPort-AV: E=Sophos;i="5.96,236,1665471600"; d="scan'208";a="678628772" Received: from smile.fi.intel.com ([10.237.72.54]) by orsmga008.jf.intel.com with ESMTP; 11 Dec 2022 05:31:28 -0800 Received: from andy by smile.fi.intel.com with local (Exim 4.96) (envelope-from ) id 1p4MQQ-0080Nz-0b; Sun, 11 Dec 2022 15:31:26 +0200 Date: Sun, 11 Dec 2022 15:31:25 +0200 From: Andy Shevchenko To: Uwe =?iso-8859-1?Q?Kleine-K=F6nig?= Cc: Thierry Reding , linux-pwm@vger.kernel.org, linux-gpio@vger.kernel.org, dri-devel@lists.freedesktop.org, linux-leds@vger.kernel.org, linux-arm-kernel@lists.infradead.org, chrome-platform@lists.linux.dev, linux-amlogic@lists.infradead.org, linux-mediatek@lists.infradead.org, linux-rpi-kernel@lists.infradead.org, linux-rockchip@lists.infradead.org, linux-riscv@lists.infradead.org, linux-stm32@st-md-mailman.stormreply.com, linux-sunxi@lists.linux.dev Subject: Re: [PATCH v2 00/11] pwm: Allow .get_state to fail Message-ID: References: <20221130152148.2769768-1-u.kleine-koenig@pengutronix.de> <20221210091833.vdfir63nq4kpj5cm@pengutronix.de> <20221210224154.733cd5qnrkpexq22@pengutronix.de> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20221210224154.733cd5qnrkpexq22@pengutronix.de> Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20221211_053137_217025_A1EA3463 X-CRM114-Status: GOOD ( 17.24 ) X-BeenThere: linux-riscv@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Sender: "linux-riscv" Errors-To: linux-riscv-bounces+linux-riscv=archiver.kernel.org@lists.infradead.org On Sat, Dec 10, 2022 at 11:41:54PM +0100, Uwe Kleine-K=F6nig wrote: > On Sat, Dec 10, 2022 at 10:57:16PM +0200, Andy Shevchenko wrote: > > On Sat, Dec 10, 2022 at 10:18:33AM +0100, Uwe Kleine-K=F6nig wrote: > > > On Fri, Dec 09, 2022 at 11:47:54PM +0200, Andy Shevchenko wrote: > > > > On Wed, Nov 30, 2022 at 04:21:37PM +0100, Uwe Kleine-K=F6nig wrote: ... > > > > I'm wondering why we didn't see a compiler warning about mistyped f= unction > > > > prototypes in some drivers. > > > = > > > I don't understand where you expected a warning. Care to elaborate? > > = > > intel-lpss.c has the prototype that returns an int. IIRC it was like th= is > = > Do you mean drivers/mfd/intel-lpss.c? That one doesn't implement a PWM?! Nope, I meant pwm-lpss.c. > And drivers/pwm/pwm-lpss.c is adapted by this series. That's what I didn't see how. > One of us is confused ... Yes, because when I have checked the branch based on Linux Next I already s= aw that get_state() returns a code and I wasn't aware that the series is alrea= dy there. -- = With Best Regards, Andy Shevchenko _______________________________________________ linux-riscv mailing list linux-riscv@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-riscv From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 60591C001B2 for ; Sun, 11 Dec 2022 13:33:29 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=LBu6L9NMMWuu/j8f0obuwAH/3J7aSRQmfCTnGASEXHM=; b=wTvmvI/gJ+f0Q/ O+VfyCxIr9gZ9TllkZpdJirLO3Rb8dJsmhdHMFs4ce3OPNo0fV+85s4TFEsUMKZMGjfdhWofQDjBY zV2wYVyTGfzZimKxTfJ81yYVFsWAt9B/+DRu0WJ3XhZW5kQk0AdHB90yrjuSxFenTsBRm/b4XZCQb AJ4UqPurQ+bJyO0msYLL21kYNP2ZNng1diFp2eNtgSxb3bdmu5HE+NkOa22tcIaSEql1J3AiLS0tT MFXCIaH24JyHQR6czZhs5rkAI4DQQ6unAWgxx1Dd1jWX2JA5a2WZ7/aZ3YxA5DyWhvCrHUnigug5+ FReQvk5Vk+9vSqDbE2Gw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1p4MQe-000ld9-SM; Sun, 11 Dec 2022 13:31:41 +0000 Received: from mga09.intel.com ([134.134.136.24]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1p4MQZ-000lWC-U2; Sun, 11 Dec 2022 13:31:38 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1670765495; x=1702301495; h=date:from:to:cc:subject:message-id:references: mime-version:content-transfer-encoding:in-reply-to; bh=mzHG/pVGmg236g4ocCottXwf/Vck+AOplcQMPTkzoug=; b=MNc7YmhZ6X9At/PueJnc3JuWtS43xq9KTKOfp1I/qJANVCPXFxux4iSc DaPOfD9Rd+c//t8M5gQPDJsx/0QXvLuCCVAagsPg+CkaFvWQU49kD1zim lJQ7Y5brrDN2vNWQyAV7nEBURwfxmXatCQBYoQs/UTUs76k8d0x/oujsf KY26WZV12DUB7zzC1kMVbYrvlLVn1nwaplo7DbVq+u9Ay0hbnB7Dk65qH uZfFAkQiJBf0zGd4CCOWIoqUczDBKacWjkmVzXAg1KD19cxDr/ykkeF43 Y9K0VrFmpoyja/z0yXWYMWdZJPka4V8LxkSXwYJgz6kdZ5BQYBX6er48j w==; X-IronPort-AV: E=McAfee;i="6500,9779,10558"; a="318847053" X-IronPort-AV: E=Sophos;i="5.96,236,1665471600"; d="scan'208";a="318847053" Received: from orsmga008.jf.intel.com ([10.7.209.65]) by orsmga102.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 11 Dec 2022 05:31:32 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6500,9779,10558"; a="678628772" X-IronPort-AV: E=Sophos;i="5.96,236,1665471600"; d="scan'208";a="678628772" Received: from smile.fi.intel.com ([10.237.72.54]) by orsmga008.jf.intel.com with ESMTP; 11 Dec 2022 05:31:28 -0800 Received: from andy by smile.fi.intel.com with local (Exim 4.96) (envelope-from ) id 1p4MQQ-0080Nz-0b; Sun, 11 Dec 2022 15:31:26 +0200 Date: Sun, 11 Dec 2022 15:31:25 +0200 From: Andy Shevchenko To: Uwe =?iso-8859-1?Q?Kleine-K=F6nig?= Cc: Thierry Reding , linux-pwm@vger.kernel.org, linux-gpio@vger.kernel.org, dri-devel@lists.freedesktop.org, linux-leds@vger.kernel.org, linux-arm-kernel@lists.infradead.org, chrome-platform@lists.linux.dev, linux-amlogic@lists.infradead.org, linux-mediatek@lists.infradead.org, linux-rpi-kernel@lists.infradead.org, linux-rockchip@lists.infradead.org, linux-riscv@lists.infradead.org, linux-stm32@st-md-mailman.stormreply.com, linux-sunxi@lists.linux.dev Subject: Re: [PATCH v2 00/11] pwm: Allow .get_state to fail Message-ID: References: <20221130152148.2769768-1-u.kleine-koenig@pengutronix.de> <20221210091833.vdfir63nq4kpj5cm@pengutronix.de> <20221210224154.733cd5qnrkpexq22@pengutronix.de> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20221210224154.733cd5qnrkpexq22@pengutronix.de> Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20221211_053137_217025_A1EA3463 X-CRM114-Status: GOOD ( 17.24 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Sat, Dec 10, 2022 at 11:41:54PM +0100, Uwe Kleine-K=F6nig wrote: > On Sat, Dec 10, 2022 at 10:57:16PM +0200, Andy Shevchenko wrote: > > On Sat, Dec 10, 2022 at 10:18:33AM +0100, Uwe Kleine-K=F6nig wrote: > > > On Fri, Dec 09, 2022 at 11:47:54PM +0200, Andy Shevchenko wrote: > > > > On Wed, Nov 30, 2022 at 04:21:37PM +0100, Uwe Kleine-K=F6nig wrote: ... > > > > I'm wondering why we didn't see a compiler warning about mistyped f= unction > > > > prototypes in some drivers. > > > = > > > I don't understand where you expected a warning. Care to elaborate? > > = > > intel-lpss.c has the prototype that returns an int. IIRC it was like th= is > = > Do you mean drivers/mfd/intel-lpss.c? That one doesn't implement a PWM?! Nope, I meant pwm-lpss.c. > And drivers/pwm/pwm-lpss.c is adapted by this series. That's what I didn't see how. > One of us is confused ... Yes, because when I have checked the branch based on Linux Next I already s= aw that get_state() returns a code and I wasn't aware that the series is alrea= dy there. -- = With Best Regards, Andy Shevchenko _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 13F64C4332F for ; Sun, 11 Dec 2022 13:31:44 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 1B85E10E129; Sun, 11 Dec 2022 13:31:38 +0000 (UTC) Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) by gabe.freedesktop.org (Postfix) with ESMTPS id 3638410E129 for ; Sun, 11 Dec 2022 13:31:33 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1670765493; x=1702301493; h=date:from:to:cc:subject:message-id:references: mime-version:content-transfer-encoding:in-reply-to; bh=mzHG/pVGmg236g4ocCottXwf/Vck+AOplcQMPTkzoug=; b=LFRuBEdhdHhddmTY9KdMavYFbOK4EmjwhccQC5PxLgLjjwLXiC62Z4Yv +Y0mXzfPRqIYX+lxZzSMbxKxTY8NbJcaiKTHJPKEXR6YXznIyDUrfnfpr nMqT025Aet/Fy8TAZD7UbhC5nnyeMIJ5iaSB1ZqTccZ5Wy08pc5XtZNGG HZw/gg6VA65Yh2u+PF6lNzx50VkKAgUK0mhba1CuBehktJ/+qgEuC1DQK 7dnUN+T7C1I7UhjBm/yZSfrC3Fncei9s0ZkCMvF/Iw+RMjGAin2B4LFln rxxU9oNBF5rJ0qPkvU6sXSEZ7uvhADQy1wo1B496Qy419Ossn53F3M8fM g==; X-IronPort-AV: E=McAfee;i="6500,9779,10558"; a="318847054" X-IronPort-AV: E=Sophos;i="5.96,236,1665471600"; d="scan'208";a="318847054" Received: from orsmga008.jf.intel.com ([10.7.209.65]) by orsmga102.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 11 Dec 2022 05:31:32 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6500,9779,10558"; a="678628772" X-IronPort-AV: E=Sophos;i="5.96,236,1665471600"; d="scan'208";a="678628772" Received: from smile.fi.intel.com ([10.237.72.54]) by orsmga008.jf.intel.com with ESMTP; 11 Dec 2022 05:31:28 -0800 Received: from andy by smile.fi.intel.com with local (Exim 4.96) (envelope-from ) id 1p4MQQ-0080Nz-0b; Sun, 11 Dec 2022 15:31:26 +0200 Date: Sun, 11 Dec 2022 15:31:25 +0200 From: Andy Shevchenko To: Uwe =?iso-8859-1?Q?Kleine-K=F6nig?= Subject: Re: [PATCH v2 00/11] pwm: Allow .get_state to fail Message-ID: References: <20221130152148.2769768-1-u.kleine-koenig@pengutronix.de> <20221210091833.vdfir63nq4kpj5cm@pengutronix.de> <20221210224154.733cd5qnrkpexq22@pengutronix.de> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20221210224154.733cd5qnrkpexq22@pengutronix.de> Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: linux-pwm@vger.kernel.org, chrome-platform@lists.linux.dev, linux-rockchip@lists.infradead.org, dri-devel@lists.freedesktop.org, linux-sunxi@lists.linux.dev, linux-gpio@vger.kernel.org, Thierry Reding , linux-mediatek@lists.infradead.org, linux-leds@vger.kernel.org, linux-amlogic@lists.infradead.org, linux-riscv@lists.infradead.org, linux-stm32@st-md-mailman.stormreply.com, linux-arm-kernel@lists.infradead.org, linux-rpi-kernel@lists.infradead.org Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" On Sat, Dec 10, 2022 at 11:41:54PM +0100, Uwe Kleine-König wrote: > On Sat, Dec 10, 2022 at 10:57:16PM +0200, Andy Shevchenko wrote: > > On Sat, Dec 10, 2022 at 10:18:33AM +0100, Uwe Kleine-König wrote: > > > On Fri, Dec 09, 2022 at 11:47:54PM +0200, Andy Shevchenko wrote: > > > > On Wed, Nov 30, 2022 at 04:21:37PM +0100, Uwe Kleine-König wrote: ... > > > > I'm wondering why we didn't see a compiler warning about mistyped function > > > > prototypes in some drivers. > > > > > > I don't understand where you expected a warning. Care to elaborate? > > > > intel-lpss.c has the prototype that returns an int. IIRC it was like this > > Do you mean drivers/mfd/intel-lpss.c? That one doesn't implement a PWM?! Nope, I meant pwm-lpss.c. > And drivers/pwm/pwm-lpss.c is adapted by this series. That's what I didn't see how. > One of us is confused ... Yes, because when I have checked the branch based on Linux Next I already saw that get_state() returns a code and I wasn't aware that the series is already there. -- With Best Regards, Andy Shevchenko