From: Al Viro <viro@zeniv.linux.org.uk>
To: "Fabio M. De Francesco" <fmdefrancesco@gmail.com>
Cc: Evgeniy Dushistov <dushistov@mail.ru>,
Ira Weiny <ira.weiny@intel.com>,
linux-kernel@vger.kernel.org, bpf@vger.kernel.org,
linux-fsdevel@vger.kernel.org
Subject: Re: [PATCH 2/3] fs/ufs: Change the signature of ufs_get_page()
Date: Sun, 11 Dec 2022 22:42:26 +0000 [thread overview]
Message-ID: <Y5Zc0qZ3+zsI74OZ@ZenIV> (raw)
In-Reply-To: <20221211213111.30085-3-fmdefrancesco@gmail.com>
On Sun, Dec 11, 2022 at 10:31:10PM +0100, Fabio M. De Francesco wrote:
> out_put:
> ufs_put_page(page);
> -out:
> - return err;
> out_unlock:
> unlock_page(page);
> goto out_put;
Something strange has happened, all right - look at the situation
after that patch. You've got
out_put:
ufs_put_page(page);
out_unlock:
unlock_page(page);
goto out_put;
Which is obviously bogus.
next prev parent reply other threads:[~2022-12-11 22:42 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-12-11 21:31 [PATCH 0/3] fs/ufs: replace kmap() with kmap_local_page() Fabio M. De Francesco
2022-12-11 21:31 ` [PATCH 1/3] fs/ufs: Use the offset_in_page() helper Fabio M. De Francesco
2022-12-11 21:31 ` [PATCH 2/3] fs/ufs: Change the signature of ufs_get_page() Fabio M. De Francesco
2022-12-11 22:29 ` Al Viro
2022-12-11 23:56 ` Fabio M. De Francesco
2022-12-11 22:42 ` Al Viro [this message]
2022-12-12 20:08 ` Fabio M. De Francesco
2022-12-11 21:31 ` [PATCH 3/3] fs/ufs: Replace kmap() with kmap_local_page() Fabio M. De Francesco
2022-12-11 22:39 ` Al Viro
2022-12-12 0:14 ` Fabio M. De Francesco
2022-12-12 0:52 ` kernel test robot
2022-12-12 1:07 ` Al Viro
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Y5Zc0qZ3+zsI74OZ@ZenIV \
--to=viro@zeniv.linux.org.uk \
--cc=bpf@vger.kernel.org \
--cc=dushistov@mail.ru \
--cc=fmdefrancesco@gmail.com \
--cc=ira.weiny@intel.com \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.