From: "Russell King (Oracle)" <linux@armlinux.org.uk>
To: Daniel Golle <daniel@makrotopia.org>, netdev@vger.kernel.org
Subject: Redundant changes in "net: dsa: mt7530: add support for in-band link status"
Date: Mon, 12 Dec 2022 10:15:42 +0000 [thread overview]
Message-ID: <Y5b/Tm4GwPGzd9sR@shell.armlinux.org.uk> (raw)
Hi Daniel,
While updating my tree, I notice that the above referenced commit
contains a redundant change, namely in mt753x_phylink_get_caps():
config->mac_capabilities = MAC_ASYM_PAUSE | MAC_SYM_PAUSE |
MAC_10 | MAC_100 | MAC_1000FD;
+ if ((priv->id == ID_MT7531) && mt753x_is_mac_port(port))
+ config->mac_capabilities |= MAC_2500FD;
+
This shouldn't be necessary. mt753x_phylink_get_caps() goes on to
call the obviously named mt753x "mac_port_get_caps" method, which
for a MT7531 is mt7531_mac_port_get_caps().
mt7531_mac_port_get_caps() will already set MAC_2500FD for ports
5 and 6 where appropriate.
Please submit a patch to remove the above change if you agree that
it is already covered.
Thanks.
--
RMK's Patch system: https://www.armlinux.org.uk/developer/patches/
FTTP is here! 40Mbps down 10Mbps up. Decent connectivity at last!
next reply other threads:[~2022-12-12 10:15 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-12-12 10:15 Russell King (Oracle) [this message]
2022-12-13 4:07 ` [PATCH net-next] net: dsa: mt7530: remove reduntant assignment Daniel Golle
2022-12-13 4:07 ` Daniel Golle
2022-12-13 11:30 ` Russell King (Oracle)
2022-12-13 11:30 ` Russell King (Oracle)
2022-12-14 1:17 ` Jakub Kicinski
2022-12-14 1:17 ` Jakub Kicinski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Y5b/Tm4GwPGzd9sR@shell.armlinux.org.uk \
--to=linux@armlinux.org.uk \
--cc=daniel@makrotopia.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.