Re: [LTP] [PATCH v2] syscalls/brk: add direct syscall tst_variant

[Petr Vorel <pvorel@suse.cz>]

Hi Richie,

> Cyril, Petr, Would you like to add your reviewed by tags? Then we can
> merge this.

By accident I reply to my points to v1 [1].
To copy it here:

1) There are warnings:
brk02.c: In function ‘brk_variants’:
brk02.c:26:28: warning: cast to pointer from integer of different size
[-Wint-to-pointer-cast]
   26 |                 brk_addr = (void *)brk(addr);
         |                            ^

2) make check reports errors which are easily fixed.

Teo replied [2], that he's going to fix it. I thought I had set it
"Changes requested", but now I see "Needs Review / ACK". Setting it to
"Changes requested".

Kind regards,
Petr

[1] https://lore.kernel.org/ltp/20221206140421.GB21839@pevik/
[2] https://lore.kernel.org/ltp/fe1c5bac-0ed1-92ef-3c28-e3758dc3465d@arm.com/

-- 
Mailing list info: https://lists.linux.it/listinfo/ltp