From mboxrd@z Thu Jan 1 00:00:00 1970 From: Sean Christopherson Date: Mon, 12 Dec 2022 23:26:35 +0000 Subject: [RFC PATCH 00/37] KVM: Refactor the KVM/x86 TDP MMU into common code In-Reply-To: References: <20221208193857.4090582-1-dmatlack@google.com> Message-ID: List-Id: To: kvm-riscv@lists.infradead.org MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit On Mon, Dec 12, 2022, Paolo Bonzini wrote: > On 12/9/22 20:07, Oliver Upton wrote: > > > - Naming. This series does not change the names of any existing code. > > > So all the KVM/x86 Shadow MMU-style terminology like > > > "shadow_page"/"sp"/"spte" persists. Should we keep that style in > > > common code or move toward something less shadow-paging-specific? > > > e.g. "page_table"/"pt"/"pte". > > > > I would strongly be in favor of discarding the shadow paging residue if > > x86 folks are willing to part ways with it ? > > Yes, absolutely. Something like to_shadow_page->to_mmu_data, sp->md, > spt->hpt, spte->spte, sptep->hptep. "host" will be confusing if when the primary MMU is involved though, e.g. I always think of the primary MMU's page tables as the "host page tables". What if we keep the "S" for SPT(E) and repurpose it to mean Secondary PTE? From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mm01.cs.columbia.edu (mm01.cs.columbia.edu [128.59.11.253]) by smtp.lore.kernel.org (Postfix) with ESMTP id EDC21C4167B for ; Mon, 12 Dec 2022 23:26:43 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by mm01.cs.columbia.edu (Postfix) with ESMTP id 728CA4B856; Mon, 12 Dec 2022 18:26:43 -0500 (EST) X-Virus-Scanned: at lists.cs.columbia.edu Authentication-Results: mm01.cs.columbia.edu (amavisd-new); dkim=softfail (fail, message has been altered) header.i=@google.com Received: from mm01.cs.columbia.edu ([127.0.0.1]) by localhost (mm01.cs.columbia.edu [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 3U-JZGNphPwk; Mon, 12 Dec 2022 18:26:42 -0500 (EST) Received: from mm01.cs.columbia.edu (localhost [127.0.0.1]) by mm01.cs.columbia.edu (Postfix) with ESMTP id 3BB1F4B89E; Mon, 12 Dec 2022 18:26:42 -0500 (EST) Received: from localhost (localhost [127.0.0.1]) by mm01.cs.columbia.edu (Postfix) with ESMTP id 3EFB84B887 for ; Mon, 12 Dec 2022 18:26:41 -0500 (EST) X-Virus-Scanned: at lists.cs.columbia.edu Received: from mm01.cs.columbia.edu ([127.0.0.1]) by localhost (mm01.cs.columbia.edu [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id MFhNGRgsWQ0P for ; Mon, 12 Dec 2022 18:26:40 -0500 (EST) Received: from mail-pl1-f170.google.com (mail-pl1-f170.google.com [209.85.214.170]) by mm01.cs.columbia.edu (Postfix) with ESMTPS id 1E0424B856 for ; Mon, 12 Dec 2022 18:26:40 -0500 (EST) Received: by mail-pl1-f170.google.com with SMTP id jn7so13703662plb.13 for ; Mon, 12 Dec 2022 15:26:39 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20210112; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date:from:to :cc:subject:date:message-id:reply-to; bh=zJOQecEGgSp0glbzJ1RpRnPbkp2HAzeJE/NybulD13E=; b=LgVzXCUoiKNG9USGHdtxDWk3jXHPhUfF7aC6Jb6oAf8XA1bTwz+AQ/vH//iOu+Txbq HtNSM7bobeYY6HNyDm3070/s1Oas0aeVxdQOxg9nHQgvvOSD+HbQky0G3NWU2aHHH9iG JVh1AUDnlaepYuer6Ncinshp4+sTBfERSvbRGIUdHuN0fvrTLKzxKu4eop/o7jhMUBSa 9I1Z1oUAs6TpwbdTo0ilfAV5dpWM/KOAPcjBCaf+Wh+PzYd+4+Je5We3hpfEFSHW2X9B XNOJfuewe5Qh+b7VEFMhtgGppnAqVlzsDeqFiGrPyEqs9m8tEG3SEwVL1QUihijPEdBo 3YcQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=zJOQecEGgSp0glbzJ1RpRnPbkp2HAzeJE/NybulD13E=; b=bzflTROa4EmcuqpQGIORIpKLD31HZht2NiKHAhdZ4ZAfgJ7buyefLsLSxjQ5RyY9Eq eaGAW+rHldLHxJQR8L6WfHPZBdSA4kTC2AZRoonLx2AhrI82x1n6CvVQl3nK/kU6V3kT SzUZ9HBpZeK43J3nk0DnnirluFkg4LwZHO2yBNZJHefyr3kCZuUv2vCfVbhVRk2qxbYg d9R6KUmNwzoA9VHAimah/sBgAnCeYvlpy3VAAbybhTpY2P5pLV9KNW3PNDwB8I5Md3YR oBul8fCSfzEg3NPga8CZqD4W3y255Q0W4/ewDxzdpdOsotSzXxSaPtgtTdggsp8kWoTv 4/XQ== X-Gm-Message-State: ANoB5pnop/GsDAp6VcOJ2gGa8plVhXL/SP1JR159ADjTPyKrZeaiVjDk nBfEQNHN49bwRi/NVH4iGzkCMw== X-Google-Smtp-Source: AA0mqf5Ct9lyTd0t0PIpKHrR2fvGzlGpqd0kxk6VIFCVK4Ckp27HzLLjvycFuCodXJHfa/pjm6FVZg== X-Received: by 2002:a17:902:da8d:b0:189:3a04:4466 with SMTP id j13-20020a170902da8d00b001893a044466mr16713plx.2.1670887599032; Mon, 12 Dec 2022 15:26:39 -0800 (PST) Received: from google.com (7.104.168.34.bc.googleusercontent.com. [34.168.104.7]) by smtp.gmail.com with ESMTPSA id z9-20020a170903018900b00189af02aba4sm6992708plg.3.2022.12.12.15.26.38 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 12 Dec 2022 15:26:38 -0800 (PST) Date: Mon, 12 Dec 2022 23:26:35 +0000 From: Sean Christopherson To: Paolo Bonzini Subject: Re: [RFC PATCH 00/37] KVM: Refactor the KVM/x86 TDP MMU into common code Message-ID: References: <20221208193857.4090582-1-dmatlack@google.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: Cc: Anshuman Khandual , Hugh Dickins , Paul Walmsley , kvmarm@lists.linux.dev, Nadav Amit , Colin Cross , Ben Gardon , linux-riscv@lists.infradead.org, kvmarm@lists.cs.columbia.edu, Yu Zhao , xu xin , Huacai Chen , "Matthew Wilcox \(Oracle\)" , Aleksandar Markovic , Krish Sadhukhan , Palmer Dabbelt , Mingwei Zhang , Albert Ou , Arnd Bergmann , "Liam R. Howlett" , kvm@vger.kernel.org, Atish Patra , David Matlack , Suren Baghdasaryan , Vlastimil Babka , linux-arm-kernel@lists.infradead.org, linux-mips@vger.kernel.org, kvm-riscv@lists.infradead.org, Marc Zyngier , Andrew Morton X-BeenThere: kvmarm@lists.cs.columbia.edu X-Mailman-Version: 2.1.14 Precedence: list List-Id: Where KVM/ARM decisions are made List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Errors-To: kvmarm-bounces@lists.cs.columbia.edu Sender: kvmarm-bounces@lists.cs.columbia.edu T24gTW9uLCBEZWMgMTIsIDIwMjIsIFBhb2xvIEJvbnppbmkgd3JvdGU6Cj4gT24gMTIvOS8yMiAy MDowNywgT2xpdmVyIFVwdG9uIHdyb3RlOgo+ID4gPiAgIC0gTmFtaW5nLiBUaGlzIHNlcmllcyBk b2VzIG5vdCBjaGFuZ2UgdGhlIG5hbWVzIG9mIGFueSBleGlzdGluZyBjb2RlLgo+ID4gPiAgICAg U28gYWxsIHRoZSBLVk0veDg2IFNoYWRvdyBNTVUtc3R5bGUgdGVybWlub2xvZ3kgbGlrZQo+ID4g PiAgICAgInNoYWRvd19wYWdlIi8ic3AiLyJzcHRlIiBwZXJzaXN0cy4gU2hvdWxkIHdlIGtlZXAg dGhhdCBzdHlsZSBpbgo+ID4gPiAgICAgY29tbW9uIGNvZGUgb3IgbW92ZSB0b3dhcmQgc29tZXRo aW5nIGxlc3Mgc2hhZG93LXBhZ2luZy1zcGVjaWZpYz8KPiA+ID4gICAgIGUuZy4gInBhZ2VfdGFi bGUiLyJwdCIvInB0ZSIuCj4gPiAKPiA+IEkgd291bGQgc3Ryb25nbHkgYmUgaW4gZmF2b3Igb2Yg ZGlzY2FyZGluZyB0aGUgc2hhZG93IHBhZ2luZyByZXNpZHVlIGlmCj4gPiB4ODYgZm9sa3MgYXJl IHdpbGxpbmcgdG8gcGFydCB3YXlzIHdpdGggaXQg8J+YhAo+IAo+IFllcywgYWJzb2x1dGVseS4g IFNvbWV0aGluZyBsaWtlIHRvX3NoYWRvd19wYWdlLT50b19tbXVfZGF0YSwgc3AtPm1kLAo+IHNw dC0+aHB0LCBzcHRlLT5zcHRlLCBzcHRlcC0+aHB0ZXAuCgoiaG9zdCIgd2lsbCBiZSBjb25mdXNp bmcgaWYgd2hlbiB0aGUgcHJpbWFyeSBNTVUgaXMgaW52b2x2ZWQgdGhvdWdoLCBlLmcuIEkgYWx3 YXlzCnRoaW5rIG9mIHRoZSBwcmltYXJ5IE1NVSdzIHBhZ2UgdGFibGVzIGFzIHRoZSAiaG9zdCBw YWdlIHRhYmxlcyIuCgpXaGF0IGlmIHdlIGtlZXAgdGhlICJTIiBmb3IgU1BUKEUpIGFuZCByZXB1 cnBvc2UgaXQgdG8gbWVhbiBTZWNvbmRhcnkgUFRFPwpfX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fXwprdm1hcm0gbWFpbGluZyBsaXN0Cmt2bWFybUBsaXN0cy5j cy5jb2x1bWJpYS5lZHUKaHR0cHM6Ly9saXN0cy5jcy5jb2x1bWJpYS5lZHUvbWFpbG1hbi9saXN0 aW5mby9rdm1hcm0K From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pj1-f49.google.com (mail-pj1-f49.google.com [209.85.216.49]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B03267475 for ; Mon, 12 Dec 2022 23:26:39 +0000 (UTC) Received: by mail-pj1-f49.google.com with SMTP id v13-20020a17090a6b0d00b00219c3be9830so1654408pjj.4 for ; Mon, 12 Dec 2022 15:26:39 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20210112; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date:from:to :cc:subject:date:message-id:reply-to; bh=zJOQecEGgSp0glbzJ1RpRnPbkp2HAzeJE/NybulD13E=; b=LgVzXCUoiKNG9USGHdtxDWk3jXHPhUfF7aC6Jb6oAf8XA1bTwz+AQ/vH//iOu+Txbq HtNSM7bobeYY6HNyDm3070/s1Oas0aeVxdQOxg9nHQgvvOSD+HbQky0G3NWU2aHHH9iG JVh1AUDnlaepYuer6Ncinshp4+sTBfERSvbRGIUdHuN0fvrTLKzxKu4eop/o7jhMUBSa 9I1Z1oUAs6TpwbdTo0ilfAV5dpWM/KOAPcjBCaf+Wh+PzYd+4+Je5We3hpfEFSHW2X9B XNOJfuewe5Qh+b7VEFMhtgGppnAqVlzsDeqFiGrPyEqs9m8tEG3SEwVL1QUihijPEdBo 3YcQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=zJOQecEGgSp0glbzJ1RpRnPbkp2HAzeJE/NybulD13E=; b=aTi1vUqg0sbtmCJtN2W1LvWq/v4wFARyqVywijl4ioJpECE35sXyNzr/gMnDnaYpFX J+wJ4nA/agZ9MwCC2Y/pma50m0LxjEc88/SHck3c8cWEIVDbifxi+kUQ0I5dZjyQGwHg MujOerMl858gjKwziQ7LjyPf41bgOHe6nY5SIXE4SozmbqtNCgAB4dukuHeIEP/Hzhz3 ExhYwcBkkrnm2FsxpRnZ+GICZzKPFH5P6eyAdBarDWwrpeqG5WbmgOPohJm4KFcXL0iT eISBuTuDaHsbMj7BPUpia2SEqqRVQuvzZlMBPhutDPl99Pt1Idgvtwt5ovC65JeiSXKL /oMQ== X-Gm-Message-State: ANoB5plQRHxVDQgTpN7hprJAM5K4xvacZQuemlZLgw6U6GzO60arQNVh zbRx6n6V4X/9YSjHmhBf5AKQFw== X-Google-Smtp-Source: AA0mqf5Ct9lyTd0t0PIpKHrR2fvGzlGpqd0kxk6VIFCVK4Ckp27HzLLjvycFuCodXJHfa/pjm6FVZg== X-Received: by 2002:a17:902:da8d:b0:189:3a04:4466 with SMTP id j13-20020a170902da8d00b001893a044466mr16713plx.2.1670887599032; Mon, 12 Dec 2022 15:26:39 -0800 (PST) Received: from google.com (7.104.168.34.bc.googleusercontent.com. [34.168.104.7]) by smtp.gmail.com with ESMTPSA id z9-20020a170903018900b00189af02aba4sm6992708plg.3.2022.12.12.15.26.38 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 12 Dec 2022 15:26:38 -0800 (PST) Date: Mon, 12 Dec 2022 23:26:35 +0000 From: Sean Christopherson To: Paolo Bonzini Cc: Oliver Upton , David Matlack , Marc Zyngier , James Morse , Alexandru Elisei , Suzuki K Poulose , Huacai Chen , Aleksandar Markovic , Anup Patel , Atish Patra , Paul Walmsley , Palmer Dabbelt , Albert Ou , Andrew Morton , Anshuman Khandual , Nadav Amit , "Matthew Wilcox (Oracle)" , Vlastimil Babka , "Liam R. Howlett" , Suren Baghdasaryan , Peter Xu , xu xin , Arnd Bergmann , Yu Zhao , Colin Cross , Hugh Dickins , Ben Gardon , Mingwei Zhang , Krish Sadhukhan , Ricardo Koller , Jing Zhang , linux-arm-kernel@lists.infradead.org, kvmarm@lists.linux.dev, kvmarm@lists.cs.columbia.edu, linux-mips@vger.kernel.org, kvm@vger.kernel.org, kvm-riscv@lists.infradead.org, linux-riscv@lists.infradead.org Subject: Re: [RFC PATCH 00/37] KVM: Refactor the KVM/x86 TDP MMU into common code Message-ID: References: <20221208193857.4090582-1-dmatlack@google.com> Precedence: bulk X-Mailing-List: kvmarm@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: Message-ID: <20221212232635.5I_d3vApqbsnVy69WyRumicWXUBxOr7K7lbwxgJJf6U@z> On Mon, Dec 12, 2022, Paolo Bonzini wrote: > On 12/9/22 20:07, Oliver Upton wrote: > > > - Naming. This series does not change the names of any existing code. > > > So all the KVM/x86 Shadow MMU-style terminology like > > > "shadow_page"/"sp"/"spte" persists. Should we keep that style in > > > common code or move toward something less shadow-paging-specific? > > > e.g. "page_table"/"pt"/"pte". > > > > I would strongly be in favor of discarding the shadow paging residue if > > x86 folks are willing to part ways with it 😄 > > Yes, absolutely. Something like to_shadow_page->to_mmu_data, sp->md, > spt->hpt, spte->spte, sptep->hptep. "host" will be confusing if when the primary MMU is involved though, e.g. I always think of the primary MMU's page tables as the "host page tables". What if we keep the "S" for SPT(E) and repurpose it to mean Secondary PTE? From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id F3F8FC4332F for ; Mon, 12 Dec 2022 23:27:05 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=7/lMy2FEShJJ32VgIaQsX1b5k1aAQ7su46t408mhuws=; b=yN9M5fn3X+TZak 7xzOabisgRSCmWp9ABllpgb1OnOo05fF9TXKNCPWXyFaK0grH46+2Uf8F0Rq1PzVPEW3XIQBTz14H JXkqGrqMN4Xo7kJuTX7uVZr5f1/ySxxRQk42iCtf0mgJlN1SIe3m81q8nXKVLJb0d/vfVou+njxqT SjlUq/09jiKXxILCqwd8oSqvdR5WvHl2HnNJStvte2siuXb2Y4UAdrukXgruNPGO1rOCvmXCaeNk7 CzGaTrTe5xhRKhvXSpHz7uXSRYvhJhDsltcVv9UwWmxg22pso+Tdgt9zknp0HbiBYEGoXPWwN9IfI dfJ7j//wktQyMvRz/Efg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1p4sCH-007DbL-NV; Mon, 12 Dec 2022 23:26:57 +0000 Received: from mail-pl1-x62f.google.com ([2607:f8b0:4864:20::62f]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1p4sC6-007DQd-Si for linux-riscv@lists.infradead.org; Mon, 12 Dec 2022 23:26:49 +0000 Received: by mail-pl1-x62f.google.com with SMTP id l10so123460plb.8 for ; Mon, 12 Dec 2022 15:26:39 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20210112; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date:from:to :cc:subject:date:message-id:reply-to; bh=zJOQecEGgSp0glbzJ1RpRnPbkp2HAzeJE/NybulD13E=; b=LgVzXCUoiKNG9USGHdtxDWk3jXHPhUfF7aC6Jb6oAf8XA1bTwz+AQ/vH//iOu+Txbq HtNSM7bobeYY6HNyDm3070/s1Oas0aeVxdQOxg9nHQgvvOSD+HbQky0G3NWU2aHHH9iG JVh1AUDnlaepYuer6Ncinshp4+sTBfERSvbRGIUdHuN0fvrTLKzxKu4eop/o7jhMUBSa 9I1Z1oUAs6TpwbdTo0ilfAV5dpWM/KOAPcjBCaf+Wh+PzYd+4+Je5We3hpfEFSHW2X9B XNOJfuewe5Qh+b7VEFMhtgGppnAqVlzsDeqFiGrPyEqs9m8tEG3SEwVL1QUihijPEdBo 3YcQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=zJOQecEGgSp0glbzJ1RpRnPbkp2HAzeJE/NybulD13E=; b=ceOImfyKO8MV8UnM2CBYPypkbLxuYHRS5z+ncxMR61VvyApZfrW2zR+m4+8i2GN+cn xG8haYsVOxwhXYOWmN586XR+xgoHhbnco6ZHouOsm4XpNaqQeGAB0YLtjdfUl7J4pfBS vAtxPB6lMrZyDNfDqqd7LvBhkVIwm4MEWx17hPKxgr0wMWy3aCL57tNkz/R+uxzlXks9 gR7J9ZzYJ2zW+wxqcX6u0ZrmCbB6AQPD1ONNKQ7fs/NNYZjCXM0IF/sAYemWLk06bsfw wePNKpIsDQtXxbxKVzbOBuWfhxFBSZP34edCMXMC/k0S626izpDnAGP84ncXtU/ZbTox MRgw== X-Gm-Message-State: ANoB5pkeV85nDn8lhRA82mxGJRFbuwsgQHQ5miQ9P8N5yrsM1KIZD8kW VPhGJfCncFcZFMfUXUtsA7G5Hg== X-Google-Smtp-Source: AA0mqf5Ct9lyTd0t0PIpKHrR2fvGzlGpqd0kxk6VIFCVK4Ckp27HzLLjvycFuCodXJHfa/pjm6FVZg== X-Received: by 2002:a17:902:da8d:b0:189:3a04:4466 with SMTP id j13-20020a170902da8d00b001893a044466mr16713plx.2.1670887599032; Mon, 12 Dec 2022 15:26:39 -0800 (PST) Received: from google.com (7.104.168.34.bc.googleusercontent.com. [34.168.104.7]) by smtp.gmail.com with ESMTPSA id z9-20020a170903018900b00189af02aba4sm6992708plg.3.2022.12.12.15.26.38 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 12 Dec 2022 15:26:38 -0800 (PST) Date: Mon, 12 Dec 2022 23:26:35 +0000 From: Sean Christopherson To: Paolo Bonzini Cc: Oliver Upton , David Matlack , Marc Zyngier , James Morse , Alexandru Elisei , Suzuki K Poulose , Huacai Chen , Aleksandar Markovic , Anup Patel , Atish Patra , Paul Walmsley , Palmer Dabbelt , Albert Ou , Andrew Morton , Anshuman Khandual , Nadav Amit , "Matthew Wilcox (Oracle)" , Vlastimil Babka , "Liam R. Howlett" , Suren Baghdasaryan , Peter Xu , xu xin , Arnd Bergmann , Yu Zhao , Colin Cross , Hugh Dickins , Ben Gardon , Mingwei Zhang , Krish Sadhukhan , Ricardo Koller , Jing Zhang , linux-arm-kernel@lists.infradead.org, kvmarm@lists.linux.dev, kvmarm@lists.cs.columbia.edu, linux-mips@vger.kernel.org, kvm@vger.kernel.org, kvm-riscv@lists.infradead.org, linux-riscv@lists.infradead.org Subject: Re: [RFC PATCH 00/37] KVM: Refactor the KVM/x86 TDP MMU into common code Message-ID: References: <20221208193857.4090582-1-dmatlack@google.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20221212_152646_955099_CB3198FA X-CRM114-Status: GOOD ( 13.55 ) X-BeenThere: linux-riscv@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-riscv" Errors-To: linux-riscv-bounces+linux-riscv=archiver.kernel.org@lists.infradead.org T24gTW9uLCBEZWMgMTIsIDIwMjIsIFBhb2xvIEJvbnppbmkgd3JvdGU6Cj4gT24gMTIvOS8yMiAy MDowNywgT2xpdmVyIFVwdG9uIHdyb3RlOgo+ID4gPiAgIC0gTmFtaW5nLiBUaGlzIHNlcmllcyBk b2VzIG5vdCBjaGFuZ2UgdGhlIG5hbWVzIG9mIGFueSBleGlzdGluZyBjb2RlLgo+ID4gPiAgICAg U28gYWxsIHRoZSBLVk0veDg2IFNoYWRvdyBNTVUtc3R5bGUgdGVybWlub2xvZ3kgbGlrZQo+ID4g PiAgICAgInNoYWRvd19wYWdlIi8ic3AiLyJzcHRlIiBwZXJzaXN0cy4gU2hvdWxkIHdlIGtlZXAg dGhhdCBzdHlsZSBpbgo+ID4gPiAgICAgY29tbW9uIGNvZGUgb3IgbW92ZSB0b3dhcmQgc29tZXRo aW5nIGxlc3Mgc2hhZG93LXBhZ2luZy1zcGVjaWZpYz8KPiA+ID4gICAgIGUuZy4gInBhZ2VfdGFi bGUiLyJwdCIvInB0ZSIuCj4gPiAKPiA+IEkgd291bGQgc3Ryb25nbHkgYmUgaW4gZmF2b3Igb2Yg ZGlzY2FyZGluZyB0aGUgc2hhZG93IHBhZ2luZyByZXNpZHVlIGlmCj4gPiB4ODYgZm9sa3MgYXJl IHdpbGxpbmcgdG8gcGFydCB3YXlzIHdpdGggaXQg8J+YhAo+IAo+IFllcywgYWJzb2x1dGVseS4g IFNvbWV0aGluZyBsaWtlIHRvX3NoYWRvd19wYWdlLT50b19tbXVfZGF0YSwgc3AtPm1kLAo+IHNw dC0+aHB0LCBzcHRlLT5zcHRlLCBzcHRlcC0+aHB0ZXAuCgoiaG9zdCIgd2lsbCBiZSBjb25mdXNp bmcgaWYgd2hlbiB0aGUgcHJpbWFyeSBNTVUgaXMgaW52b2x2ZWQgdGhvdWdoLCBlLmcuIEkgYWx3 YXlzCnRoaW5rIG9mIHRoZSBwcmltYXJ5IE1NVSdzIHBhZ2UgdGFibGVzIGFzIHRoZSAiaG9zdCBw YWdlIHRhYmxlcyIuCgpXaGF0IGlmIHdlIGtlZXAgdGhlICJTIiBmb3IgU1BUKEUpIGFuZCByZXB1 cnBvc2UgaXQgdG8gbWVhbiBTZWNvbmRhcnkgUFRFPwoKX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX18KbGludXgtcmlzY3YgbWFpbGluZyBsaXN0CmxpbnV4LXJp c2N2QGxpc3RzLmluZnJhZGVhZC5vcmcKaHR0cDovL2xpc3RzLmluZnJhZGVhZC5vcmcvbWFpbG1h bi9saXN0aW5mby9saW51eC1yaXNjdgo= From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 6E89CC4332F for ; Mon, 12 Dec 2022 23:27:48 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=2YUrmZmM0Y7tVuLgixNlJ82wxdinscruOdhv3NVn5sc=; b=4iCXQMjtcpT7JR 6GsZ6gqyApRsPkFPlE05nSmUKGRFsD45ldLD7Jo1TxGWnWN7XD5mJ5M6ml9tYRgTgldMa84b+fGIi b9Vjz3QSGzNyLGrnooaHFOfLxWkenrq2nC7Aggx3gWX5kTgN9638XsKty/9McaF6tcjMsEmBTS1JB Y6nyCxiL/O8Vj2NURB0nZCJfVAX2F3t74UeK3xnxKY6SIDNelTQS4VkD7vekfzZpiPxPATPeP9K4P mWYHUwd48ffuTB+Yb5PM3hhAWL6bQhJ2tMr8UM427A+g/mfZKQQX0Vl1kyXUusiRzkX8dZxSd9S5H 2nWXF7hw+LKQsAyR0uCA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1p4sCA-007DXD-0L; Mon, 12 Dec 2022 23:26:50 +0000 Received: from mail-pj1-x102e.google.com ([2607:f8b0:4864:20::102e]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1p4sC6-007DQe-Sb for linux-arm-kernel@lists.infradead.org; Mon, 12 Dec 2022 23:26:48 +0000 Received: by mail-pj1-x102e.google.com with SMTP id n65-20020a17090a2cc700b0021bc5ef7a14so1738160pjd.0 for ; Mon, 12 Dec 2022 15:26:39 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20210112; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date:from:to :cc:subject:date:message-id:reply-to; bh=zJOQecEGgSp0glbzJ1RpRnPbkp2HAzeJE/NybulD13E=; b=LgVzXCUoiKNG9USGHdtxDWk3jXHPhUfF7aC6Jb6oAf8XA1bTwz+AQ/vH//iOu+Txbq HtNSM7bobeYY6HNyDm3070/s1Oas0aeVxdQOxg9nHQgvvOSD+HbQky0G3NWU2aHHH9iG JVh1AUDnlaepYuer6Ncinshp4+sTBfERSvbRGIUdHuN0fvrTLKzxKu4eop/o7jhMUBSa 9I1Z1oUAs6TpwbdTo0ilfAV5dpWM/KOAPcjBCaf+Wh+PzYd+4+Je5We3hpfEFSHW2X9B XNOJfuewe5Qh+b7VEFMhtgGppnAqVlzsDeqFiGrPyEqs9m8tEG3SEwVL1QUihijPEdBo 3YcQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=zJOQecEGgSp0glbzJ1RpRnPbkp2HAzeJE/NybulD13E=; b=PHAdsTQcW8FIOjh9F16Zo4OhcuZEv82NQtzPbeutcP9lfNjXr9qQuYqiy9yy2+9TKr r95HDgo8zMthyro7kRo7HYRNyo7kfQj1P7mfJr/At3BA/rUr/I5PdLhpOHzxXy1GhFH6 ab2eqyiRhEok8pmFJ8NtqAxaGQSu5OccjGNpmSr38Mp3EWJjg8kxeWH3z31CoI3HHPzj YnJVWVDtOJXY8/sBJCgOVGQjKWO5ZSLAtwyWLwzOfcZ4NeEESssnptop9hFV+mO4MNAn O2+5zrMDgkHcEIS8AZ31uiPq7ejlsrFxTQh/Uvavg9sLQFgCZuLYDLknX+REvb3IpFuN M2kw== X-Gm-Message-State: ANoB5pnAa045HupjuIVgvEvQdHvFDpExfNl6hcZusNfELxcQYLb2RNMA gSWaFFAcofzEX6nVXyapMXd8PQ== X-Google-Smtp-Source: AA0mqf5Ct9lyTd0t0PIpKHrR2fvGzlGpqd0kxk6VIFCVK4Ckp27HzLLjvycFuCodXJHfa/pjm6FVZg== X-Received: by 2002:a17:902:da8d:b0:189:3a04:4466 with SMTP id j13-20020a170902da8d00b001893a044466mr16713plx.2.1670887599032; Mon, 12 Dec 2022 15:26:39 -0800 (PST) Received: from google.com (7.104.168.34.bc.googleusercontent.com. [34.168.104.7]) by smtp.gmail.com with ESMTPSA id z9-20020a170903018900b00189af02aba4sm6992708plg.3.2022.12.12.15.26.38 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 12 Dec 2022 15:26:38 -0800 (PST) Date: Mon, 12 Dec 2022 23:26:35 +0000 From: Sean Christopherson To: Paolo Bonzini Cc: Oliver Upton , David Matlack , Marc Zyngier , James Morse , Alexandru Elisei , Suzuki K Poulose , Huacai Chen , Aleksandar Markovic , Anup Patel , Atish Patra , Paul Walmsley , Palmer Dabbelt , Albert Ou , Andrew Morton , Anshuman Khandual , Nadav Amit , "Matthew Wilcox (Oracle)" , Vlastimil Babka , "Liam R. Howlett" , Suren Baghdasaryan , Peter Xu , xu xin , Arnd Bergmann , Yu Zhao , Colin Cross , Hugh Dickins , Ben Gardon , Mingwei Zhang , Krish Sadhukhan , Ricardo Koller , Jing Zhang , linux-arm-kernel@lists.infradead.org, kvmarm@lists.linux.dev, kvmarm@lists.cs.columbia.edu, linux-mips@vger.kernel.org, kvm@vger.kernel.org, kvm-riscv@lists.infradead.org, linux-riscv@lists.infradead.org Subject: Re: [RFC PATCH 00/37] KVM: Refactor the KVM/x86 TDP MMU into common code Message-ID: References: <20221208193857.4090582-1-dmatlack@google.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20221212_152646_953545_A06C1E63 X-CRM114-Status: GOOD ( 15.15 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org T24gTW9uLCBEZWMgMTIsIDIwMjIsIFBhb2xvIEJvbnppbmkgd3JvdGU6Cj4gT24gMTIvOS8yMiAy MDowNywgT2xpdmVyIFVwdG9uIHdyb3RlOgo+ID4gPiAgIC0gTmFtaW5nLiBUaGlzIHNlcmllcyBk b2VzIG5vdCBjaGFuZ2UgdGhlIG5hbWVzIG9mIGFueSBleGlzdGluZyBjb2RlLgo+ID4gPiAgICAg U28gYWxsIHRoZSBLVk0veDg2IFNoYWRvdyBNTVUtc3R5bGUgdGVybWlub2xvZ3kgbGlrZQo+ID4g PiAgICAgInNoYWRvd19wYWdlIi8ic3AiLyJzcHRlIiBwZXJzaXN0cy4gU2hvdWxkIHdlIGtlZXAg dGhhdCBzdHlsZSBpbgo+ID4gPiAgICAgY29tbW9uIGNvZGUgb3IgbW92ZSB0b3dhcmQgc29tZXRo aW5nIGxlc3Mgc2hhZG93LXBhZ2luZy1zcGVjaWZpYz8KPiA+ID4gICAgIGUuZy4gInBhZ2VfdGFi bGUiLyJwdCIvInB0ZSIuCj4gPiAKPiA+IEkgd291bGQgc3Ryb25nbHkgYmUgaW4gZmF2b3Igb2Yg ZGlzY2FyZGluZyB0aGUgc2hhZG93IHBhZ2luZyByZXNpZHVlIGlmCj4gPiB4ODYgZm9sa3MgYXJl IHdpbGxpbmcgdG8gcGFydCB3YXlzIHdpdGggaXQg8J+YhAo+IAo+IFllcywgYWJzb2x1dGVseS4g IFNvbWV0aGluZyBsaWtlIHRvX3NoYWRvd19wYWdlLT50b19tbXVfZGF0YSwgc3AtPm1kLAo+IHNw dC0+aHB0LCBzcHRlLT5zcHRlLCBzcHRlcC0+aHB0ZXAuCgoiaG9zdCIgd2lsbCBiZSBjb25mdXNp bmcgaWYgd2hlbiB0aGUgcHJpbWFyeSBNTVUgaXMgaW52b2x2ZWQgdGhvdWdoLCBlLmcuIEkgYWx3 YXlzCnRoaW5rIG9mIHRoZSBwcmltYXJ5IE1NVSdzIHBhZ2UgdGFibGVzIGFzIHRoZSAiaG9zdCBw YWdlIHRhYmxlcyIuCgpXaGF0IGlmIHdlIGtlZXAgdGhlICJTIiBmb3IgU1BUKEUpIGFuZCByZXB1 cnBvc2UgaXQgdG8gbWVhbiBTZWNvbmRhcnkgUFRFPwoKX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX18KbGludXgtYXJtLWtlcm5lbCBtYWlsaW5nIGxpc3QKbGlu dXgtYXJtLWtlcm5lbEBsaXN0cy5pbmZyYWRlYWQub3JnCmh0dHA6Ly9saXN0cy5pbmZyYWRlYWQu b3JnL21haWxtYW4vbGlzdGluZm8vbGludXgtYXJtLWtlcm5lbAo=