Re: [PATCH] Relocate the ESRT when booting via multiboot2

[Demi Marie Obenour <demi@invisiblethingslab.com>]

[-- Attachment #1: Type: text/plain, Size: 1280 bytes --]

On Mon, Dec 12, 2022 at 04:19:21PM +0100, Jan Beulich wrote:
> On 09.12.2022 01:52, Demi Marie Obenour wrote:
> > This was missed in the initial patchset.
> > 
> > Signed-off-by: Demi Marie Obenour <demi@invisiblethingslab.com>
> 
> It looks as if, besides ...
> 
> > --- a/xen/arch/x86/efi/efi-boot.h
> > +++ b/xen/arch/x86/efi/efi-boot.h
> > @@ -818,6 +818,8 @@ void __init efi_multiboot2(EFI_HANDLE ImageHandle, EFI_SYSTEM_TABLE *SystemTable
> >      if ( gop )
> >          efi_set_gop_mode(gop, gop_mode);
> >  
> > +    efi_relocate_esrt(SystemTable);
> > +
> >      efi_exit_boot(ImageHandle, SystemTable);
> >  }
> >  
> 
> ... this core piece, the rest is merely pure code movement, with the goal
> of avoiding a forward declaration. If such is the case, please say so in
> your description. I'll add a sentence to this effect when committing, so
> the remark if for future patches. Provided of course it is true (i.e. I'm
> not overlooking any tiny change) - please confirm.

It is indeed just code movement.

> Reviewed-by: Jan Beulich <jbeulich@suse.com>

Thanks!  Do you want me to submit a separate patch for backporting to
4.17, or do you plan on doing that?
-- 
Sincerely,
Demi Marie Obenour (she/her/hers)
Invisible Things Lab

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]