From: David Vernet <void@manifault.com>
To: Yonghong Song <yhs@fb.com>
Cc: bpf@vger.kernel.org, Alexei Starovoitov <ast@kernel.org>,
Andrii Nakryiko <andrii@kernel.org>,
Daniel Borkmann <daniel@iogearbox.net>,
kernel-team@fb.com, Martin KaFai Lau <martin.lau@kernel.org>,
kernel test robot <lkp@intel.com>
Subject: Re: [PATCH bpf] selftests/bpf: Fix a selftest compilation error with CONFIG_SMP=n
Date: Mon, 12 Dec 2022 17:58:52 -0600 [thread overview]
Message-ID: <Y5fAPGtmyL7glLGq@maniforge.lan> (raw)
In-Reply-To: <Y5fAHJTI742+jte7@maniforge.lan>
On Mon, Dec 12, 2022 at 05:58:20PM -0600, David Vernet wrote:
> On Mon, Dec 12, 2022 at 03:46:17PM -0800, Yonghong Song wrote:
> > Kernel test robot reported bpf selftest build failure when CONFIG_SMP
> > is not set. The error message looks below:
> >
> > >> progs/rcu_read_lock.c:256:34: error: no member named 'last_wakee' in 'struct task_struct'
> > last_wakee = task->real_parent->last_wakee;
> > ~~~~~~~~~~~~~~~~~ ^
> > 1 error generated.
> >
> > When CONFIG_SMP is not set, the field 'last_wakee' is not available in struct
> > 'task_struct'. Hence the above compilation failure. To fix the issue, let us
> > choose another field 'group_leader' which is available regardless of
> > CONDFIG_SMP set or not.
>
> s/CONDFIG_SMP/CONFIG_SMP
>
> >
> > Reported-by: kernel test robot <lkp@intel.com>
> > Signed-off-by: Yonghong Song <yhs@fb.com>
Also:
Acked-by: David Vernet <void@manifault.com>
next prev parent reply other threads:[~2022-12-12 23:58 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-12-12 23:46 [PATCH bpf] selftests/bpf: Fix a selftest compilation error with CONFIG_SMP=n Yonghong Song
2022-12-12 23:58 ` David Vernet
2022-12-12 23:58 ` David Vernet [this message]
2022-12-13 0:41 ` Yonghong Song
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Y5fAPGtmyL7glLGq@maniforge.lan \
--to=void@manifault.com \
--cc=andrii@kernel.org \
--cc=ast@kernel.org \
--cc=bpf@vger.kernel.org \
--cc=daniel@iogearbox.net \
--cc=kernel-team@fb.com \
--cc=lkp@intel.com \
--cc=martin.lau@kernel.org \
--cc=yhs@fb.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.