From mboxrd@z Thu Jan 1 00:00:00 1970 From: Sean Christopherson Date: Tue, 13 Dec 2022 01:42:10 +0000 Subject: [RFC PATCH 01/37] KVM: x86/mmu: Store the address space ID directly in kvm_mmu_page_role In-Reply-To: <01cb4882-7a06-176f-7d55-f80cca300ffd@redhat.com> References: <20221208193857.4090582-1-dmatlack@google.com> <20221208193857.4090582-2-dmatlack@google.com> <22fe2332-497e-fe30-0155-e026b0eded97@intel.com> <01cb4882-7a06-176f-7d55-f80cca300ffd@redhat.com> Message-ID: List-Id: To: kvm-riscv@lists.infradead.org MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit On Mon, Dec 12, 2022, Paolo Bonzini wrote: > On 12/12/22 18:39, Sean Christopherson wrote: > > My preference would be to leave .smm in x86's page role > > What about defining a byte of arch_role and a macro to build it? I think David already carved out a big chunk for arch role bits, my objection was purely to making as_id a generic 8-bit role. > > Unless I'm missing something, e.g. a need to map GPAs differently for > > SMM vs. non-SMM, SMM could have been implemented with a simple flag > > in a memslot to mark the memslot as SMM-only. > > Unfortunately not, because there can be another region (for example video > RAM at 0A0000h) underneath SMRAM. Ugh, it's even a very explicitly documented "feature". When compatible SMM space is enabled, SMM-mode CBO accesses to this range route to physical system DRAM at 00_000A_0h ? 00_000B_FFFFh. Non-SMM mode CBO accesses to this range are considered to be to the Video Buffer Area as described above. PCI Express* and DMI originated cycles to SMM space are not supported and are considered to be to the Video Buffer Area. I also forgot KVM supports SMBASE relocation :-( > In fact, KVM_MEM_X86_SMRAM was the first idea. It was uglier than multiple > address spaces (https://lore.kernel.org/lkml/1431084034-8425-1-git-send-email-pbonzini at redhat.com). > In retrospect there were probably ways to mix the best of the two designs, > but it wasn't generic enough. > > > And separate address spaces become truly nasty if the CPU can access multiple > > protected regions, e.g. if the CPU can access type X and type Y at the same time, > > then there would need to be memslots for "regular", X, Y, and X+Y. > > Without a usecase that's hard to say. It's just as possible that there > would be a natural hierarchy of levels. Ah, true. From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mm01.cs.columbia.edu (mm01.cs.columbia.edu [128.59.11.253]) by smtp.lore.kernel.org (Postfix) with ESMTP id 03415C4332F for ; Tue, 13 Dec 2022 01:42:18 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by mm01.cs.columbia.edu (Postfix) with ESMTP id 9411A4B870; Mon, 12 Dec 2022 20:42:18 -0500 (EST) X-Virus-Scanned: at lists.cs.columbia.edu Authentication-Results: mm01.cs.columbia.edu (amavisd-new); dkim=softfail (fail, message has been altered) header.i=@google.com Received: from mm01.cs.columbia.edu ([127.0.0.1]) by localhost (mm01.cs.columbia.edu [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id WIE1yWwopi5c; Mon, 12 Dec 2022 20:42:17 -0500 (EST) Received: from mm01.cs.columbia.edu (localhost [127.0.0.1]) by mm01.cs.columbia.edu (Postfix) with ESMTP id 674F04B935; Mon, 12 Dec 2022 20:42:17 -0500 (EST) Received: from localhost (localhost [127.0.0.1]) by mm01.cs.columbia.edu (Postfix) with ESMTP id 67CE44B925 for ; Mon, 12 Dec 2022 20:42:16 -0500 (EST) X-Virus-Scanned: at lists.cs.columbia.edu Received: from mm01.cs.columbia.edu ([127.0.0.1]) by localhost (mm01.cs.columbia.edu [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id rAfA57TT5x72 for ; Mon, 12 Dec 2022 20:42:15 -0500 (EST) Received: from mail-pf1-f170.google.com (mail-pf1-f170.google.com [209.85.210.170]) by mm01.cs.columbia.edu (Postfix) with ESMTPS id 2E7164B870 for ; Mon, 12 Dec 2022 20:42:15 -0500 (EST) Received: by mail-pf1-f170.google.com with SMTP id a14so1211120pfa.1 for ; Mon, 12 Dec 2022 17:42:15 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20210112; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date:from:to :cc:subject:date:message-id:reply-to; bh=opT7QlxBkoYVHWKjfFWe+3FrtkzNsO2VihRNj3rgWn4=; b=SK1WTnhEcJ7vOVSL2xzzXtEkHtH43rxXSGW7Dtujo2q/jDMxxwle2K41T6LEOAbu31 njuyn58rLHAdSISg9P623gyKYXFOPbX7pgjYFQq0nCNnpQM5nUBslElHcKrZV00WUweD 2Ab6o7XW4eUWoa8IW7OXTpjK3c5JsXSeCBMBKd1ZVWft5A67PRSXDH8qkRexDCQaB9Yn RRx3hIYf+BW8rjptQ0hTe+UyiZNfb7Ry3StWfXGfsaNsXjMTMnyjPwgtlBcOWZ5bOvDK NYZEtjUykiKNojc+IPEX89P4N1KrKqPpyt3Z0lKnKRo6M5fuKnMpjzJMGm1TZAMuI+Yh G8/w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=opT7QlxBkoYVHWKjfFWe+3FrtkzNsO2VihRNj3rgWn4=; b=2BvjCtSrtmgRcb8WdtMx2MCUDJ8ujPXuhGrzB69P1584Ou1mghG8XviqyDPJZv/fEr Uf0sNUd0mpu8NG51GRQJCuMCt39/Mj/MDYt23x5PEttYWvttEbpGvi7Q3rsBV8ll9cJN hHdWs5O+bkwyoZ2tM9JnrFVccb+KZgn8sVv7zzhHSTaUN1Tq7o9kIiAwGK4gLhFnlCQU nyUVe5dfVw9HgOI0ksZIZ/75n/02Zg3LnKOUkDZXgWCH9JOpTKxYGbNe9z5aQF/L3cZV PfvUtHhnqMyEgWfcGsM13onCBCG+ifj04i4OU12QDO/2gkkR9odukMFMpK0REDgvnr1S 6G4Q== X-Gm-Message-State: ANoB5pnJfyaxQORNajBdHdTbMTwEkBBFnPgZYVNr3TdxTfkr3SAxkYMc 0XhAqm1DKPxoUi0jITgjtVSPCA== X-Google-Smtp-Source: AA0mqf4Ax5/VKVlxMD5DSzFDunN/IfJNpj08Gszf3tnTB/tljXojhITyTp9EJLu9yUUGsdwIrNP7Ng== X-Received: by 2002:a62:160a:0:b0:576:22d7:fd9e with SMTP id 10-20020a62160a000000b0057622d7fd9emr72299pfw.0.1670895734011; Mon, 12 Dec 2022 17:42:14 -0800 (PST) Received: from google.com (7.104.168.34.bc.googleusercontent.com. [34.168.104.7]) by smtp.gmail.com with ESMTPSA id i134-20020a62878c000000b005761c4754e7sm6630376pfe.144.2022.12.12.17.42.13 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 12 Dec 2022 17:42:13 -0800 (PST) Date: Tue, 13 Dec 2022 01:42:10 +0000 From: Sean Christopherson To: Paolo Bonzini Subject: Re: [RFC PATCH 01/37] KVM: x86/mmu: Store the address space ID directly in kvm_mmu_page_role Message-ID: References: <20221208193857.4090582-1-dmatlack@google.com> <20221208193857.4090582-2-dmatlack@google.com> <22fe2332-497e-fe30-0155-e026b0eded97@intel.com> <01cb4882-7a06-176f-7d55-f80cca300ffd@redhat.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <01cb4882-7a06-176f-7d55-f80cca300ffd@redhat.com> Cc: Anshuman Khandual , Hugh Dickins , Paul Walmsley , "Yang, Weijiang" , "Amit, Nadav" , Colin Cross , Ben Gardon , "linux-riscv@lists.infradead.org" , "kvmarm@lists.cs.columbia.edu" , Yu Zhao , Marc Zyngier , Huacai Chen , "Matthew Wilcox \(Oracle\)" , Aleksandar Markovic , Krish Sadhukhan , Palmer Dabbelt , Mingwei Zhang , Albert Ou , xu xin , Arnd Bergmann , "Liam R. Howlett" , "kvm@vger.kernel.org" , Atish Patra , David Matlack , Suren Baghdasaryan , Vlastimil Babka , "linux-arm-kernel@lists.infradead.org" , "kvmarm@lists.linux.dev" , "linux-mips@vger.kernel.org" , "kvm-riscv@lists.infradead.org" , Andrew Morton X-BeenThere: kvmarm@lists.cs.columbia.edu X-Mailman-Version: 2.1.14 Precedence: list List-Id: Where KVM/ARM decisions are made List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Errors-To: kvmarm-bounces@lists.cs.columbia.edu Sender: kvmarm-bounces@lists.cs.columbia.edu T24gTW9uLCBEZWMgMTIsIDIwMjIsIFBhb2xvIEJvbnppbmkgd3JvdGU6Cj4gT24gMTIvMTIvMjIg MTg6MzksIFNlYW4gQ2hyaXN0b3BoZXJzb24gd3JvdGU6Cj4gPiBNeSBwcmVmZXJlbmNlIHdvdWxk IGJlIHRvIGxlYXZlIC5zbW0gaW4geDg2J3MgcGFnZSByb2xlCj4gCj4gV2hhdCBhYm91dCBkZWZp bmluZyBhIGJ5dGUgb2YgYXJjaF9yb2xlIGFuZCBhIG1hY3JvIHRvIGJ1aWxkIGl0PwoKSSB0aGlu ayBEYXZpZCBhbHJlYWR5IGNhcnZlZCBvdXQgYSBiaWcgY2h1bmsgZm9yIGFyY2ggcm9sZSBiaXRz LCBteSBvYmplY3Rpb24Kd2FzIHB1cmVseSB0byBtYWtpbmcgYXNfaWQgYSBnZW5lcmljIDgtYml0 IHJvbGUuCgo+ID4gVW5sZXNzIEknbSBtaXNzaW5nIHNvbWV0aGluZywgZS5nLiBhIG5lZWQgdG8g bWFwIEdQQXMgZGlmZmVyZW50bHkgZm9yCj4gPiBTTU0gdnMuIG5vbi1TTU0sIFNNTSBjb3VsZCBo YXZlIGJlZW4gaW1wbGVtZW50ZWQgd2l0aCBhIHNpbXBsZSBmbGFnCj4gPiBpbiBhIG1lbXNsb3Qg dG8gbWFyayB0aGUgbWVtc2xvdCBhcyBTTU0tb25seS4KPiAKPiBVbmZvcnR1bmF0ZWx5IG5vdCwg YmVjYXVzZSB0aGVyZSBjYW4gYmUgYW5vdGhlciByZWdpb24gKGZvciBleGFtcGxlIHZpZGVvCj4g UkFNIGF0IDBBMDAwMGgpIHVuZGVybmVhdGggU01SQU0uCgpVZ2gsIGl0J3MgZXZlbiBhIHZlcnkg ZXhwbGljaXRseSBkb2N1bWVudGVkICJmZWF0dXJlIi4KCiAgV2hlbiBjb21wYXRpYmxlIFNNTSBz cGFjZSBpcyBlbmFibGVkLCBTTU0tbW9kZSBDQk8gYWNjZXNzZXMgdG8gdGhpcyByYW5nZSByb3V0 ZQogIHRvIHBoeXNpY2FsIHN5c3RlbSBEUkFNIGF0IDAwXzAwMEFfMGgg4oCTIDAwXzAwMEJfRkZG RmguCiAgCiAgTm9uLVNNTSBtb2RlIENCTyBhY2Nlc3NlcyB0byB0aGlzIHJhbmdlIGFyZSBjb25z aWRlcmVkIHRvIGJlIHRvIHRoZSBWaWRlbyBCdWZmZXIKICBBcmVhIGFzIGRlc2NyaWJlZCBhYm92 ZS4gUENJIEV4cHJlc3MqIGFuZCBETUkgb3JpZ2luYXRlZCBjeWNsZXMgdG8gU01NIHNwYWNlIGFy ZSBub3QKICBzdXBwb3J0ZWQgYW5kIGFyZSBjb25zaWRlcmVkIHRvIGJlIHRvIHRoZSBWaWRlbyBC dWZmZXIgQXJlYS4KCkkgYWxzbyBmb3Jnb3QgS1ZNIHN1cHBvcnRzIFNNQkFTRSByZWxvY2F0aW9u IDotKAoKPiBJbiBmYWN0LCBLVk1fTUVNX1g4Nl9TTVJBTSB3YXMgdGhlIGZpcnN0IGlkZWEuICBJ dCB3YXMgdWdsaWVyIHRoYW4gbXVsdGlwbGUKPiBhZGRyZXNzIHNwYWNlcyAoaHR0cHM6Ly9sb3Jl Lmtlcm5lbC5vcmcvbGttbC8xNDMxMDg0MDM0LTg0MjUtMS1naXQtc2VuZC1lbWFpbC1wYm9uemlu aUByZWRoYXQuY29tKS4KPiBJbiByZXRyb3NwZWN0IHRoZXJlIHdlcmUgcHJvYmFibHkgd2F5cyB0 byBtaXggdGhlIGJlc3Qgb2YgdGhlIHR3byBkZXNpZ25zLAo+IGJ1dCBpdCB3YXNuJ3QgZ2VuZXJp YyBlbm91Z2guCj4KPiA+IEFuZCBzZXBhcmF0ZSBhZGRyZXNzIHNwYWNlcyBiZWNvbWUgdHJ1bHkg bmFzdHkgaWYgdGhlIENQVSBjYW4gYWNjZXNzIG11bHRpcGxlCj4gPiBwcm90ZWN0ZWQgcmVnaW9u cywgZS5nLiBpZiB0aGUgQ1BVIGNhbiBhY2Nlc3MgdHlwZSBYIGFuZCB0eXBlIFkgYXQgdGhlIHNh bWUgdGltZSwKPiA+IHRoZW4gdGhlcmUgd291bGQgbmVlZCB0byBiZSBtZW1zbG90cyBmb3IgInJl Z3VsYXIiLCBYLCBZLCBhbmQgWCtZLgo+IAo+IFdpdGhvdXQgYSB1c2VjYXNlIHRoYXQncyBoYXJk IHRvIHNheS4gIEl0J3MganVzdCBhcyBwb3NzaWJsZSB0aGF0IHRoZXJlCj4gd291bGQgYmUgYSBu YXR1cmFsIGhpZXJhcmNoeSBvZiBsZXZlbHMuCgpBaCwgdHJ1ZS4KX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX18Ka3ZtYXJtIG1haWxpbmcgbGlzdAprdm1hcm1A bGlzdHMuY3MuY29sdW1iaWEuZWR1Cmh0dHBzOi8vbGlzdHMuY3MuY29sdW1iaWEuZWR1L21haWxt YW4vbGlzdGluZm8va3ZtYXJtCg== From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pg1-f176.google.com (mail-pg1-f176.google.com [209.85.215.176]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C4A7A15B0 for ; Tue, 13 Dec 2022 01:42:14 +0000 (UTC) Received: by mail-pg1-f176.google.com with SMTP id f9so9451079pgf.7 for ; Mon, 12 Dec 2022 17:42:14 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20210112; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date:from:to :cc:subject:date:message-id:reply-to; bh=opT7QlxBkoYVHWKjfFWe+3FrtkzNsO2VihRNj3rgWn4=; b=SK1WTnhEcJ7vOVSL2xzzXtEkHtH43rxXSGW7Dtujo2q/jDMxxwle2K41T6LEOAbu31 njuyn58rLHAdSISg9P623gyKYXFOPbX7pgjYFQq0nCNnpQM5nUBslElHcKrZV00WUweD 2Ab6o7XW4eUWoa8IW7OXTpjK3c5JsXSeCBMBKd1ZVWft5A67PRSXDH8qkRexDCQaB9Yn RRx3hIYf+BW8rjptQ0hTe+UyiZNfb7Ry3StWfXGfsaNsXjMTMnyjPwgtlBcOWZ5bOvDK NYZEtjUykiKNojc+IPEX89P4N1KrKqPpyt3Z0lKnKRo6M5fuKnMpjzJMGm1TZAMuI+Yh G8/w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=opT7QlxBkoYVHWKjfFWe+3FrtkzNsO2VihRNj3rgWn4=; b=tnDZUFjDZooGcyEgSZqdYPyey7aaLBGRws/E/V6Amf44Zy9Fw5PbgU0MTbnYHHo8rl MADjjIZEoBQLmiLG+HvCjtDCzfvt9k2DXdMeNFJrmlLeLmvpbIPrMilWgohiKo99KKvQ /xU3QYedtEEDf6mVkpoOOuo53x2tBHaH0XIb6Fu6OyFWoizgH8b+gWjpSOVFiTiG6lrt pUNRejQiNfSilfF2r+fjsj/uxZFndwQ6QqkT4l3MTpfO9lpUzX4jIW00zlH7uK68CVah dnutj8UoOGavngj39q/ZB3T02hA9eHNac9QOKclYwFQCRpNkCITn6I6fTZYwxY2J4hIf xSkw== X-Gm-Message-State: ANoB5pl+rDC2VWiX1YrUEQwSw0Vrir8rylJAB37KDcnXMj83QzI79HMk 2WBCbvkyMICW5lP0YGMOtIizxA== X-Google-Smtp-Source: AA0mqf4Ax5/VKVlxMD5DSzFDunN/IfJNpj08Gszf3tnTB/tljXojhITyTp9EJLu9yUUGsdwIrNP7Ng== X-Received: by 2002:a62:160a:0:b0:576:22d7:fd9e with SMTP id 10-20020a62160a000000b0057622d7fd9emr72299pfw.0.1670895734011; Mon, 12 Dec 2022 17:42:14 -0800 (PST) Received: from google.com (7.104.168.34.bc.googleusercontent.com. [34.168.104.7]) by smtp.gmail.com with ESMTPSA id i134-20020a62878c000000b005761c4754e7sm6630376pfe.144.2022.12.12.17.42.13 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 12 Dec 2022 17:42:13 -0800 (PST) Date: Tue, 13 Dec 2022 01:42:10 +0000 From: Sean Christopherson To: Paolo Bonzini Cc: David Matlack , Oliver Upton , "Yang, Weijiang" , Marc Zyngier , James Morse , Alexandru Elisei , Suzuki K Poulose , Huacai Chen , Aleksandar Markovic , Anup Patel , Atish Patra , Paul Walmsley , Palmer Dabbelt , Albert Ou , Andrew Morton , Anshuman Khandual , "Amit, Nadav" , "Matthew Wilcox (Oracle)" , Vlastimil Babka , "Liam R. Howlett" , Suren Baghdasaryan , Peter Xu , xu xin , Arnd Bergmann , Yu Zhao , Colin Cross , Hugh Dickins , Ben Gardon , Mingwei Zhang , Krish Sadhukhan , Ricardo Koller , Jing Zhang , "linux-arm-kernel@lists.infradead.org" , "kvmarm@lists.linux.dev" , "kvmarm@lists.cs.columbia.edu" , "linux-mips@vger.kernel.org" , "kvm@vger.kernel.org" , "kvm-riscv@lists.infradead.org" , "linux-riscv@lists.infradead.org" Subject: Re: [RFC PATCH 01/37] KVM: x86/mmu: Store the address space ID directly in kvm_mmu_page_role Message-ID: References: <20221208193857.4090582-1-dmatlack@google.com> <20221208193857.4090582-2-dmatlack@google.com> <22fe2332-497e-fe30-0155-e026b0eded97@intel.com> <01cb4882-7a06-176f-7d55-f80cca300ffd@redhat.com> Precedence: bulk X-Mailing-List: kvmarm@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <01cb4882-7a06-176f-7d55-f80cca300ffd@redhat.com> Message-ID: <20221213014210.AbpEfo5TwZQbuPmYv1d0f0ndLvIv-ZNiVbBVm9wZdeU@z> On Mon, Dec 12, 2022, Paolo Bonzini wrote: > On 12/12/22 18:39, Sean Christopherson wrote: > > My preference would be to leave .smm in x86's page role > > What about defining a byte of arch_role and a macro to build it? I think David already carved out a big chunk for arch role bits, my objection was purely to making as_id a generic 8-bit role. > > Unless I'm missing something, e.g. a need to map GPAs differently for > > SMM vs. non-SMM, SMM could have been implemented with a simple flag > > in a memslot to mark the memslot as SMM-only. > > Unfortunately not, because there can be another region (for example video > RAM at 0A0000h) underneath SMRAM. Ugh, it's even a very explicitly documented "feature". When compatible SMM space is enabled, SMM-mode CBO accesses to this range route to physical system DRAM at 00_000A_0h – 00_000B_FFFFh. Non-SMM mode CBO accesses to this range are considered to be to the Video Buffer Area as described above. PCI Express* and DMI originated cycles to SMM space are not supported and are considered to be to the Video Buffer Area. I also forgot KVM supports SMBASE relocation :-( > In fact, KVM_MEM_X86_SMRAM was the first idea. It was uglier than multiple > address spaces (https://lore.kernel.org/lkml/1431084034-8425-1-git-send-email-pbonzini@redhat.com). > In retrospect there were probably ways to mix the best of the two designs, > but it wasn't generic enough. > > > And separate address spaces become truly nasty if the CPU can access multiple > > protected regions, e.g. if the CPU can access type X and type Y at the same time, > > then there would need to be memslots for "regular", X, Y, and X+Y. > > Without a usecase that's hard to say. It's just as possible that there > would be a natural hierarchy of levels. Ah, true. From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 06B82C4332F for ; Tue, 13 Dec 2022 01:42:33 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=EdtiAkq0H456I3M0wh6i68H/gPboz9ch1ZIeKclggoA=; b=O0M0eS14tBPILf 7GMYW1zIS6FG/WbmRUhhqaPvgToO40QeeSonzp22PaEilmSsUjQb6uRti2EL14bP3m/bvr3nrifLl jck92zkr9cEt7Xyf5H8uw39xLYsZy8MQHu85yvO3WCLnwAiSEINYIm5S9eBcRekztky5p1+Jt1ovt mOV2CyrmpDNEMXUNv1dMWAZeAvzWf3CC3IfN7asZ9s/PufKV40WINgSLzNwyiyeg9I/4REqekWR9C VdqjYKubA0cwRIGVRRXQVz0rFC8ji5zGBQkkpr8Y0KiW7hX+MLA6/ON0EYLXIXu52dAgpN5s4p/mk LQw9PLx4fCUL+Gala87g==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1p4uJN-009DwT-Bg; Tue, 13 Dec 2022 01:42:25 +0000 Received: from mail-pf1-x430.google.com ([2607:f8b0:4864:20::430]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1p4uJJ-009DEv-9j for linux-riscv@lists.infradead.org; Tue, 13 Dec 2022 01:42:22 +0000 Received: by mail-pf1-x430.google.com with SMTP id c13so1199427pfp.5 for ; Mon, 12 Dec 2022 17:42:14 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20210112; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date:from:to :cc:subject:date:message-id:reply-to; bh=opT7QlxBkoYVHWKjfFWe+3FrtkzNsO2VihRNj3rgWn4=; b=SK1WTnhEcJ7vOVSL2xzzXtEkHtH43rxXSGW7Dtujo2q/jDMxxwle2K41T6LEOAbu31 njuyn58rLHAdSISg9P623gyKYXFOPbX7pgjYFQq0nCNnpQM5nUBslElHcKrZV00WUweD 2Ab6o7XW4eUWoa8IW7OXTpjK3c5JsXSeCBMBKd1ZVWft5A67PRSXDH8qkRexDCQaB9Yn RRx3hIYf+BW8rjptQ0hTe+UyiZNfb7Ry3StWfXGfsaNsXjMTMnyjPwgtlBcOWZ5bOvDK NYZEtjUykiKNojc+IPEX89P4N1KrKqPpyt3Z0lKnKRo6M5fuKnMpjzJMGm1TZAMuI+Yh G8/w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=opT7QlxBkoYVHWKjfFWe+3FrtkzNsO2VihRNj3rgWn4=; b=Hi0+s/qf8Attax9FVr1AXB+mTwxVlDk2+CuGMnWbWMA/B1yWJ+h/kNQr/dxh15nigY gAkkzCeawIH+0GseFaraBwH4ems2aMdridVp0jIpPwX9UmHuiz6fuLzGfxxTC2VbLoY5 h98y79COazaBPogQnfWQahDHDV6ms6jWyej83UVXJkk3jpqotayg9IXwnFiTlJdMU7uU ejiI3vLHZ6Zi6CHzqhy+1yfo1n77/19bGGE2S3FWZiz5NZfczH8UOzf5wlHTRNKLrMZP S7G2UnVBVuOOipEz/WmgeAMJrKe0OWMB3r5pZKGrkEPgIo7TjMeAbNfxGVMjWwWfNCRv hDeg== X-Gm-Message-State: ANoB5pnNSUtUXw1yPw55QPHMRQfL3aoYNy9eHwaeW9gQF9Rd5FulvJlK 51PsyKA6eHFfVjvrAkW8P1Ct2g== X-Google-Smtp-Source: AA0mqf4Ax5/VKVlxMD5DSzFDunN/IfJNpj08Gszf3tnTB/tljXojhITyTp9EJLu9yUUGsdwIrNP7Ng== X-Received: by 2002:a62:160a:0:b0:576:22d7:fd9e with SMTP id 10-20020a62160a000000b0057622d7fd9emr72299pfw.0.1670895734011; Mon, 12 Dec 2022 17:42:14 -0800 (PST) Received: from google.com (7.104.168.34.bc.googleusercontent.com. [34.168.104.7]) by smtp.gmail.com with ESMTPSA id i134-20020a62878c000000b005761c4754e7sm6630376pfe.144.2022.12.12.17.42.13 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 12 Dec 2022 17:42:13 -0800 (PST) Date: Tue, 13 Dec 2022 01:42:10 +0000 From: Sean Christopherson To: Paolo Bonzini Cc: David Matlack , Oliver Upton , "Yang, Weijiang" , Marc Zyngier , James Morse , Alexandru Elisei , Suzuki K Poulose , Huacai Chen , Aleksandar Markovic , Anup Patel , Atish Patra , Paul Walmsley , Palmer Dabbelt , Albert Ou , Andrew Morton , Anshuman Khandual , "Amit, Nadav" , "Matthew Wilcox (Oracle)" , Vlastimil Babka , "Liam R. Howlett" , Suren Baghdasaryan , Peter Xu , xu xin , Arnd Bergmann , Yu Zhao , Colin Cross , Hugh Dickins , Ben Gardon , Mingwei Zhang , Krish Sadhukhan , Ricardo Koller , Jing Zhang , "linux-arm-kernel@lists.infradead.org" , "kvmarm@lists.linux.dev" , "kvmarm@lists.cs.columbia.edu" , "linux-mips@vger.kernel.org" , "kvm@vger.kernel.org" , "kvm-riscv@lists.infradead.org" , "linux-riscv@lists.infradead.org" Subject: Re: [RFC PATCH 01/37] KVM: x86/mmu: Store the address space ID directly in kvm_mmu_page_role Message-ID: References: <20221208193857.4090582-1-dmatlack@google.com> <20221208193857.4090582-2-dmatlack@google.com> <22fe2332-497e-fe30-0155-e026b0eded97@intel.com> <01cb4882-7a06-176f-7d55-f80cca300ffd@redhat.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <01cb4882-7a06-176f-7d55-f80cca300ffd@redhat.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20221212_174221_365231_15033218 X-CRM114-Status: GOOD ( 16.23 ) X-BeenThere: linux-riscv@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-riscv" Errors-To: linux-riscv-bounces+linux-riscv=archiver.kernel.org@lists.infradead.org T24gTW9uLCBEZWMgMTIsIDIwMjIsIFBhb2xvIEJvbnppbmkgd3JvdGU6Cj4gT24gMTIvMTIvMjIg MTg6MzksIFNlYW4gQ2hyaXN0b3BoZXJzb24gd3JvdGU6Cj4gPiBNeSBwcmVmZXJlbmNlIHdvdWxk IGJlIHRvIGxlYXZlIC5zbW0gaW4geDg2J3MgcGFnZSByb2xlCj4gCj4gV2hhdCBhYm91dCBkZWZp bmluZyBhIGJ5dGUgb2YgYXJjaF9yb2xlIGFuZCBhIG1hY3JvIHRvIGJ1aWxkIGl0PwoKSSB0aGlu ayBEYXZpZCBhbHJlYWR5IGNhcnZlZCBvdXQgYSBiaWcgY2h1bmsgZm9yIGFyY2ggcm9sZSBiaXRz LCBteSBvYmplY3Rpb24Kd2FzIHB1cmVseSB0byBtYWtpbmcgYXNfaWQgYSBnZW5lcmljIDgtYml0 IHJvbGUuCgo+ID4gVW5sZXNzIEknbSBtaXNzaW5nIHNvbWV0aGluZywgZS5nLiBhIG5lZWQgdG8g bWFwIEdQQXMgZGlmZmVyZW50bHkgZm9yCj4gPiBTTU0gdnMuIG5vbi1TTU0sIFNNTSBjb3VsZCBo YXZlIGJlZW4gaW1wbGVtZW50ZWQgd2l0aCBhIHNpbXBsZSBmbGFnCj4gPiBpbiBhIG1lbXNsb3Qg dG8gbWFyayB0aGUgbWVtc2xvdCBhcyBTTU0tb25seS4KPiAKPiBVbmZvcnR1bmF0ZWx5IG5vdCwg YmVjYXVzZSB0aGVyZSBjYW4gYmUgYW5vdGhlciByZWdpb24gKGZvciBleGFtcGxlIHZpZGVvCj4g UkFNIGF0IDBBMDAwMGgpIHVuZGVybmVhdGggU01SQU0uCgpVZ2gsIGl0J3MgZXZlbiBhIHZlcnkg ZXhwbGljaXRseSBkb2N1bWVudGVkICJmZWF0dXJlIi4KCiAgV2hlbiBjb21wYXRpYmxlIFNNTSBz cGFjZSBpcyBlbmFibGVkLCBTTU0tbW9kZSBDQk8gYWNjZXNzZXMgdG8gdGhpcyByYW5nZSByb3V0 ZQogIHRvIHBoeXNpY2FsIHN5c3RlbSBEUkFNIGF0IDAwXzAwMEFfMGgg4oCTIDAwXzAwMEJfRkZG RmguCiAgCiAgTm9uLVNNTSBtb2RlIENCTyBhY2Nlc3NlcyB0byB0aGlzIHJhbmdlIGFyZSBjb25z aWRlcmVkIHRvIGJlIHRvIHRoZSBWaWRlbyBCdWZmZXIKICBBcmVhIGFzIGRlc2NyaWJlZCBhYm92 ZS4gUENJIEV4cHJlc3MqIGFuZCBETUkgb3JpZ2luYXRlZCBjeWNsZXMgdG8gU01NIHNwYWNlIGFy ZSBub3QKICBzdXBwb3J0ZWQgYW5kIGFyZSBjb25zaWRlcmVkIHRvIGJlIHRvIHRoZSBWaWRlbyBC dWZmZXIgQXJlYS4KCkkgYWxzbyBmb3Jnb3QgS1ZNIHN1cHBvcnRzIFNNQkFTRSByZWxvY2F0aW9u IDotKAoKPiBJbiBmYWN0LCBLVk1fTUVNX1g4Nl9TTVJBTSB3YXMgdGhlIGZpcnN0IGlkZWEuICBJ dCB3YXMgdWdsaWVyIHRoYW4gbXVsdGlwbGUKPiBhZGRyZXNzIHNwYWNlcyAoaHR0cHM6Ly9sb3Jl Lmtlcm5lbC5vcmcvbGttbC8xNDMxMDg0MDM0LTg0MjUtMS1naXQtc2VuZC1lbWFpbC1wYm9uemlu aUByZWRoYXQuY29tKS4KPiBJbiByZXRyb3NwZWN0IHRoZXJlIHdlcmUgcHJvYmFibHkgd2F5cyB0 byBtaXggdGhlIGJlc3Qgb2YgdGhlIHR3byBkZXNpZ25zLAo+IGJ1dCBpdCB3YXNuJ3QgZ2VuZXJp YyBlbm91Z2guCj4KPiA+IEFuZCBzZXBhcmF0ZSBhZGRyZXNzIHNwYWNlcyBiZWNvbWUgdHJ1bHkg bmFzdHkgaWYgdGhlIENQVSBjYW4gYWNjZXNzIG11bHRpcGxlCj4gPiBwcm90ZWN0ZWQgcmVnaW9u cywgZS5nLiBpZiB0aGUgQ1BVIGNhbiBhY2Nlc3MgdHlwZSBYIGFuZCB0eXBlIFkgYXQgdGhlIHNh bWUgdGltZSwKPiA+IHRoZW4gdGhlcmUgd291bGQgbmVlZCB0byBiZSBtZW1zbG90cyBmb3IgInJl Z3VsYXIiLCBYLCBZLCBhbmQgWCtZLgo+IAo+IFdpdGhvdXQgYSB1c2VjYXNlIHRoYXQncyBoYXJk IHRvIHNheS4gIEl0J3MganVzdCBhcyBwb3NzaWJsZSB0aGF0IHRoZXJlCj4gd291bGQgYmUgYSBu YXR1cmFsIGhpZXJhcmNoeSBvZiBsZXZlbHMuCgpBaCwgdHJ1ZS4KCl9fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fCmxpbnV4LXJpc2N2IG1haWxpbmcgbGlzdAps aW51eC1yaXNjdkBsaXN0cy5pbmZyYWRlYWQub3JnCmh0dHA6Ly9saXN0cy5pbmZyYWRlYWQub3Jn L21haWxtYW4vbGlzdGluZm8vbGludXgtcmlzY3YK From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 2ED72C4332F for ; Tue, 13 Dec 2022 01:43:53 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=qwB0y5d+MQ7tA46GN3E1EW0lCJT5vwMBPsBy03y6bCo=; b=G9Tb4OJMkef40Q D/fYyZuTJz0M2VMOVRyvxE71YDBYjDTgmKahQ5nEUJkrtoCUs5Ev1JIkrvRgYP8yURwcwzu9FHw7G /VnfmmlzckpzUU/hihxxDZz55uPYh3Jno2fOnQgJr2zi8rBFGFsHRJbQc6NmX14YIPQl721caPxzX /ye5VVZxPzS07Qc1cu24M6IzDxQIqkxyfzp81tlA6kFWu9lj5DZssE9gaTj5iT1XIOowa+qOrcZ6Q R1Z06A+ZK+TL0Dq18V6Cp9CPqrG5BLLbBUAMxFeSp3J908PqY0qzeaej8Q06slmoql7QuPhoPFRz0 0uxr0kz6YGvt3wiSGWaA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1p4uJP-009E6k-BI; Tue, 13 Dec 2022 01:42:27 +0000 Received: from mail-pf1-x42b.google.com ([2607:f8b0:4864:20::42b]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1p4uJJ-009DEa-CZ for linux-arm-kernel@lists.infradead.org; Tue, 13 Dec 2022 01:42:24 +0000 Received: by mail-pf1-x42b.google.com with SMTP id c7so1175352pfc.12 for ; Mon, 12 Dec 2022 17:42:14 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20210112; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date:from:to :cc:subject:date:message-id:reply-to; bh=opT7QlxBkoYVHWKjfFWe+3FrtkzNsO2VihRNj3rgWn4=; b=SK1WTnhEcJ7vOVSL2xzzXtEkHtH43rxXSGW7Dtujo2q/jDMxxwle2K41T6LEOAbu31 njuyn58rLHAdSISg9P623gyKYXFOPbX7pgjYFQq0nCNnpQM5nUBslElHcKrZV00WUweD 2Ab6o7XW4eUWoa8IW7OXTpjK3c5JsXSeCBMBKd1ZVWft5A67PRSXDH8qkRexDCQaB9Yn RRx3hIYf+BW8rjptQ0hTe+UyiZNfb7Ry3StWfXGfsaNsXjMTMnyjPwgtlBcOWZ5bOvDK NYZEtjUykiKNojc+IPEX89P4N1KrKqPpyt3Z0lKnKRo6M5fuKnMpjzJMGm1TZAMuI+Yh G8/w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=opT7QlxBkoYVHWKjfFWe+3FrtkzNsO2VihRNj3rgWn4=; b=1c7ezvrPaDGoC/2J4di+JPT2ykZKlOjcV5LCilRVjceMEspMAyVsX/Hq41Azfs/nbe ubz9tKHfaXH9ONQ4eW9w+Oeqvj3b1OvOJwyYTW+CGV6992MDu791Otr6tD3Vw0XfGTI1 eerfVIBZiJTEWigk+rTY8Z18K7wDSVPIU//lHe09W3opOTWAL4C6McmKuqPKVlnRCdop CTm9h3M/LZDSrnnT+aY3KZkahwtKkcWOmivYcwTN+GSZ0GDbwKiU7k+agIpCTSbYjMMG D8bZCfJ+pkjWGeiPGk5l09T9oEcj9ke+gIGel4/tdTHtGP2CzlPO8CL3xpnqogItEF1V 4juw== X-Gm-Message-State: ANoB5pn3PYw0ICBb0vdWYPV1G5DqD3k66fPMHzWHJaTvWPlA9hhftPx+ qKKH60qXh1cytaEO9zxnQ2opCA== X-Google-Smtp-Source: AA0mqf4Ax5/VKVlxMD5DSzFDunN/IfJNpj08Gszf3tnTB/tljXojhITyTp9EJLu9yUUGsdwIrNP7Ng== X-Received: by 2002:a62:160a:0:b0:576:22d7:fd9e with SMTP id 10-20020a62160a000000b0057622d7fd9emr72299pfw.0.1670895734011; Mon, 12 Dec 2022 17:42:14 -0800 (PST) Received: from google.com (7.104.168.34.bc.googleusercontent.com. [34.168.104.7]) by smtp.gmail.com with ESMTPSA id i134-20020a62878c000000b005761c4754e7sm6630376pfe.144.2022.12.12.17.42.13 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 12 Dec 2022 17:42:13 -0800 (PST) Date: Tue, 13 Dec 2022 01:42:10 +0000 From: Sean Christopherson To: Paolo Bonzini Cc: David Matlack , Oliver Upton , "Yang, Weijiang" , Marc Zyngier , James Morse , Alexandru Elisei , Suzuki K Poulose , Huacai Chen , Aleksandar Markovic , Anup Patel , Atish Patra , Paul Walmsley , Palmer Dabbelt , Albert Ou , Andrew Morton , Anshuman Khandual , "Amit, Nadav" , "Matthew Wilcox (Oracle)" , Vlastimil Babka , "Liam R. Howlett" , Suren Baghdasaryan , Peter Xu , xu xin , Arnd Bergmann , Yu Zhao , Colin Cross , Hugh Dickins , Ben Gardon , Mingwei Zhang , Krish Sadhukhan , Ricardo Koller , Jing Zhang , "linux-arm-kernel@lists.infradead.org" , "kvmarm@lists.linux.dev" , "kvmarm@lists.cs.columbia.edu" , "linux-mips@vger.kernel.org" , "kvm@vger.kernel.org" , "kvm-riscv@lists.infradead.org" , "linux-riscv@lists.infradead.org" Subject: Re: [RFC PATCH 01/37] KVM: x86/mmu: Store the address space ID directly in kvm_mmu_page_role Message-ID: References: <20221208193857.4090582-1-dmatlack@google.com> <20221208193857.4090582-2-dmatlack@google.com> <22fe2332-497e-fe30-0155-e026b0eded97@intel.com> <01cb4882-7a06-176f-7d55-f80cca300ffd@redhat.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <01cb4882-7a06-176f-7d55-f80cca300ffd@redhat.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20221212_174221_455693_6B0272A1 X-CRM114-Status: GOOD ( 17.91 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org T24gTW9uLCBEZWMgMTIsIDIwMjIsIFBhb2xvIEJvbnppbmkgd3JvdGU6Cj4gT24gMTIvMTIvMjIg MTg6MzksIFNlYW4gQ2hyaXN0b3BoZXJzb24gd3JvdGU6Cj4gPiBNeSBwcmVmZXJlbmNlIHdvdWxk IGJlIHRvIGxlYXZlIC5zbW0gaW4geDg2J3MgcGFnZSByb2xlCj4gCj4gV2hhdCBhYm91dCBkZWZp bmluZyBhIGJ5dGUgb2YgYXJjaF9yb2xlIGFuZCBhIG1hY3JvIHRvIGJ1aWxkIGl0PwoKSSB0aGlu ayBEYXZpZCBhbHJlYWR5IGNhcnZlZCBvdXQgYSBiaWcgY2h1bmsgZm9yIGFyY2ggcm9sZSBiaXRz LCBteSBvYmplY3Rpb24Kd2FzIHB1cmVseSB0byBtYWtpbmcgYXNfaWQgYSBnZW5lcmljIDgtYml0 IHJvbGUuCgo+ID4gVW5sZXNzIEknbSBtaXNzaW5nIHNvbWV0aGluZywgZS5nLiBhIG5lZWQgdG8g bWFwIEdQQXMgZGlmZmVyZW50bHkgZm9yCj4gPiBTTU0gdnMuIG5vbi1TTU0sIFNNTSBjb3VsZCBo YXZlIGJlZW4gaW1wbGVtZW50ZWQgd2l0aCBhIHNpbXBsZSBmbGFnCj4gPiBpbiBhIG1lbXNsb3Qg dG8gbWFyayB0aGUgbWVtc2xvdCBhcyBTTU0tb25seS4KPiAKPiBVbmZvcnR1bmF0ZWx5IG5vdCwg YmVjYXVzZSB0aGVyZSBjYW4gYmUgYW5vdGhlciByZWdpb24gKGZvciBleGFtcGxlIHZpZGVvCj4g UkFNIGF0IDBBMDAwMGgpIHVuZGVybmVhdGggU01SQU0uCgpVZ2gsIGl0J3MgZXZlbiBhIHZlcnkg ZXhwbGljaXRseSBkb2N1bWVudGVkICJmZWF0dXJlIi4KCiAgV2hlbiBjb21wYXRpYmxlIFNNTSBz cGFjZSBpcyBlbmFibGVkLCBTTU0tbW9kZSBDQk8gYWNjZXNzZXMgdG8gdGhpcyByYW5nZSByb3V0 ZQogIHRvIHBoeXNpY2FsIHN5c3RlbSBEUkFNIGF0IDAwXzAwMEFfMGgg4oCTIDAwXzAwMEJfRkZG RmguCiAgCiAgTm9uLVNNTSBtb2RlIENCTyBhY2Nlc3NlcyB0byB0aGlzIHJhbmdlIGFyZSBjb25z aWRlcmVkIHRvIGJlIHRvIHRoZSBWaWRlbyBCdWZmZXIKICBBcmVhIGFzIGRlc2NyaWJlZCBhYm92 ZS4gUENJIEV4cHJlc3MqIGFuZCBETUkgb3JpZ2luYXRlZCBjeWNsZXMgdG8gU01NIHNwYWNlIGFy ZSBub3QKICBzdXBwb3J0ZWQgYW5kIGFyZSBjb25zaWRlcmVkIHRvIGJlIHRvIHRoZSBWaWRlbyBC dWZmZXIgQXJlYS4KCkkgYWxzbyBmb3Jnb3QgS1ZNIHN1cHBvcnRzIFNNQkFTRSByZWxvY2F0aW9u IDotKAoKPiBJbiBmYWN0LCBLVk1fTUVNX1g4Nl9TTVJBTSB3YXMgdGhlIGZpcnN0IGlkZWEuICBJ dCB3YXMgdWdsaWVyIHRoYW4gbXVsdGlwbGUKPiBhZGRyZXNzIHNwYWNlcyAoaHR0cHM6Ly9sb3Jl Lmtlcm5lbC5vcmcvbGttbC8xNDMxMDg0MDM0LTg0MjUtMS1naXQtc2VuZC1lbWFpbC1wYm9uemlu aUByZWRoYXQuY29tKS4KPiBJbiByZXRyb3NwZWN0IHRoZXJlIHdlcmUgcHJvYmFibHkgd2F5cyB0 byBtaXggdGhlIGJlc3Qgb2YgdGhlIHR3byBkZXNpZ25zLAo+IGJ1dCBpdCB3YXNuJ3QgZ2VuZXJp YyBlbm91Z2guCj4KPiA+IEFuZCBzZXBhcmF0ZSBhZGRyZXNzIHNwYWNlcyBiZWNvbWUgdHJ1bHkg bmFzdHkgaWYgdGhlIENQVSBjYW4gYWNjZXNzIG11bHRpcGxlCj4gPiBwcm90ZWN0ZWQgcmVnaW9u cywgZS5nLiBpZiB0aGUgQ1BVIGNhbiBhY2Nlc3MgdHlwZSBYIGFuZCB0eXBlIFkgYXQgdGhlIHNh bWUgdGltZSwKPiA+IHRoZW4gdGhlcmUgd291bGQgbmVlZCB0byBiZSBtZW1zbG90cyBmb3IgInJl Z3VsYXIiLCBYLCBZLCBhbmQgWCtZLgo+IAo+IFdpdGhvdXQgYSB1c2VjYXNlIHRoYXQncyBoYXJk IHRvIHNheS4gIEl0J3MganVzdCBhcyBwb3NzaWJsZSB0aGF0IHRoZXJlCj4gd291bGQgYmUgYSBu YXR1cmFsIGhpZXJhcmNoeSBvZiBsZXZlbHMuCgpBaCwgdHJ1ZS4KCl9fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fCmxpbnV4LWFybS1rZXJuZWwgbWFpbGluZyBs aXN0CmxpbnV4LWFybS1rZXJuZWxAbGlzdHMuaW5mcmFkZWFkLm9yZwpodHRwOi8vbGlzdHMuaW5m cmFkZWFkLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2xpbnV4LWFybS1rZXJuZWwK