From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.sourceforge.net (lists.sourceforge.net [216.105.38.7]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id C2E17C4332F for ; Tue, 13 Dec 2022 19:11:19 +0000 (UTC) Received: from [127.0.0.1] (helo=sfs-ml-4.v29.lw.sourceforge.com) by sfs-ml-4.v29.lw.sourceforge.com with esmtp (Exim 4.95) (envelope-from ) id 1p5AgQ-0004G4-2h; Tue, 13 Dec 2022 19:11:18 +0000 Received: from [172.30.20.202] (helo=mx.sourceforge.net) by sfs-ml-4.v29.lw.sourceforge.com with esmtps (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.95) (envelope-from ) id 1p5AgP-0004Fy-7o for linux-f2fs-devel@lists.sourceforge.net; Tue, 13 Dec 2022 19:11:17 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sourceforge.net; s=x; h=In-Reply-To:Content-Type:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=3w72/8K2CauCfvYEcYmQl8MJZ0gtvghHUWYDFYbGCvA=; b=ErZc6888PEnT5irMCcBpyb0L7h KxbiQF6PQX1b4eRq8+SfZ04Kl16TWAtG+g7yEb8wO/IsAL7pugBxFJuduqw7CuDSExeiIv01eKCaC 2Te4IJTXNtYaMHj7qnBA538N50qLgeKU5u1GmRc+gAXJdcu53S/CBMODWcxTPuoraJIo=; DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sf.net; s=x ; h=In-Reply-To:Content-Type:MIME-Version:References:Message-ID:Subject:Cc:To :From:Date:Sender:Reply-To:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=3w72/8K2CauCfvYEcYmQl8MJZ0gtvghHUWYDFYbGCvA=; b=nDdvlomO0FGO4xQsfrrD4la+gq lQZ1AfBQfDMO9vrKHHDj/7HiJG/rSXPpz+dJbUP5zPQnQnWViBbuH0ts1BFmuvBY2xnhgusZO0Ece uHz/PknkUMKLynIqPDaoCEacgZjBw1kdbpQD6tGsh8ylx8LDPpFUh9lkST7gjGcQh6yE=; Received: from dfw.source.kernel.org ([139.178.84.217]) by sfi-mx-1.v28.lw.sourceforge.com with esmtps (TLS1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.95) id 1p5AgO-00GB4q-LX for linux-f2fs-devel@lists.sourceforge.net; Tue, 13 Dec 2022 19:11:17 +0000 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 443A5616F4; Tue, 13 Dec 2022 19:11:11 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 7FBCDC433D2; Tue, 13 Dec 2022 19:11:10 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1670958670; bh=/VeZtsI4jZz7Y++Dl+hs6w4K2j0s34Gujm/rr1i5/0Y=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=CwexaBGc4Uanr5oZfvr1a+liupkMwiLS8HTgnuvrJMxuRL8N7fHajOG3D9jOVdMSE 0T8M4szF7ZcMocoKrz8KSmbxFRM2XL7Uwhr9tCjXWqZAPK7Jbsz2aQbdwh0f94Bb+7 GGN5Hf9EsJzWP0NEIvcEtYph2rPdgy83eljNcCwUbPt+8GYnF6GDsNUiKjCS9iyoKg NxNDDeYY2gZN8tP9ZgY1ONKPwn2P3Y1l72BeWNthnYYMVFJXTQwAOOaHJJIfkkvcrZ +VFIjTAOD3SA3GuX/lur1fXMmFXRSjcFc0yFq34yQrZS0g3qc/ZRTiWgswSYEAk8/q t1FnCE5y4q6yg== Date: Tue, 13 Dec 2022 11:11:08 -0800 From: Jaegeuk Kim To: Yangtao Li Message-ID: References: <20221213115454.14885-1-frank.li@vivo.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20221213115454.14885-1-frank.li@vivo.com> X-Headers-End: 1p5AgO-00GB4q-LX Subject: Re: [f2fs-dev] [PATCH] f2fs: fix iostat parameter for discard X-BeenThere: linux-f2fs-devel@lists.sourceforge.net X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: linux-kernel@vger.kernel.org, linux-f2fs-devel@lists.sourceforge.net Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: linux-f2fs-devel-bounces@lists.sourceforge.net On 12/13, Yangtao Li wrote: > > What do you think of extending this function to support io_counts? > > > > void f2fs_update_iostat(struct f2fs_sb_info *sbi, struct inode *inode, > > enum iostat_type type, unsigned long long io_bytes, > > unsigned long long io_counts) > > Support to have extra io_count. > > But I don't think there is any need to add additional parameters to f2fs_update_iostat. > IIUC, each call to f2fs_update_iostat means that the corresponding count increases by 1, > so only the internal processing of the function is required. > > BTW, let's type out the iocount of the additional record in the following way? > > time: 1670930162 > [WRITE] > app buffered data: 4096(1) How about giving in another columns with additional stats like avg. len/call or max. len? app buffered data: 4096 1 > > Thx, > Yangtao _______________________________________________ Linux-f2fs-devel mailing list Linux-f2fs-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id B9743C4332F for ; Tue, 13 Dec 2022 19:12:34 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S236707AbiLMTMc (ORCPT ); Tue, 13 Dec 2022 14:12:32 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:55928 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S236710AbiLMTLs (ORCPT ); Tue, 13 Dec 2022 14:11:48 -0500 Received: from ams.source.kernel.org (ams.source.kernel.org [IPv6:2604:1380:4601:e00::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 42A14220E4 for ; Tue, 13 Dec 2022 11:11:13 -0800 (PST) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id E7F4AB815BB for ; Tue, 13 Dec 2022 19:11:11 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 7FBCDC433D2; Tue, 13 Dec 2022 19:11:10 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1670958670; bh=/VeZtsI4jZz7Y++Dl+hs6w4K2j0s34Gujm/rr1i5/0Y=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=CwexaBGc4Uanr5oZfvr1a+liupkMwiLS8HTgnuvrJMxuRL8N7fHajOG3D9jOVdMSE 0T8M4szF7ZcMocoKrz8KSmbxFRM2XL7Uwhr9tCjXWqZAPK7Jbsz2aQbdwh0f94Bb+7 GGN5Hf9EsJzWP0NEIvcEtYph2rPdgy83eljNcCwUbPt+8GYnF6GDsNUiKjCS9iyoKg NxNDDeYY2gZN8tP9ZgY1ONKPwn2P3Y1l72BeWNthnYYMVFJXTQwAOOaHJJIfkkvcrZ +VFIjTAOD3SA3GuX/lur1fXMmFXRSjcFc0yFq34yQrZS0g3qc/ZRTiWgswSYEAk8/q t1FnCE5y4q6yg== Date: Tue, 13 Dec 2022 11:11:08 -0800 From: Jaegeuk Kim To: Yangtao Li Cc: chao@kernel.org, linux-f2fs-devel@lists.sourceforge.net, linux-kernel@vger.kernel.org Subject: Re: [PATCH] f2fs: fix iostat parameter for discard Message-ID: References: <20221213115454.14885-1-frank.li@vivo.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20221213115454.14885-1-frank.li@vivo.com> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 12/13, Yangtao Li wrote: > > What do you think of extending this function to support io_counts? > > > > void f2fs_update_iostat(struct f2fs_sb_info *sbi, struct inode *inode, > > enum iostat_type type, unsigned long long io_bytes, > > unsigned long long io_counts) > > Support to have extra io_count. > > But I don't think there is any need to add additional parameters to f2fs_update_iostat. > IIUC, each call to f2fs_update_iostat means that the corresponding count increases by 1, > so only the internal processing of the function is required. > > BTW, let's type out the iocount of the additional record in the following way? > > time: 1670930162 > [WRITE] > app buffered data: 4096(1) How about giving in another columns with additional stats like avg. len/call or max. len? app buffered data: 4096 1 > > Thx, > Yangtao