All of lore.kernel.org
 help / color / mirror / Atom feed
From: Brian Masney <bmasney@redhat.com>
To: Shazad Hussain <quic_shazhuss@quicinc.com>
Cc: Konrad Dybcio <konrad.dybcio@linaro.org>,
	andersson@kernel.org, krzysztof.kozlowski+dt@linaro.org,
	robh+dt@kernel.org, johan+linaro@kernel.org,
	linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org,
	linux-kernel@vger.kernel.org, ahalaney@redhat.com,
	echanude@redhat.com
Subject: Re: [PATCH 3/4] arm64: dts: qcom: sa8540p-ride: add qup1_i2c15 and qup2_i2c18 nodes
Date: Wed, 14 Dec 2022 11:24:32 -0500	[thread overview]
Message-ID: <Y5n4wFqhCdMz5bey@x1> (raw)
In-Reply-To: <6ab9171e-127b-12f3-cfe6-0fbf2b37080c@quicinc.com>

On Wed, Dec 14, 2022 at 09:06:48PM +0530, Shazad Hussain wrote:
> >      i2c0_default: i2c0-default-state {
> >          pins = "gpio135", "gpio136";
> >          function = "qup15";
> >          drive-strength = <2>;
> >          bias-pull-up;
> >      };
> > 
> 
> This is the default config we should use.

OK, I'll stick with this config.

> > Shazad: 'i2cdetect -a -y $BUSNUM) shows that all 5 buses have the same
> > addresses listening. Is that expected? That seems a bit odd to me.
> > 
> 
> Brian, even I haven't checked with all enabled, let me check this on other
> projects and with downstream as well and get back to you.

I'll post my v2 in a little bit so that you can test it.

Brian


  reply	other threads:[~2022-12-14 16:25 UTC|newest]

Thread overview: 40+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-12-12 18:23 [PATCH 0/4] arm64: dts: qcom: sc8280xp: add i2c and spi nodes Brian Masney
2022-12-12 18:23 ` [PATCH 1/4] arm64: dts: qcom: sc8280xp: rename i2c5 to i2c21 Brian Masney
2022-12-12 18:48   ` Konrad Dybcio
2022-12-13 14:54   ` Johan Hovold
2022-12-13 15:04     ` Shazad Hussain
2022-12-13 15:19       ` Johan Hovold
2022-12-13 15:05     ` Brian Masney
2022-12-13 15:12     ` Brian Masney
2022-12-13 15:28       ` Johan Hovold
2022-12-13 15:34         ` Shazad Hussain
2022-12-13 15:39           ` Johan Hovold
2022-12-13 15:42             ` Johan Hovold
2022-12-13 15:44               ` Konrad Dybcio
2022-12-13 16:15                 ` Johan Hovold
2022-12-13 15:45             ` Shazad Hussain
2022-12-13 15:17     ` Johan Hovold
2022-12-13 15:29       ` Konrad Dybcio
2022-12-13 15:32         ` Johan Hovold
2022-12-13 15:59           ` Brian Masney
2022-12-13 16:22             ` Johan Hovold
2022-12-12 18:23 ` [PATCH 2/4] arm64: dts: qcom: sc8280xp: add missing i2c nodes Brian Masney
2022-12-12 18:23 ` [PATCH 3/4] arm64: dts: qcom: sa8540p-ride: add qup1_i2c15 and qup2_i2c18 nodes Brian Masney
2022-12-13  7:18   ` Shazad Hussain
2022-12-13 14:48   ` Konrad Dybcio
2022-12-14 12:30     ` Brian Masney
2022-12-14 12:52       ` Krzysztof Kozlowski
2022-12-14 14:19         ` Brian Masney
2022-12-14 12:53       ` Konrad Dybcio
2022-12-14 15:36       ` Shazad Hussain
2022-12-14 16:24         ` Brian Masney [this message]
2022-12-13 14:59   ` Johan Hovold
2022-12-14 12:51   ` Krzysztof Kozlowski
2022-12-12 18:23 ` [PATCH 4/4] arm64: dts: qcom: sc8280xp: add missing spi nodes Brian Masney
2022-12-13  7:16   ` Shazad Hussain
2022-12-13 12:27     ` Brian Masney
2022-12-13 12:47       ` Mark Brown
2022-12-13 13:02       ` Krzysztof Kozlowski
2022-12-13 13:08         ` Javier Martinez Canillas
2022-12-13 14:36           ` Brian Masney
2022-12-13 14:45             ` Shazad Hussain

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=Y5n4wFqhCdMz5bey@x1 \
    --to=bmasney@redhat.com \
    --cc=ahalaney@redhat.com \
    --cc=andersson@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=echanude@redhat.com \
    --cc=johan+linaro@kernel.org \
    --cc=konrad.dybcio@linaro.org \
    --cc=krzysztof.kozlowski+dt@linaro.org \
    --cc=linux-arm-msm@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=quic_shazhuss@quicinc.com \
    --cc=robh+dt@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.