From: "Jason A. Donenfeld" <Jason@zx2c4.com>
To: Geert Uytterhoeven <geert@linux-m68k.org>
Cc: linux-m68k@lists.linux-m68k.org, linux-arch@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] m68k: string: Make char intermediate in strcmp() signed
Date: Thu, 15 Dec 2022 11:43:28 -0700 [thread overview]
Message-ID: <Y5tq0OSjTvADFnEZ@zx2c4.com> (raw)
In-Reply-To: <bce014e60d7b1a3d1c60009fc3572e2f72591f21.1671110959.git.geert@linux-m68k.org>
On Thu, Dec 15, 2022 at 02:30:04PM +0100, Geert Uytterhoeven wrote:
> Since char became unsigned, strcmp() always returns a positive number.
>
> "res" is used to store a byte difference, so it should be signed.
>
> Fixes: 3bc753c06dd02a35 ("kbuild: treat char as always unsigned")
> Signed-off-by: Geert Uytterhoeven <geert@linux-m68k.org>
> ---
> See "Re: [PATCH v9] kallsyms: Add self-test facility"
> https://lore.kernel.org/r/CAMuHMdWM6+pC3yUqy+hHRrAf1BCz2sz1KQv2zxS+Wz-639X-aA@mail.gmail.com
>
> I'm wondering how many surprises like this are still hidden...
OOOOOOOOOOFFFFF! Not sure how I missed this one. Perhaps the ASM alluded
the coccinelle scripts. Anyway, thanks for catching it, sorry for the
bug, and here's my:
Reviewed-by: Jason A. Donenfeld <Jason@zx2c4.com>
I assume you'll send this out for the next tranche of m68k fixes.
Jason
prev parent reply other threads:[~2022-12-15 18:43 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-12-15 13:30 [PATCH] m68k: string: Make char intermediate in strcmp() signed Geert Uytterhoeven
2022-12-15 18:43 ` Jason A. Donenfeld [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Y5tq0OSjTvADFnEZ@zx2c4.com \
--to=jason@zx2c4.com \
--cc=geert@linux-m68k.org \
--cc=linux-arch@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-m68k@lists.linux-m68k.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.