All of lore.kernel.org
 help / color / mirror / Atom feed
From: Uladzislau Rezki <urezki@gmail.com>
To: "Paul E. McKenney" <paulmck@kernel.org>
Cc: "Uladzislau Rezki (Sony)" <urezki@gmail.com>,
	LKML <linux-kernel@vger.kernel.org>, RCU <rcu@vger.kernel.org>,
	Frederic Weisbecker <frederic@kernel.org>,
	Neeraj Upadhyay <neeraj.iitr10@gmail.com>,
	Joel Fernandes <joel@joelfernandes.org>,
	Oleksiy Avramchenko <oleksiy.avramchenko@sony.com>
Subject: Re: [PATCH 1/2] rcu/kvfree: Carefully reset number of objects in krcp
Date: Thu, 15 Dec 2022 22:16:15 +0100	[thread overview]
Message-ID: <Y5uOnzBA7D30VUQY@pc636> (raw)
In-Reply-To: <20221215204022.GN4001@paulmck-ThinkPad-P17-Gen-1>

On Thu, Dec 15, 2022 at 12:40:22PM -0800, Paul E. McKenney wrote:
> On Wed, Dec 14, 2022 at 01:06:29PM +0100, Uladzislau Rezki (Sony) wrote:
> > Problem. A schedule_delayed_monitor_work() relays on the
> > number of pointers queued into krcp. Based on that number
> > and threshold the work is rearmed with different delayed
> > intervals, i.e. sooner or later.
> > 
> > There are three pipes where pointers can be placed. When
> > any pipe is offloaded the krcp->count counter is set to
> > zero - what is wrong. Because another pipes might not be
> > empty.
> > 
> > Fix it by maintaining a counter individually per a pipe.
> > In order to get a number of objects per a krcp introduce
> > a krc_count() helper.
> > 
> > Signed-off-by: Uladzislau Rezki (Sony) <urezki@gmail.com>
> 
> Queued and pushed for further review and testing, and with the usual
> wordsmithing.  Much better use of workqueue handlers, thank you!!!
> 
<snip>
   This commit therefore maintains per-pipe counters, and introduces a a
   krc_count() helper to access the aggregate value of those
   counters.
<snip>

a a ? :)

--
Uladzislau Rezki

  reply	other threads:[~2022-12-15 21:16 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-12-14 12:06 [PATCH 1/2] rcu/kvfree: Carefully reset number of objects in krcp Uladzislau Rezki (Sony)
2022-12-14 12:06 ` [PATCH 2/2] rcu/kvfree: Split ready for reclaim objects from a batch Uladzislau Rezki (Sony)
2022-12-15 20:40 ` [PATCH 1/2] rcu/kvfree: Carefully reset number of objects in krcp Paul E. McKenney
2022-12-15 21:16   ` Uladzislau Rezki [this message]
2022-12-15 21:33     ` Paul E. McKenney

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=Y5uOnzBA7D30VUQY@pc636 \
    --to=urezki@gmail.com \
    --cc=frederic@kernel.org \
    --cc=joel@joelfernandes.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=neeraj.iitr10@gmail.com \
    --cc=oleksiy.avramchenko@sony.com \
    --cc=paulmck@kernel.org \
    --cc=rcu@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.