Re: [PATCH 1/2] cxl/region: Fix memdev_filter_pos() memory leak

[Alison Schofield <alison.schofield@intel.com>]

On Wed, Dec 14, 2022 at 05:33:52PM -0800, Dan Williams wrote:
> Arrange to free the temporary duplicate of @_csv in all exit paths. Just
> share a common exit path.
> 

Reviewed-by: Alison Schofield <alison.schofield@intel.com>

> Signed-off-by: Dan Williams <dan.j.williams@intel.com>
> ---
>  cxl/region.c |    2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/cxl/region.c b/cxl/region.c
> index 15cac64a158c..2202afa440ef 100644
> --- a/cxl/region.c
> +++ b/cxl/region.c
> @@ -183,7 +183,7 @@ static int memdev_filter_pos(struct json_object *jobj, const char *_csv)
>  	for (pos = 0, arg = strtok_r(csv, which_sep(csv), &save); arg;
>  	     arg = strtok_r(NULL, which_sep(csv), &save), pos++)
>  		if (util_cxl_memdev_filter(memdev, arg, NULL))
> -			return pos;
> +			break;
>  	free(csv);
>  
>  	return pos;
>