All of lore.kernel.org
 help / color / mirror / Atom feed
From: Petr Vorel <pvorel@suse.cz>
To: Avinesh Kumar <akumar@suse.de>
Cc: Richard Palethorpe <rpalethorpe@suse.com>, ltp@lists.linux.it
Subject: Re: [LTP] [PATCH v4] statvfs01: Convert to new LTP API
Date: Fri, 16 Dec 2022 11:18:16 +0100	[thread overview]
Message-ID: <Y5xF6PU5Yvh+oku5@pevik> (raw)
In-Reply-To: <87zgc2t9ga.fsf@suse.de>

Hi Avinesh,

> > +	fs_type = tst_fs_type(TEST_PATH);
> > +	if (fs_type != TST_VFAT_MAGIC && fs_type != TST_EXFAT_MAGIC)
> > +		TST_EXP_FD(creat(valid_fname, 0444));

> I suppose, thanks to Petr, we now know using a unicode character will
> allow you to construct a valid name of the maximum length.

Yes, Avinesh would you mind to add valid testing also for vfat and exfat?

Something like this?

#define NLS_MAX_CHARSET_SIZE 6 /* from include/linux/nls.h */

if (fs_type == TST_VFAT_MAGIC && fs_type == TST_EXFAT_MAGIC)
	memset(valid_fname, 'a', buf.f_namemax / NLS_MAX_CHARSET_SIZE); // should be (f_namelen / 6) + 1
else
	memset(valid_fname, 'a', buf.f_namemax - 1);

Kind regards,
Petr

[1] https://lore.kernel.org/ltp/Y4nDWW2ur6KA1kIw@pevik/

-- 
Mailing list info: https://lists.linux.it/listinfo/ltp

  reply	other threads:[~2022-12-16 10:18 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-12-01  8:43 [LTP] [PATCH v3] statvfs01: Convert to new LTP API Avinesh Kumar
2022-12-01 11:11 ` [LTP] [PATCH v4] " Avinesh Kumar
2022-12-05 10:38   ` Richard Palethorpe
2022-12-16 10:18     ` Petr Vorel [this message]
2022-12-20  7:57       ` [LTP] [PATCH v5] " Avinesh Kumar
2022-12-20 12:07         ` Richard Palethorpe
2022-12-22  9:49           ` Petr Vorel
2022-12-22  9:53             ` Richard Palethorpe
2022-12-23 14:40               ` Avinesh Kumar

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=Y5xF6PU5Yvh+oku5@pevik \
    --to=pvorel@suse.cz \
    --cc=akumar@suse.de \
    --cc=ltp@lists.linux.it \
    --cc=rpalethorpe@suse.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.