From mboxrd@z Thu Jan 1 00:00:00 1970 Received: by 2002:a17:906:a84b:b0:7c1:2a22:dc39 with SMTP id dx11csp1291114ejb; Fri, 16 Dec 2022 03:14:50 -0800 (PST) X-Google-Smtp-Source: AA0mqf41G7TIm0+8Kpoif74MzZtOAMZYoHnjeE30R2ml4U5ifREag6SkGGKJbVta7u9u5GUaRxHi X-Received: by 2002:a05:6214:930:b0:4c7:2804:d697 with SMTP id dk16-20020a056214093000b004c72804d697mr40137795qvb.19.1671189290497; Fri, 16 Dec 2022 03:14:50 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1671189290; cv=none; d=google.com; s=arc-20160816; b=HDxQB6LbYdfFd1xd4i7CLs1Xvp0o6skH6gN3kg7o5FLpa9RNDcUzTOrRSSfMvCoI3F Xju4lT48uyHwKUP8Qpvqo9sHLiG62ohByNa/ZzOZl3++5EVU+lY/2g0iUr4lTLmxFErN 2syHfBpJjNWroKhXdlBBDtzadNTE/emzCJ8gUArIQI6k06Ix++2dP8SD72+lT6IekRsW ieM9Pb0ixJWkoR3cYz6GAZVZC9/JKC+OCXHDi1TPO5+s0XGdPKue7RVJcbZjCyfJoGmd rP31HPy2PvPruNsQq/YoyaYg/VQyzXkbBqs6I9DI95JQXlIIlz4ilZ9acy+hjiFJ7+fD HjuQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:list-subscribe:list-help:list-post:list-archive :list-unsubscribe:list-id:precedence:in-reply-to :content-transfer-encoding:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=RbTOovQUdfGt9U9QZ4ZgQdSPz1KkfxzdXiNrkIEZJ18=; b=ojHyK6TkxouGNxGhIXgG+Q1RTR4uQvNH8vwkvG9AKdwxqVAH1ZfgO2bC+BFWDKucfg Wu2HvO6uAd2OOWfZx4ZFHlMJRgHmuEG2NqZ6XGt+0IqByVH130rudQezs3lZBS80n5Wp +5zwWCnJDch/JFaV/tBC4VuUnbnSQ6cxdtDlERGFbDTMivXZYsSikIP67dRBrnl3ysuZ Em2BJ3DZbkDBAIG5GoHYqPQIKdtXkyyhjPrxSn3SxA3Ye/xnPa+Z//iH4Z9ppP7QvjND NH+VQDDXoYp5u5oJEEhijNeOAkoLS+JSqdhaOVunPdbtXEJMTyxekYTvwXUAtda7z5Xs QoHA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=UK7uBU3u; spf=pass (google.com: domain of qemu-devel-bounces+alex.bennee=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+alex.bennee=linaro.org@nongnu.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Return-Path: Received: from lists.gnu.org (lists.gnu.org. [209.51.188.17]) by mx.google.com with ESMTPS id m11-20020a0562141bcb00b004b90fe5f7a3si993501qvc.489.2022.12.16.03.14.50 for (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Fri, 16 Dec 2022 03:14:50 -0800 (PST) Received-SPF: pass (google.com: domain of qemu-devel-bounces+alex.bennee=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; Authentication-Results: mx.google.com; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=UK7uBU3u; spf=pass (google.com: domain of qemu-devel-bounces+alex.bennee=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+alex.bennee=linaro.org@nongnu.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1p68f5-0007jv-4f; Fri, 16 Dec 2022 06:13:55 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1p68f3-0007jl-Ub for qemu-devel@nongnu.org; Fri, 16 Dec 2022 06:13:53 -0500 Received: from us-smtp-delivery-124.mimecast.com ([170.10.129.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1p68f2-0003Hi-DO for qemu-devel@nongnu.org; Fri, 16 Dec 2022 06:13:53 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1671189230; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=RbTOovQUdfGt9U9QZ4ZgQdSPz1KkfxzdXiNrkIEZJ18=; b=UK7uBU3u8BQfSmO9H+xIlYhXaKOBl1YBBT4ELJEdlTnlgp7EIktDeGpotQ7VDFtTGcDgZV 3fLz0slhZTsUFaZXQZIslLDY8Psgy33ojTJLT3FksdSQun6bN6YxSzAZ0XG8o/TpuH/4Uy SbAqDW3IFIqEFoVlBRfEgsiYZn24vmI= Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-161-rMcfay-AOuSG6T-_dFt6_g-1; Fri, 16 Dec 2022 06:13:49 -0500 X-MC-Unique: rMcfay-AOuSG6T-_dFt6_g-1 Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.rdu2.redhat.com [10.11.54.4]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 04C5780D101; Fri, 16 Dec 2022 11:13:49 +0000 (UTC) Received: from pinwheel (unknown [10.39.194.166]) by smtp.corp.redhat.com (Postfix) with ESMTPS id D1DBD2026D35; Fri, 16 Dec 2022 11:13:47 +0000 (UTC) Date: Fri, 16 Dec 2022 12:13:45 +0100 From: Kashyap Chamarthy To: Gerd Hoffmann Cc: qemu-devel@nongnu.org, qemu-arm@nongnu.org, Philippe =?iso-8859-1?Q?Mathieu-Daud=E9?= , Daniel =?iso-8859-1?Q?P=2E_Berrang=E9?= , Peter Maydell Subject: Re: [PATCH 2/2] docs: add no-padding firmware feature Message-ID: References: <20221216101234.2202009-1-kraxel@redhat.com> <20221216101234.2202009-3-kraxel@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20221216101234.2202009-3-kraxel@redhat.com> X-Scanned-By: MIMEDefang 3.1 on 10.11.54.4 Received-SPF: pass client-ip=170.10.129.124; envelope-from=kchamart@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+alex.bennee=linaro.org@nongnu.org Sender: qemu-devel-bounces+alex.bennee=linaro.org@nongnu.org X-TUID: +3Kh0I+4hSNM On Fri, Dec 16, 2022 at 11:12:34AM +0100, Gerd Hoffmann wrote: Hi, > Signed-off-by: Gerd Hoffmann > --- > docs/interop/firmware.json | 5 ++++- > 1 file changed, 4 insertions(+), 1 deletion(-) > > diff --git a/docs/interop/firmware.json b/docs/interop/firmware.json > index 56814f02b3c0..74f404d745b0 100644 > --- a/docs/interop/firmware.json > +++ b/docs/interop/firmware.json > @@ -191,6 +191,8 @@ > # PL011 UART. @verbose-static is mutually exclusive > # with @verbose-dynamic. > # > +# @no-padding: The (arm/aarch64) firmware images are not padded to 64M. > +# > # Since: 3.0 > ## > { 'enum' : 'FirmwareFeature', > @@ -198,7 +200,8 @@ > 'amd-sev', 'amd-sev-es', 'amd-sev-snp', > 'intel-tdx', > 'enrolled-keys', 'requires-smm', 'secure-boot', > - 'verbose-dynamic', 'verbose-static' ] } > + 'verbose-dynamic', 'verbose-static', > + 'no-padding' ] } If you're re-spinning, please consider adding a sentence or two (for those of us who're not familiar) a bit more about the "no-padding" feature to the commit message. IIUC, I found the use of the padding feature reading an old email response[1] from Dan Berrangé: (quote) ... If there's a risk that newer firmware will be larger than old firmware there's only really two options: - Keep all firmware images forever, each with a unique versioned filename. This ensures target QEMU will always load the original smaller firmware - Add padding to the firmware images. IOW, if the firmware is 2 MB, add zero-padding to the end of the image to round it upto 4 MB (whatever you anticipate the largest size wil be in future). ... (/quote) [1] https://edk2.groups.io/g/devel/message/54758 Regardless: Reviewed-by: Kashyap Chamarthy > ## > # @FirmwareFlashFile: > -- > 2.38.1 > -- /kashyap