From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 4B4CFC001B2 for ; Fri, 16 Dec 2022 12:56:48 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=xOlaPFf62dpYcTPloUbhe4z7PlG2hxIDtcN/z+K7or4=; b=nYUPYxHFLuQzx+ 69GxhsR6QtdujVJ/lFiSxG+E7fkzmyAeoY/2QNzq9ANkXK+5QD12Xc3+lhjba3LCv7ZCxI1u7P/oH 2mtJZfROlH+vEO3niJGL60s8Gak0oxEbg5fTwvRZbBSIvVVc+Bx5jCDaR9pl52k59FxNVGd2fdGfG lHS7Z6sUUjLBm3gKnmjDI4gDZVKHjvgXwUaYjns2Vc0BF1vTOSPk8mB8EYCJnB8SCNpQl7th6jJOV SH8i7pzCXi6j9IUvDJICBvR8bMIN54QUXcW4XoDvanbO3F4+1Tj6rmagC+PRKTgan8HC94xqKy6Pp WCVEf+ahjd4Mw9G52dtQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1p6AFm-00F8Uq-KA; Fri, 16 Dec 2022 12:55:54 +0000 Received: from pandora.armlinux.org.uk ([2001:4d48:ad52:32c8:5054:ff:fe00:142]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1p6AFj-00F6wF-A8 for linux-arm-kernel@lists.infradead.org; Fri, 16 Dec 2022 12:55:52 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=armlinux.org.uk; s=pandora-2019; h=Sender:In-Reply-To:Content-Type: MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id: List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=x5rJnMBsw+sgODTEHEKln64ytpOB5rN9K492KlVe/Dc=; b=BHfFUPNsPpmMsxwocnthf/T0nG mmvkGbF6x8uWtJl1SGmAGXGdmyc2ecHjtHPpWyvFXWVQ3iK78xAnmWgis/Y4jC2H5Nen7FrMuLw5X BNzn/3GnGG0SgdSq5tOu7ZD1HAGhn6SN+rrsWnx47bnDkih566c1gp4zDOSPVn9ojDVivbCTEyxQ9 x2ufzLwyXpraQ34w7LyiHczvaub1KBLEeu+lyUNQ0SlgS/tplpUGsj998cFNOQZxMfKI57mxJMusm ydg/1S89NFrr+6MPjG/ihzxgRE6zYTupxVuATM4u45SKEzmLGxmaHUHTYs0bh4cpd6JNfASsefKbp L/z9Ykmw==; Received: from shell.armlinux.org.uk ([fd8f:7570:feb6:1:5054:ff:fe00:4ec]:35740) by pandora.armlinux.org.uk with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1p6ADf-0007Jq-J4; Fri, 16 Dec 2022 12:53:43 +0000 Received: from linux by shell.armlinux.org.uk with local (Exim 4.94.2) (envelope-from ) id 1p6ADe-0000tw-Pc; Fri, 16 Dec 2022 12:53:42 +0000 Date: Fri, 16 Dec 2022 12:53:42 +0000 From: "Russell King (Oracle)" To: Stefan Wiehler Cc: linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH RESENDv2] arm: topology: Consider clock-frequency property from parent /cpus node Message-ID: References: <20221216124157.13270-1-stefan.wiehler@nokia.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20221216124157.13270-1-stefan.wiehler@nokia.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20221216_045551_390480_8F490F5E X-CRM114-Status: UNSURE ( 7.97 ) X-CRM114-Notice: Please train this message. X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi, On Fri, Dec 16, 2022 at 01:41:58PM +0100, Stefan Wiehler wrote: > + cn = of_get_cpu_node(cpu, NULL); > + if (!cn) > + pr_err("missing device node for CPU %d\n", cpu); > + cn = of_get_parent(cn); Doesn't this need to do an of_node_put()? > + if (!cn) > + pr_err("missing parent node for CPU %d\n", cpu); > + common_rate = of_get_property(cn, "clock-frequency", &common_rate_len); And here too? Thanks. -- RMK's Patch system: https://www.armlinux.org.uk/developer/patches/ FTTP is here! 40Mbps down 10Mbps up. Decent connectivity at last! _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id D88DCC4332F for ; Fri, 16 Dec 2022 12:53:59 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230203AbiLPMx6 (ORCPT ); Fri, 16 Dec 2022 07:53:58 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:42340 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229948AbiLPMxu (ORCPT ); Fri, 16 Dec 2022 07:53:50 -0500 Received: from pandora.armlinux.org.uk (pandora.armlinux.org.uk [IPv6:2001:4d48:ad52:32c8:5054:ff:fe00:142]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 4627A24979 for ; Fri, 16 Dec 2022 04:53:46 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=armlinux.org.uk; s=pandora-2019; h=Sender:In-Reply-To:Content-Type: MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id: List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=x5rJnMBsw+sgODTEHEKln64ytpOB5rN9K492KlVe/Dc=; b=BHfFUPNsPpmMsxwocnthf/T0nG mmvkGbF6x8uWtJl1SGmAGXGdmyc2ecHjtHPpWyvFXWVQ3iK78xAnmWgis/Y4jC2H5Nen7FrMuLw5X BNzn/3GnGG0SgdSq5tOu7ZD1HAGhn6SN+rrsWnx47bnDkih566c1gp4zDOSPVn9ojDVivbCTEyxQ9 x2ufzLwyXpraQ34w7LyiHczvaub1KBLEeu+lyUNQ0SlgS/tplpUGsj998cFNOQZxMfKI57mxJMusm ydg/1S89NFrr+6MPjG/ihzxgRE6zYTupxVuATM4u45SKEzmLGxmaHUHTYs0bh4cpd6JNfASsefKbp L/z9Ykmw==; Received: from shell.armlinux.org.uk ([fd8f:7570:feb6:1:5054:ff:fe00:4ec]:35740) by pandora.armlinux.org.uk with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1p6ADf-0007Jq-J4; Fri, 16 Dec 2022 12:53:43 +0000 Received: from linux by shell.armlinux.org.uk with local (Exim 4.94.2) (envelope-from ) id 1p6ADe-0000tw-Pc; Fri, 16 Dec 2022 12:53:42 +0000 Date: Fri, 16 Dec 2022 12:53:42 +0000 From: "Russell King (Oracle)" To: Stefan Wiehler Cc: linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH RESENDv2] arm: topology: Consider clock-frequency property from parent /cpus node Message-ID: References: <20221216124157.13270-1-stefan.wiehler@nokia.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20221216124157.13270-1-stefan.wiehler@nokia.com> Sender: Russell King (Oracle) Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi, On Fri, Dec 16, 2022 at 01:41:58PM +0100, Stefan Wiehler wrote: > + cn = of_get_cpu_node(cpu, NULL); > + if (!cn) > + pr_err("missing device node for CPU %d\n", cpu); > + cn = of_get_parent(cn); Doesn't this need to do an of_node_put()? > + if (!cn) > + pr_err("missing parent node for CPU %d\n", cpu); > + common_rate = of_get_property(cn, "clock-frequency", &common_rate_len); And here too? Thanks. -- RMK's Patch system: https://www.armlinux.org.uk/developer/patches/ FTTP is here! 40Mbps down 10Mbps up. Decent connectivity at last!