All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Theodore Ts'o" <tytso@mit.edu>
To: Jun Nie <jun.nie@linaro.org>
Cc: stable@vger.kernel.org, djwong@kernel.org, jack@suse.cz,
	jlayton@kernel.org, lczerner@redhat.com,
	linux-ext4@vger.kernel.org, xuyang2018.jy@fujitsu.com
Subject: Re: [PATCH v1] ext4: Remove deprecated noacl/nouser_xattr options
Date: Fri, 16 Dec 2022 08:10:09 -0500	[thread overview]
Message-ID: <Y5xuMZn/Ysu2uThj@mit.edu> (raw)
In-Reply-To: <Y5wGZG05uicAPscI@mit.edu>

Here is a proper, minmized reproducer which reproduces on upstream, for someone
who wants to try to work this bug.

On Fri, Dec 16, 2022 at 12:47:16AM -0500, Theodore Ts'o wrote:
> Fixing this the clean and proper way, which is by making
> ext4_xattr_move_to_block() more intelligent/efficient, is left as an
> exercise to the reader.

For someone who wants to work the bug, here is a cleaner, properly
minimzed, easier-for-humans-to-understand reproducer:

#!/bin/bash -vx
#
# This reproduces an ext4 bug caused by an unfortunate interaction
# between lazytime updates happening when a file system is being
# unmounted and expand_extra_isize
#
# Initially discovered via syzkaller:
# https://syzkaller.appspot.com/bug?id=3613786cb88c93aa1c6a279b1df6a7b201347d08
#

img=/tmp/foo.img
dir=/mnt
file=$dir/file0

rm -f $img
mke2fs -Fq -t ext4 -I 256 -O ea_inode -b 1024 $img 200k
mount $img $dir
v=$(dd if=/dev/zero bs=2000 count=1 2>/dev/null | tr '\0' =)
touch $file
attr -q -s test -V $v $file
umount $dir
mount -o debug_want_extra_isize=128,lazytime /tmp/foo.img $dir
cat $file
umount $dir

  reply	other threads:[~2022-12-16 13:10 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-07-28  3:02 [PATCH v1] ext4: Remove deprecated noacl/nouser_xattr options Yang Xu
2022-07-28  9:35 ` Jan Kara
2022-08-10  8:32 ` [ext4] a70b1077cd: xfstests.ext4.053.fail kernel test robot
2022-08-10  8:32   ` kernel test robot
2022-08-16 10:11   ` Jan Kara
2022-08-16 10:11     ` Jan Kara
2022-08-17  1:58     ` xuyang2018.jy
2022-08-17  1:58       ` xuyang2018.jy
2022-09-27 21:53 ` [PATCH v1] ext4: Remove deprecated noacl/nouser_xattr options Theodore Ts'o
2022-12-16  3:41   ` Jun Nie
2022-12-16  5:47     ` Theodore Ts'o
2022-12-16 13:10       ` Theodore Ts'o [this message]
2022-12-19  9:23       ` Jun Nie
2022-12-19 11:46         ` Jan Kara
2022-12-19 16:41         ` Theodore Ts'o
2022-12-20  8:39           ` Jun Nie

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=Y5xuMZn/Ysu2uThj@mit.edu \
    --to=tytso@mit.edu \
    --cc=djwong@kernel.org \
    --cc=jack@suse.cz \
    --cc=jlayton@kernel.org \
    --cc=jun.nie@linaro.org \
    --cc=lczerner@redhat.com \
    --cc=linux-ext4@vger.kernel.org \
    --cc=stable@vger.kernel.org \
    --cc=xuyang2018.jy@fujitsu.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.