From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: Tharunkumar.Pasumarthi@microchip.com
Cc: Kumaravel.Thiagarajan@microchip.com,
linux-kernel@vger.kernel.org, linux-serial@vger.kernel.org,
gregkh@linuxfoundation.org, jirislaby@kernel.org,
ilpo.jarvinen@linux.intel.com, macro@orcam.me.uk,
cang1@live.co.uk, colin.i.king@gmail.com,
phil.edworthy@renesas.com, biju.das.jz@bp.renesas.com,
geert+renesas@glider.be, lukas@wunner.de,
u.kleine-koenig@pengutronix.de, wander@redhat.com,
etremblay@distech-controls.com, jk@ozlabs.org,
UNGLinuxDriver@microchip.com
Subject: Re: [PATCH v9 tty-next 2/4] serial: 8250_pci1xxxx: Add driver for quad-uart support
Date: Fri, 16 Dec 2022 15:29:02 +0200 [thread overview]
Message-ID: <Y5xynsu2/89iMuqF@smile.fi.intel.com> (raw)
In-Reply-To: <PH7PR11MB595883AB9234881B2CF362549BE69@PH7PR11MB5958.namprd11.prod.outlook.com>
On Fri, Dec 16, 2022 at 10:31:38AM +0000, Tharunkumar.Pasumarthi@microchip.com wrote:
> > From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
> > Sent: Friday, December 16, 2022 3:09 PM
> > To: Tharunkumar Pasumarthi - I67821
> > <Tharunkumar.Pasumarthi@microchip.com>
> > Subject: Re: [PATCH v9 tty-next 2/4] serial: 8250_pci1xxxx: Add driver for
> > quad-uart support
> >
> > > From this sequence, it seemed like, kernel takes care of freeing irq
> > > and calling pci_free_irq_vectors is not required.
> >
> > Technically you are correct, but... read this discussion, and pay attention to
> > what Christoph said there:
> >
> > https://lore.kernel.org/linux-serial/0250c46e-da6c-71f3-50ae-
> > b7c17fd0bd2c@siemens.com/
>
> Okay, got it. Will use pci_free_irq_vectors. Also, do you suggest using
> pci_enable_device instead of pcim_enable_device (to maintain consistency of
> using non managed APIs throughout driver)?
Up to you. I don't see any issues with devm_ and pcim_ APIs, you can get my
opinion from the very same discussion and also another which tried to pursue
pcim_alloc_irq_vectors().
--
With Best Regards,
Andy Shevchenko
next prev parent reply other threads:[~2022-12-16 13:29 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-12-16 5:26 [PATCH v9 tty-next 0/4] serial: 8250_pci1xxxx: Add driver for the pci1xxxx's quad-uart function Kumaravel Thiagarajan
2022-12-16 5:26 ` [PATCH v9 tty-next 1/4] serial: 8250_pci: Add serial8250_pci_setup_port definition in 8250_pcilib.c Kumaravel Thiagarajan
2022-12-16 5:26 ` [PATCH v9 tty-next 2/4] serial: 8250_pci1xxxx: Add driver for quad-uart support Kumaravel Thiagarajan
2022-12-15 17:42 ` Andy Shevchenko
2022-12-15 17:44 ` Andy Shevchenko
2022-12-16 5:40 ` Tharunkumar.Pasumarthi
2022-12-16 8:26 ` Andy Shevchenko
2022-12-16 9:30 ` Tharunkumar.Pasumarthi
2022-12-16 9:38 ` Andy Shevchenko
2022-12-16 10:31 ` Tharunkumar.Pasumarthi
2022-12-16 13:29 ` Andy Shevchenko [this message]
2022-12-16 5:26 ` [PATCH v9 tty-next 3/4] serial: 8250_pci1xxxx: Add RS485 support to quad-uart driver Kumaravel Thiagarajan
2022-12-16 5:26 ` [PATCH v9 tty-next 4/4] serial: 8250_pci1xxxx: Add power management functions " Kumaravel Thiagarajan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Y5xynsu2/89iMuqF@smile.fi.intel.com \
--to=andriy.shevchenko@linux.intel.com \
--cc=Kumaravel.Thiagarajan@microchip.com \
--cc=Tharunkumar.Pasumarthi@microchip.com \
--cc=UNGLinuxDriver@microchip.com \
--cc=biju.das.jz@bp.renesas.com \
--cc=cang1@live.co.uk \
--cc=colin.i.king@gmail.com \
--cc=etremblay@distech-controls.com \
--cc=geert+renesas@glider.be \
--cc=gregkh@linuxfoundation.org \
--cc=ilpo.jarvinen@linux.intel.com \
--cc=jirislaby@kernel.org \
--cc=jk@ozlabs.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-serial@vger.kernel.org \
--cc=lukas@wunner.de \
--cc=macro@orcam.me.uk \
--cc=phil.edworthy@renesas.com \
--cc=u.kleine-koenig@pengutronix.de \
--cc=wander@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.