From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id ED2AFC4167B for ; Fri, 30 Dec 2022 09:53:36 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234796AbiL3Jxf (ORCPT ); Fri, 30 Dec 2022 04:53:35 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:43056 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230316AbiL3Jxc (ORCPT ); Fri, 30 Dec 2022 04:53:32 -0500 Received: from ams.source.kernel.org (ams.source.kernel.org [IPv6:2604:1380:4601:e00::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id DA2BF13CC9 for ; Fri, 30 Dec 2022 01:53:30 -0800 (PST) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id 8211BB81BA1 for ; Fri, 30 Dec 2022 09:53:29 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id E7190C433D2; Fri, 30 Dec 2022 09:53:27 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1672394008; bh=6BbcwURsfoWE5CeUSO8rRzJWcG0Hs1462MOsJYy+oRQ=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=Ob8wWcDI7hrQJumfWyQegOXOi6RLaicuUCduy/Rfr5KtBke0ayC6nlDRKQq/8wKK0 xGMwLl7K02mAfc9gtlblN2N2iymbO5YJ2qL0ggvj4t9kImnfcqCTWWxeFuxeDcIpDa NwnAD6ejkVLiSGS1tEn5Te+9UsDDKL1/2zTPsprs= Date: Fri, 30 Dec 2022 10:53:25 +0100 From: Greg KH To: nickel@altlinux.org Cc: linux-kernel@vger.kernel.org, Oleg Obidin Subject: Re: [PATCH] Revert "ASoC: soc-pcm: Don't zero TDM masks in __soc_pcm_open()" Message-ID: References: <20221230093454.468857-1-nickel@altlinux.org> <20221230093454.468857-2-nickel@altlinux.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20221230093454.468857-2-nickel@altlinux.org> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Dec 30, 2022 at 12:30:53PM +0300, nickel@altlinux.org wrote: > From: Nikolai Kostrigin > > This reverts commit c34db0d6b88b1da95e7ab3353e674f4f574cccee. > > Sudden sound disappearance was reported for some laptops, e.g. > Acer Swift 3 SF314-59-78UR 11th Gen Intel(R) Core(TM) i7-1165G7 @ 2.80GHz > > lspci > 0000:00:1f.3 Multimedia audio controller: Intel Corporation Tiger Lake-LP Smart Sound Technology Audio Controller (rev 20) > Subsystem: Acer Incorporated [ALI] Device 148c > Flags: bus master, fast devsel, latency 32, IRQ 197, IOMMU group 12 > Memory at 601f270000 (64-bit, non-prefetchable) [size=16K] > Memory at 601f000000 (64-bit, non-prefetchable) [size=1M] > Capabilities: [50] Power Management version 3 > Capabilities: [80] Vendor Specific Information: Len=14 > Capabilities: [60] MSI: Enable+ Count=1/1 Maskable- 64bit+ > Kernel driver in use: sof-audio-pci > > Bisection revealed the commit being reverted. > > Reported-by: Oleg Obidin > Link: https://bugzilla.altlinux.org/44690 > Link: https://bugzilla.kernel.org/show_bug.cgi?id=216861 > Signed-off-by: Nikolai Kostrigin > --- > sound/soc/soc-pcm.c | 5 +++++ > 1 file changed, 5 insertions(+) This is not the correct way to submit patches for inclusion in the stable kernel tree. Please read: https://www.kernel.org/doc/html/latest/process/stable-kernel-rules.html for how to do this properly.