From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: Bartosz Golaszewski <brgl@bgdev.pl>
Cc: Bartosz Golaszewski <bartosz.golaszewski@linaro.org>,
linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org,
Linus Walleij <linus.walleij@linaro.org>,
Haibo Chen <haibo.chen@nxp.com>
Subject: Re: [PATCH v2 1/4] gpio: pca953x: avoid to use uninitialized value pinctrl
Date: Fri, 30 Dec 2022 23:36:40 +0200 [thread overview]
Message-ID: <Y69Z6FhmypFASRyX@smile.fi.intel.com> (raw)
In-Reply-To: <CAMRc=MdZ4RN=EFS0Brf0Avis9FOVh9+8x5rB52b8eO_Ln+CGiA@mail.gmail.com>
On Fri, Dec 30, 2022 at 01:48:20PM +0100, Bartosz Golaszewski wrote:
> On Fri, Dec 30, 2022 at 1:04 PM Andy Shevchenko
> <andriy.shevchenko@linux.intel.com> wrote:
> > On Sun, Dec 11, 2022 at 12:05:58AM +0200, Andy Shevchenko wrote:
> > > From: Haibo Chen <haibo.chen@nxp.com>
> > >
> > > There is a variable pinctrl declared without initializer. And then
> > > has the case (switch operation chose the default case) to directly
> > > use this uninitialized value, this is not a safe behavior. So here
> > > initialize the pinctrl as 0 to avoid this issue.
> > > This is reported by Coverity.
> >
> > Bart, any comments on the series?
>
> Now applied. I just got back from Christmas break, give me a moment. :)
Sure and thank you! Merry xmas!
--
With Best Regards,
Andy Shevchenko
prev parent reply other threads:[~2022-12-30 21:36 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-12-10 22:05 [PATCH v2 1/4] gpio: pca953x: avoid to use uninitialized value pinctrl Andy Shevchenko
2022-12-10 22:05 ` [PATCH v2 2/4] gpio: pca953x: avoid logically dead code Andy Shevchenko
2022-12-10 22:06 ` [PATCH v2 3/4] gpio: pca953x: Clean up pcal6534_check_register() Andy Shevchenko
2022-12-10 22:06 ` [PATCH v2 4/4] gpio: pca953x: Remove unused PCAL953X_OUT_CONF from pcal6534_recalc_addr() Andy Shevchenko
2022-12-30 12:04 ` [PATCH v2 1/4] gpio: pca953x: avoid to use uninitialized value pinctrl Andy Shevchenko
2022-12-30 12:48 ` Bartosz Golaszewski
2022-12-30 21:36 ` Andy Shevchenko [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Y69Z6FhmypFASRyX@smile.fi.intel.com \
--to=andriy.shevchenko@linux.intel.com \
--cc=bartosz.golaszewski@linaro.org \
--cc=brgl@bgdev.pl \
--cc=haibo.chen@nxp.com \
--cc=linus.walleij@linaro.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.