From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B31A53217; Mon, 19 Dec 2022 15:00:24 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id EDE70C433D2; Mon, 19 Dec 2022 15:00:19 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1671462024; bh=JbD1CERCvAqPiTchVboz7aWPTf4CqkVZl5hSSLWV8+Y=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=TWOHbnn13mEX9dougL+e1l5NCO4uC1JocxLiRTSuLMFPPooSOsduPqT9WpQeOtG6O w2zJBKPFa+CLq98BUmfOJTMjK7bvGLBCpvveQ1ekQ8bR2LmWkgnufJ4Obi/Awvwz3M n7qP1lNleQHNul8coOBFRf32nkDXxU7wxe4tfgcU8ogUOrPfC1Itbs9hxlkmwndsXj 2rBH/FnRTPol7uGGixifpUdUvmPnbyxy+o72SDzNKVoOPR7m7cPSHLft1yAfwpc1h5 lGiwqAGg8ay3BTPXtyoQlRsnMWvSY6wtMMPNexp2/Kzyu25GTC7kKoU8xhzOMlmWgc 3GMADB2IG5MTQ== Date: Mon, 19 Dec 2022 15:00:15 +0000 From: Mark Brown To: Marc Zyngier Cc: Akihiko Odaki , linux-kernel@vger.kernel.org, kvmarm@lists.linux.dev, kvmarm@lists.cs.columbia.edu, linux-arm-kernel@lists.infradead.org, Mathieu Poirier , Oliver Upton , Suzuki K Poulose , Alexandru Elisei , James Morse , Will Deacon , Catalin Marinas , asahi@lists.linux.dev, Alyssa Rosenzweig , Sven Peter , Hector Martin Subject: Re: [PATCH v3 1/7] arm64/sysreg: Convert CCSIDR_EL1 to automatic generation Message-ID: References: <20221218051412.384657-1-akihiko.odaki@daynix.com> <20221218051412.384657-2-akihiko.odaki@daynix.com> <87cz8hez0i.wl-maz@kernel.org> <1ef32b0c-6cee-75f7-e1e0-ede1f5b9a016@daynix.com> <87bko0g8m2.wl-maz@kernel.org> Precedence: bulk X-Mailing-List: asahi@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="u5kU4UMJcC0W4wyS" Content-Disposition: inline In-Reply-To: <87bko0g8m2.wl-maz@kernel.org> X-Cookie: I brake for chezlogs! --u5kU4UMJcC0W4wyS Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Sun, Dec 18, 2022 at 01:11:01PM +0000, Marc Zyngier wrote: > Akihiko Odaki wrote: > > arch/arm64/tools/gen-sysreg.awk does not allow a hole and requires all > > bits are described hence these descriptions. If you have an > > alternative idea I'd like to hear. > I'd simply suggest creating an UNKNOWN field encompassing bits > [21:28]. Alternatively, feel free to try the patch below, which allows > you to describe these 4 bits as "Unkn 31:28", similar to Res0/Res1. I agree, where practical we should add new field types and other features as needed rather than trying to shoehorn things into what the tool currently supports. It is very much a work in progress which can't fully represent everything in the spec yet. For things like the registers with multiple possible views it's much more effort which shouldn't get in the way of progress on features but with something like this just updating the tool so we can match the architecture spec is the right thing. > Define an 'Unkn' field type modeled after the Res0/Res1 types > to allow such description. This allows the generation of I'd be tempted to spell out Unknown fully since Unkn is not such a common abbreviation but I can see the desire to keep the name shorter and it doesn't really matter so either way: Reviewed-by: Mark Brown --u5kU4UMJcC0W4wyS Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAABCgAdFiEEreZoqmdXGLWf4p/qJNaLcl1Uh9AFAmOgfH4ACgkQJNaLcl1U h9BsAgf/SbrRls2l2YJ4ke3IATlZrBSMsZVI98FuGsLwHeKknHxUHGkJKrMfdbk4 diEmW0Bk69Cn4VAzsMwg7l0x8JMGJwE94sMyUwX0DOC0r1xI/KrAxhS/PetsIlVv tJQPP9FYO33oJmjDsAqCwaO90Qkdk4I7QrDos/eO+yucA6tISgrM95FSufMwTZqX 9pu8j5CizDnf77pZIXVUjhDMVzdqJsiGg3YTuHZpDXdfXq/COW4ECCMKB25GmCSh /pB2NEvWJoX6ZiDoyi7XxokmMv8nOPnMYyahTM1jO2N5tEcav9E4t9levchdQ5n0 PTo3pY7o2LisFYorkFn5o4eys9hYRw== =BwsC -----END PGP SIGNATURE----- --u5kU4UMJcC0W4wyS-- From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mm01.cs.columbia.edu (mm01.cs.columbia.edu [128.59.11.253]) by smtp.lore.kernel.org (Postfix) with ESMTP id 59634C4332F for ; Mon, 19 Dec 2022 15:00:40 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by mm01.cs.columbia.edu (Postfix) with ESMTP id DA0AE4B882; Mon, 19 Dec 2022 10:00:39 -0500 (EST) X-Virus-Scanned: at lists.cs.columbia.edu Authentication-Results: mm01.cs.columbia.edu (amavisd-new); dkim=softfail (fail, message has been altered) header.i=@kernel.org Received: from mm01.cs.columbia.edu ([127.0.0.1]) by localhost (mm01.cs.columbia.edu [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 4QLZCnSnRCc2; Mon, 19 Dec 2022 10:00:35 -0500 (EST) Received: from mm01.cs.columbia.edu (localhost [127.0.0.1]) by mm01.cs.columbia.edu (Postfix) with ESMTP id 9F2304B89D; Mon, 19 Dec 2022 10:00:35 -0500 (EST) Received: from localhost (localhost [127.0.0.1]) by mm01.cs.columbia.edu (Postfix) with ESMTP id E8CA24B882 for ; Mon, 19 Dec 2022 10:00:34 -0500 (EST) X-Virus-Scanned: at lists.cs.columbia.edu Received: from mm01.cs.columbia.edu ([127.0.0.1]) by localhost (mm01.cs.columbia.edu [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id s8mxKB3BnfwX for ; Mon, 19 Dec 2022 10:00:33 -0500 (EST) Received: from sin.source.kernel.org (sin.source.kernel.org [145.40.73.55]) by mm01.cs.columbia.edu (Postfix) with ESMTPS id 1FE7B4B889 for ; Mon, 19 Dec 2022 10:00:33 -0500 (EST) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sin.source.kernel.org (Postfix) with ESMTPS id 0415FCE0F5D; Mon, 19 Dec 2022 15:00:26 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id EDE70C433D2; Mon, 19 Dec 2022 15:00:19 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1671462024; bh=JbD1CERCvAqPiTchVboz7aWPTf4CqkVZl5hSSLWV8+Y=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=TWOHbnn13mEX9dougL+e1l5NCO4uC1JocxLiRTSuLMFPPooSOsduPqT9WpQeOtG6O w2zJBKPFa+CLq98BUmfOJTMjK7bvGLBCpvveQ1ekQ8bR2LmWkgnufJ4Obi/Awvwz3M n7qP1lNleQHNul8coOBFRf32nkDXxU7wxe4tfgcU8ogUOrPfC1Itbs9hxlkmwndsXj 2rBH/FnRTPol7uGGixifpUdUvmPnbyxy+o72SDzNKVoOPR7m7cPSHLft1yAfwpc1h5 lGiwqAGg8ay3BTPXtyoQlRsnMWvSY6wtMMPNexp2/Kzyu25GTC7kKoU8xhzOMlmWgc 3GMADB2IG5MTQ== Date: Mon, 19 Dec 2022 15:00:15 +0000 From: Mark Brown To: Marc Zyngier Subject: Re: [PATCH v3 1/7] arm64/sysreg: Convert CCSIDR_EL1 to automatic generation Message-ID: References: <20221218051412.384657-1-akihiko.odaki@daynix.com> <20221218051412.384657-2-akihiko.odaki@daynix.com> <87cz8hez0i.wl-maz@kernel.org> <1ef32b0c-6cee-75f7-e1e0-ede1f5b9a016@daynix.com> <87bko0g8m2.wl-maz@kernel.org> MIME-Version: 1.0 In-Reply-To: <87bko0g8m2.wl-maz@kernel.org> X-Cookie: I brake for chezlogs! Cc: Alyssa Rosenzweig , Hector Martin , Akihiko Odaki , Mathieu Poirier , Will Deacon , Sven Peter , linux-kernel@vger.kernel.org, asahi@lists.linux.dev, Catalin Marinas , kvmarm@lists.linux.dev, kvmarm@lists.cs.columbia.edu, linux-arm-kernel@lists.infradead.org X-BeenThere: kvmarm@lists.cs.columbia.edu X-Mailman-Version: 2.1.14 Precedence: list List-Id: Where KVM/ARM decisions are made List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: multipart/mixed; boundary="===============2612328144419890194==" Errors-To: kvmarm-bounces@lists.cs.columbia.edu Sender: kvmarm-bounces@lists.cs.columbia.edu --===============2612328144419890194== Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="u5kU4UMJcC0W4wyS" Content-Disposition: inline --u5kU4UMJcC0W4wyS Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Sun, Dec 18, 2022 at 01:11:01PM +0000, Marc Zyngier wrote: > Akihiko Odaki wrote: > > arch/arm64/tools/gen-sysreg.awk does not allow a hole and requires all > > bits are described hence these descriptions. If you have an > > alternative idea I'd like to hear. > I'd simply suggest creating an UNKNOWN field encompassing bits > [21:28]. Alternatively, feel free to try the patch below, which allows > you to describe these 4 bits as "Unkn 31:28", similar to Res0/Res1. I agree, where practical we should add new field types and other features as needed rather than trying to shoehorn things into what the tool currently supports. It is very much a work in progress which can't fully represent everything in the spec yet. For things like the registers with multiple possible views it's much more effort which shouldn't get in the way of progress on features but with something like this just updating the tool so we can match the architecture spec is the right thing. > Define an 'Unkn' field type modeled after the Res0/Res1 types > to allow such description. This allows the generation of I'd be tempted to spell out Unknown fully since Unkn is not such a common abbreviation but I can see the desire to keep the name shorter and it doesn't really matter so either way: Reviewed-by: Mark Brown --u5kU4UMJcC0W4wyS Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAABCgAdFiEEreZoqmdXGLWf4p/qJNaLcl1Uh9AFAmOgfH4ACgkQJNaLcl1U h9BsAgf/SbrRls2l2YJ4ke3IATlZrBSMsZVI98FuGsLwHeKknHxUHGkJKrMfdbk4 diEmW0Bk69Cn4VAzsMwg7l0x8JMGJwE94sMyUwX0DOC0r1xI/KrAxhS/PetsIlVv tJQPP9FYO33oJmjDsAqCwaO90Qkdk4I7QrDos/eO+yucA6tISgrM95FSufMwTZqX 9pu8j5CizDnf77pZIXVUjhDMVzdqJsiGg3YTuHZpDXdfXq/COW4ECCMKB25GmCSh /pB2NEvWJoX6ZiDoyi7XxokmMv8nOPnMYyahTM1jO2N5tEcav9E4t9levchdQ5n0 PTo3pY7o2LisFYorkFn5o4eys9hYRw== =BwsC -----END PGP SIGNATURE----- --u5kU4UMJcC0W4wyS-- --===============2612328144419890194== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ kvmarm mailing list kvmarm@lists.cs.columbia.edu https://lists.cs.columbia.edu/mailman/listinfo/kvmarm --===============2612328144419890194==-- From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 07340C4332F for ; Mon, 19 Dec 2022 16:36:26 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:Content-Type: List-Subscribe:List-Help:List-Post:List-Archive:List-Unsubscribe:List-Id: In-Reply-To:MIME-Version:References:Message-ID:Subject:Cc:To:From:Date: Reply-To:Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date :Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=ofQpsrjzDVRH9dQsGju5U6A85QnxK8WGQ5YvryO3JeA=; b=LY5718UxThjbozheAKT2Yk40fI 6sheIAevN1DabXKo0EU8yEq8HRAwEifOR4wp7bPskTIERT7P3mYG0PaMJpskVmfgvjYqIop0lpzOG gEl+Osonedkhul7gEU03kd7FhQy463pBumykJ+VTrKZY9DAI+6SFkTl3g4QKyR3BPQazZdMKEleCU YqUT2zvY60MIesXrCLWz/2bUX6PVnN0iYgrbl2GXYHwwoTOvH68Jz7+9kIQBIQxHWAHSy0AlhTa/r aRJxaPeVX8q82DrOIZCIASecQ5igcXheTw4S82ilNsqmQ8I3+Cpbqs1E/eP5fJ8ZXJlFizsOVCxiJ mI7R/jEQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1p7J6c-00G8sQ-AO; Mon, 19 Dec 2022 16:35:10 +0000 Received: from sin.source.kernel.org ([145.40.73.55]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1p7Hcy-00F5eP-3C for linux-arm-kernel@lists.infradead.org; Mon, 19 Dec 2022 15:00:30 +0000 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sin.source.kernel.org (Postfix) with ESMTPS id 0415FCE0F5D; Mon, 19 Dec 2022 15:00:26 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id EDE70C433D2; Mon, 19 Dec 2022 15:00:19 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1671462024; bh=JbD1CERCvAqPiTchVboz7aWPTf4CqkVZl5hSSLWV8+Y=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=TWOHbnn13mEX9dougL+e1l5NCO4uC1JocxLiRTSuLMFPPooSOsduPqT9WpQeOtG6O w2zJBKPFa+CLq98BUmfOJTMjK7bvGLBCpvveQ1ekQ8bR2LmWkgnufJ4Obi/Awvwz3M n7qP1lNleQHNul8coOBFRf32nkDXxU7wxe4tfgcU8ogUOrPfC1Itbs9hxlkmwndsXj 2rBH/FnRTPol7uGGixifpUdUvmPnbyxy+o72SDzNKVoOPR7m7cPSHLft1yAfwpc1h5 lGiwqAGg8ay3BTPXtyoQlRsnMWvSY6wtMMPNexp2/Kzyu25GTC7kKoU8xhzOMlmWgc 3GMADB2IG5MTQ== Date: Mon, 19 Dec 2022 15:00:15 +0000 From: Mark Brown To: Marc Zyngier Cc: Akihiko Odaki , linux-kernel@vger.kernel.org, kvmarm@lists.linux.dev, kvmarm@lists.cs.columbia.edu, linux-arm-kernel@lists.infradead.org, Mathieu Poirier , Oliver Upton , Suzuki K Poulose , Alexandru Elisei , James Morse , Will Deacon , Catalin Marinas , asahi@lists.linux.dev, Alyssa Rosenzweig , Sven Peter , Hector Martin Subject: Re: [PATCH v3 1/7] arm64/sysreg: Convert CCSIDR_EL1 to automatic generation Message-ID: References: <20221218051412.384657-1-akihiko.odaki@daynix.com> <20221218051412.384657-2-akihiko.odaki@daynix.com> <87cz8hez0i.wl-maz@kernel.org> <1ef32b0c-6cee-75f7-e1e0-ede1f5b9a016@daynix.com> <87bko0g8m2.wl-maz@kernel.org> MIME-Version: 1.0 In-Reply-To: <87bko0g8m2.wl-maz@kernel.org> X-Cookie: I brake for chezlogs! X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20221219_070028_797047_B3D294C3 X-CRM114-Status: GOOD ( 19.42 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: multipart/mixed; boundary="===============7648199739756615091==" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org --===============7648199739756615091== Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="u5kU4UMJcC0W4wyS" Content-Disposition: inline --u5kU4UMJcC0W4wyS Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Sun, Dec 18, 2022 at 01:11:01PM +0000, Marc Zyngier wrote: > Akihiko Odaki wrote: > > arch/arm64/tools/gen-sysreg.awk does not allow a hole and requires all > > bits are described hence these descriptions. If you have an > > alternative idea I'd like to hear. > I'd simply suggest creating an UNKNOWN field encompassing bits > [21:28]. Alternatively, feel free to try the patch below, which allows > you to describe these 4 bits as "Unkn 31:28", similar to Res0/Res1. I agree, where practical we should add new field types and other features as needed rather than trying to shoehorn things into what the tool currently supports. It is very much a work in progress which can't fully represent everything in the spec yet. For things like the registers with multiple possible views it's much more effort which shouldn't get in the way of progress on features but with something like this just updating the tool so we can match the architecture spec is the right thing. > Define an 'Unkn' field type modeled after the Res0/Res1 types > to allow such description. This allows the generation of I'd be tempted to spell out Unknown fully since Unkn is not such a common abbreviation but I can see the desire to keep the name shorter and it doesn't really matter so either way: Reviewed-by: Mark Brown --u5kU4UMJcC0W4wyS Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAABCgAdFiEEreZoqmdXGLWf4p/qJNaLcl1Uh9AFAmOgfH4ACgkQJNaLcl1U h9BsAgf/SbrRls2l2YJ4ke3IATlZrBSMsZVI98FuGsLwHeKknHxUHGkJKrMfdbk4 diEmW0Bk69Cn4VAzsMwg7l0x8JMGJwE94sMyUwX0DOC0r1xI/KrAxhS/PetsIlVv tJQPP9FYO33oJmjDsAqCwaO90Qkdk4I7QrDos/eO+yucA6tISgrM95FSufMwTZqX 9pu8j5CizDnf77pZIXVUjhDMVzdqJsiGg3YTuHZpDXdfXq/COW4ECCMKB25GmCSh /pB2NEvWJoX6ZiDoyi7XxokmMv8nOPnMYyahTM1jO2N5tEcav9E4t9levchdQ5n0 PTo3pY7o2LisFYorkFn5o4eys9hYRw== =BwsC -----END PGP SIGNATURE----- --u5kU4UMJcC0W4wyS-- --===============7648199739756615091== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel --===============7648199739756615091==--