From: Anthony PERARD <anthony.perard@citrix.com>
To: "Edwin Török" <edvin.torok@citrix.com>
Cc: <xen-devel@lists.xenproject.org>,
Christian Lindig <christian.lindig@citrix.com>,
David Scott <dave@recoil.org>, Wei Liu <wl@xen.org>
Subject: Re: [PATCH v4 06/11] tools/ocaml: add .clang-format
Date: Mon, 19 Dec 2022 12:03:31 +0000 [thread overview]
Message-ID: <Y6BTExf6riHD1HLV@perard.uk.xensource.com> (raw)
In-Reply-To: <a3af11ec979d7559ba8db2d185bd51454858739d.1671214525.git.edwin.torok@cloud.com>
On Fri, Dec 16, 2022 at 06:25:15PM +0000, Edwin Török wrote:
> Add a .clang-format configuration that tries to match CODING_STYLE where
> possible.
Is there going to be a patch applying this to "tools/ocaml", like you
did with "make format"?
> I was not able to express the special casing of braces after 'do'
> though, this can only be controlled generally for all control
> statements.
> It is imperfect, but should be better than the existing bindings, which
> do not follow Xen coding style.
There isn't a single CODING_STYLE for all code in the repo so it isn't
an issue if the binding where having a different coding style. But
having as few coding style as possible in the repo is probably helpful.
You could maybe add a CODING_STYLE in "tools/ocaml" to say that the
coding style is running `make format` or `clang-format ...`. And if
there other rules like how to name certain variable, that could go in
this file as well.
Cheers,
--
Anthony PERARD
next prev parent reply other threads:[~2022-12-19 12:03 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-12-16 18:25 [PATCH v4 00/11] OCaml fixes Edwin Török
2022-12-16 18:25 ` [PATCH v4 01/11] tools/ocaml/libs/{xb, mmap}: use Data_abstract_val wrapper Edwin Török
2022-12-16 22:40 ` Andrew Cooper
2022-12-19 9:06 ` Edwin Torok
2022-12-16 18:25 ` [PATCH v4 02/11] tools/ocaml/xenstored/Makefile: use ocamldep -sort for linking order Edwin Török
2022-12-16 18:25 ` [PATCH v4 03/11] CODING_STYLE(tools/ocaml): add 'make format' and remove tabs Edwin Török
2022-12-19 9:55 ` Christian Lindig
2022-12-19 11:52 ` Anthony PERARD
2022-12-19 13:32 ` Edwin Torok
2022-12-16 18:25 ` [PATCH v4 04/11] tools/ocaml: run "make format" Edwin Török
2022-12-16 18:25 ` [PATCH v4 05/11] CODING-STYLE(tools/ocaml): add .editorconfig to clarify indentation uses spaces Edwin Török
2022-12-19 9:59 ` Christian Lindig
2022-12-16 18:25 ` [PATCH v4 06/11] tools/ocaml: add .clang-format Edwin Török
2022-12-19 12:03 ` Anthony PERARD [this message]
2022-12-19 13:21 ` Edwin Torok
2022-12-16 18:25 ` [PATCH v4 07/11] fixup! tools/ocaml/xenctrl: OCaml 5 support, fix use-after-free Edwin Török
2022-12-16 18:25 ` [PATCH v4 08/11] tools/ocaml/libs/mmap: mark mmap/munmap as blocking and raise Unix_error on failure Edwin Török
2022-12-16 18:25 ` [PATCH v4 09/11] tools/ocaml/libs/xb: check for unmapped ring before accessing it Edwin Török
2022-12-16 18:25 ` [PATCH v4 10/11] tools/ocaml/xenstored: validate config file before live update Edwin Török
2022-12-19 9:37 ` Christian Lindig
2022-12-19 9:57 ` Edwin Torok
2022-12-16 18:25 ` [PATCH v4 11/11] tools/ocaml/libs/xb: drop Xs_ring.write Edwin Török
2022-12-19 10:54 ` [PATCH v4 00/11] OCaml fixes Christian Lindig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Y6BTExf6riHD1HLV@perard.uk.xensource.com \
--to=anthony.perard@citrix.com \
--cc=christian.lindig@citrix.com \
--cc=dave@recoil.org \
--cc=edvin.torok@citrix.com \
--cc=wl@xen.org \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.