From: Maciej Fijalkowski <maciej.fijalkowski@intel.com>
To: Sergey Temerkhanov <sergey.temerkhanov@intel.com>
Cc: intel-wired-lan@lists.osuosl.org
Subject: Re: [Intel-wired-lan] [net-next v2 1/1] ice: Move support DDP code out of ice_flex_pipe.c
Date: Mon, 19 Dec 2022 17:48:36 +0100 [thread overview]
Message-ID: <Y6CV5GkmIE+dM3cH@boxer> (raw)
In-Reply-To: <20221217220947.3232247-1-sergey.temerkhanov@intel.com>
On Sat, Dec 17, 2022 at 11:09:47PM +0100, Sergey Temerkhanov wrote:
> Currently, ice_flex_pipe.c includes the DDP loading functions
> and has grown large. Although flexible processing support
> code is related to DDP loading, these parts are distinct.
> Move the DDP loading functionality from ice_flex_pipe.c to
> a seperate file.
>
> V2: Incorporate latest changes
Hi Sergey,
two things: versioning for single patches should go below --- line, second
thing is that this description tells us nothing. What are the 'latest
changes' ? :) I probably have to dig review on v1 to get the idea.
>
> Signed-off-by: Sergey Temerkhanov <sergey.temerkhanov@intel.com>
> ---
> drivers/net/ethernet/intel/ice/Makefile | 1 +
> drivers/net/ethernet/intel/ice/ice_ddp.c | 1919 +++++++++++++++++
> drivers/net/ethernet/intel/ice/ice_ddp.h | 449 ++++
> .../net/ethernet/intel/ice/ice_flex_pipe.c | 1904 ----------------
> .../net/ethernet/intel/ice/ice_flex_pipe.h | 69 -
> .../net/ethernet/intel/ice/ice_flex_type.h | 328 +--
> 6 files changed, 2370 insertions(+), 2300 deletions(-)
> create mode 100644 drivers/net/ethernet/intel/ice/ice_ddp.c
> create mode 100644 drivers/net/ethernet/intel/ice/ice_ddp.h
>
_______________________________________________
Intel-wired-lan mailing list
Intel-wired-lan@osuosl.org
https://lists.osuosl.org/mailman/listinfo/intel-wired-lan
next prev parent reply other threads:[~2022-12-19 16:48 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-12-17 22:09 [Intel-wired-lan] [net-next v2 1/1] ice: Move support DDP code out of ice_flex_pipe.c Sergey Temerkhanov
2022-12-19 16:48 ` Maciej Fijalkowski [this message]
2022-12-19 16:52 ` Temerkhanov, Sergey
2022-12-19 21:38 ` Nguyen, Anthony L
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Y6CV5GkmIE+dM3cH@boxer \
--to=maciej.fijalkowski@intel.com \
--cc=intel-wired-lan@lists.osuosl.org \
--cc=sergey.temerkhanov@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.