From: Dmitry Torokhov <dmitry.torokhov@gmail.com>
To: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Cc: Linus Walleij <linus.walleij@linaro.org>,
Bartosz Golaszewski <brgl@bgdev.pl>,
linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 4/5] gpiolib: of: remove of_get_gpio[_flags]() and of_get_named_gpio_flags()
Date: Tue, 20 Dec 2022 10:29:06 -0800 [thread overview]
Message-ID: <Y6H+8vss7YPgOrMF@google.com> (raw)
In-Reply-To: <Y6G/cypRVrpmjeqI@smile.fi.intel.com>
On Tue, Dec 20, 2022 at 03:58:11PM +0200, Andy Shevchenko wrote:
> On Mon, Dec 19, 2022 at 11:20:15AM -0800, Dmitry Torokhov wrote:
> > There are no more users of these APIs in the mainline kernel, remove
> > them. This leaves of_get_named_gpio() as the only legacy OF-specific
> > API.
>
> ...
>
> > - desc = of_get_named_gpiod_flags(np, list_name, index, flags);
> > + desc = of_get_named_gpiod_flags(np, propname, index, NULL);
>
> I didn't get it. The commit message and the subject says there are no more
> users of these APIs, why is it still here? How is it compiled?
gpio vs gpiod strikes again ;) We are removing
of_get_named_gpio_flags(), but of_get_named_gpiod_flags() is a local
helper in gpiolib-of.c and is still very much in use there and I have no
plans removing it.
Thanks.
--
Dmitry
next prev parent reply other threads:[~2022-12-20 18:29 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-12-19 19:20 [PATCH 1/5] gpiolib: of: remove of_gpio_count() Dmitry Torokhov
2022-12-19 19:20 ` [PATCH 2/5] gpiolib: of: stop exporting of_gpio_named_count() Dmitry Torokhov
2022-12-20 13:50 ` Andy Shevchenko
2022-12-20 18:27 ` Dmitry Torokhov
2022-12-20 19:15 ` Andy Shevchenko
2022-12-19 19:20 ` [PATCH 3/5] gpiolib: of: remove obsolete comment for of_gpio_get_count() Dmitry Torokhov
2022-12-20 13:52 ` Andy Shevchenko
2023-01-09 13:07 ` Linus Walleij
2022-12-19 19:20 ` [PATCH 4/5] gpiolib: of: remove of_get_gpio[_flags]() and of_get_named_gpio_flags() Dmitry Torokhov
2022-12-20 13:58 ` Andy Shevchenko
2022-12-20 18:29 ` Dmitry Torokhov [this message]
2022-12-20 19:16 ` Andy Shevchenko
2022-12-19 19:20 ` [PATCH 5/5] gpiolib: of: remove [devm_]gpiod_get_from_of_node() APIs Dmitry Torokhov
2022-12-20 14:01 ` Andy Shevchenko
2022-12-20 18:30 ` Dmitry Torokhov
2022-12-20 13:51 ` [PATCH 1/5] gpiolib: of: remove of_gpio_count() Andy Shevchenko
2022-12-20 18:33 ` Dmitry Torokhov
2022-12-30 15:55 ` Bartosz Golaszewski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Y6H+8vss7YPgOrMF@google.com \
--to=dmitry.torokhov@gmail.com \
--cc=andriy.shevchenko@linux.intel.com \
--cc=brgl@bgdev.pl \
--cc=linus.walleij@linaro.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.