From: Lorenzo Stoakes <lstoakes@gmail.com>
To: "Uladzislau Rezki (Sony)" <urezki@gmail.com>
Cc: Andrew Morton <akpm@linux-foundation.org>,
linux-mm@kvack.org, LKML <linux-kernel@vger.kernel.org>,
Baoquan He <bhe@redhat.com>,
Christoph Hellwig <hch@infradead.org>,
Matthew Wilcox <willy@infradead.org>,
Nicholas Piggin <npiggin@gmail.com>,
Oleksiy Avramchenko <oleksiy.avramchenko@sony.com>
Subject: Re: [PATCH 2/2] mm: vmalloc: Replace BUG_ON() by WARN_ON_ONCE()
Date: Tue, 20 Dec 2022 18:56:38 +0000 [thread overview]
Message-ID: <Y6IFZozJxCkMTorA@lucifer> (raw)
In-Reply-To: <Y6IEnojgQtQcUgDe@lucifer>
On Tue, Dec 20, 2022 at 06:53:18PM +0000, Lorenzo Stoakes wrote:
[snip
> Absolutely in favour of this in principle (BUG_ON() is something we should
> resort to in only the direst of circumstances), one small nit - perhaps it'd be
> neater to simply make this a guard clause? E.g.:-
>
> if (!WARN_ON_ONCE(!va))
> return;
>
> ...
Made a mistake here, meant to say
if (WARN_ON_ONCE(!va))
return;
Of course :)
Apologies, only just noticed you are sending a v2, perhaps something to consider
for it? But will hold off further review until you send it! :)
next prev parent reply other threads:[~2022-12-20 18:56 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-12-20 18:27 [PATCH 1/2] mm: vmalloc: Avoid a double lookup of freed VA in a tree Uladzislau Rezki (Sony)
2022-12-20 18:27 ` [PATCH 2/2] mm: vmalloc: Replace BUG_ON() by WARN_ON_ONCE() Uladzislau Rezki (Sony)
2022-12-20 18:45 ` Uladzislau Rezki
2022-12-20 18:53 ` Lorenzo Stoakes
2022-12-20 18:56 ` Lorenzo Stoakes [this message]
2022-12-21 11:39 ` Uladzislau Rezki
2022-12-20 18:45 ` [PATCH 1/2] mm: vmalloc: Avoid a double lookup of freed VA in a tree Uladzislau Rezki
2022-12-20 18:46 ` Uladzislau Rezki
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Y6IFZozJxCkMTorA@lucifer \
--to=lstoakes@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=bhe@redhat.com \
--cc=hch@infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=npiggin@gmail.com \
--cc=oleksiy.avramchenko@sony.com \
--cc=urezki@gmail.com \
--cc=willy@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.