Re: [PATCH v2 2/2] virtio-blk: support completion batching for the IRQ path

[Suwan Kim <suwan.kim027@gmail.com>]

On Wed, Dec 21, 2022 at 02:48:30AM -0800, Christoph Hellwig wrote:
> > +		if (likely(!blk_should_fake_timeout(req->q)) &&
> > +			!blk_mq_complete_request_remote(req) &&
> > +			!blk_mq_add_to_batch(req, iob, vbr->status,
> > +						virtblk_complete_batch))
> 
> One tab indents for line continuations are really confusing.  Please
> make this:
> 
> 		if (likely(!blk_should_fake_timeout(req->q)) &&
> 		    !blk_mq_complete_request_remote(req) &&
> 		    !blk_mq_add_to_batch(req, iob, vbr->status,
> 					 virtblk_complete_batch))
> 
> > +	found = virtblk_handle_req(vq, iob);
> >  
> >  	if (found)
> 
> You can drop the found variable here now:
> 
> 	if (virtblk_handle_req(vq, iob))
>  		blk_mq_start_stopped_hw_queues(vblk->disk->queue, true);
> 

Hi Christoph,

Thanks for the comment!
I will send v3.

> Otherwise looks good:
> 
> Reviewed-by: Christoph Hellwig <hch@lst.de>

Regards,
Suwan Kim