From: Lorenzo Stoakes <lstoakes@gmail.com>
To: Christoph Hellwig <hch@infradead.org>
Cc: Matthew Wilcox <willy@infradead.org>,
linux-mm@kvack.org, Andrew Morton <akpm@linux-foundation.org>,
linux-kernel@vger.kernel.org,
Andrey Konovalov <andreyknvl@gmail.com>,
Ingo Molnar <mingo@kernel.org>, Marco Elver <elver@google.com>,
Michal Hocko <mhocko@suse.com>
Subject: Re: [PATCH] mm: remove unused alloc_pages_bulk_list()
Date: Thu, 22 Dec 2022 12:38:22 +0000 [thread overview]
Message-ID: <Y6RPvqhtvVJ5WQW0@murray> (raw)
In-Reply-To: <Y6Qrgu94tLAZsAN/@infradead.org>
On Thu, Dec 22, 2022 at 02:03:46AM -0800, Christoph Hellwig wrote:
> Is that being snarky? :) We generally don't add dead code at all, and
> certaintly don't leave it around for a year and a half.
>
> If anyone really needs this we can add it back.
>
Mel has replied elsewhere on this thread and we have a potential user so I think
the lowest-impact approach is to go with what he suggested - wait until May and
see if we have any takers.
I have put a reminder in my calendar for then, I'll check to see if it's being
used anywhere, if not I'll respin this patch. So problem solved for everyone :)
> > Also, if we do get rid of this, then __alloc_pages_bulk() can lose
> > the "list" argument.
>
> Yepp.
Yeah the respin will take this into account, if the function remains unused in
May.
prev parent reply other threads:[~2022-12-22 12:38 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-12-17 0:15 [PATCH] mm: remove unused alloc_pages_bulk_list() Lorenzo Stoakes
2022-12-17 4:56 ` Matthew Wilcox
2022-12-17 8:34 ` Lorenzo Stoakes
2022-12-19 10:07 ` Mel Gorman
2022-12-20 17:56 ` Yang Shi
2022-12-22 12:44 ` Mel Gorman
2023-05-31 15:24 ` Lorenzo Stoakes
2023-05-31 21:29 ` Yang Shi
2023-06-01 9:10 ` Mel Gorman
2023-06-01 21:44 ` Lorenzo Stoakes
2023-06-02 3:59 ` Yang Shi
2022-12-22 10:03 ` Christoph Hellwig
2022-12-22 12:38 ` Lorenzo Stoakes [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Y6RPvqhtvVJ5WQW0@murray \
--to=lstoakes@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=andreyknvl@gmail.com \
--cc=elver@google.com \
--cc=hch@infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mhocko@suse.com \
--cc=mingo@kernel.org \
--cc=willy@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.