From: Lorenzo Stoakes <lstoakes@gmail.com>
To: Christoph Hellwig <hch@lst.de>
Cc: Andy Gross <agross@kernel.org>,
Bjorn Andersson <andersson@kernel.org>,
Konrad Dybcio <konrad.dybcio@linaro.org>,
Mathieu Poirier <mathieu.poirier@linaro.org>,
Andrew Morton <akpm@linux-foundation.org>,
Uladzislau Rezki <urezki@gmail.com>,
linux-arm-msm@vger.kernel.org, linux-remoteproc@vger.kernel.org,
linux-kernel@vger.kernel.org, linux-mm@kvack.org,
iommu@lists.linux.dev
Subject: Re: [PATCH 2/2] vmalloc: reject vmap with VM_FLUSH_RESET_PERMS
Date: Fri, 23 Dec 2022 14:10:32 +0000 [thread overview]
Message-ID: <Y6W22EHKwrTztnJR@murray> (raw)
In-Reply-To: <20221223140312.GA26826@lst.de>
On Fri, Dec 23, 2022 at 03:03:12PM +0100, Christoph Hellwig wrote:
> On Fri, Dec 23, 2022 at 10:24:25AM +0000, Lorenzo Stoakes wrote:
> > Might it be worth adding a specific vmap mask that explicitly indicates what
> > flags are permissible on vmap()? Then this could become e.g.:-
> >
> > if (WARN_ON_ONCE(flags & ~VM_VMAP_PERMITTED_MASK))
> > return NULL;
> >
> > And would be self-documenting as to why we are disallowing flags (i.e. they are
> > not part of the permitted vmap mask).
>
> That's probably a good idea. It might need some time to audit
> for use of all the flags, though.
Perhaps leave that for a later patch (I could take a look as well), but in the
meantime might be worth adding a quick comment here indicating why the flag is
prohibited?
prev parent reply other threads:[~2022-12-23 14:10 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-12-23 9:27 revert dma-mapping and vmap API abuse in qcom_q6v5_mss Christoph Hellwig
2022-12-23 9:27 ` [PATCH 1/2] Revert "remoteproc: qcom_q6v5_mss: map/unmap metadata region before/after use" Christoph Hellwig
2022-12-23 14:47 ` Manivannan Sadhasivam
2022-12-23 14:57 ` Christoph Hellwig
2022-12-23 15:40 ` Manivannan Sadhasivam
2022-12-23 15:51 ` Christoph Hellwig
2022-12-23 9:27 ` [PATCH 2/2] vmalloc: reject vmap with VM_FLUSH_RESET_PERMS Christoph Hellwig
2022-12-23 10:24 ` Lorenzo Stoakes
2022-12-23 14:03 ` Christoph Hellwig
2022-12-23 14:10 ` Lorenzo Stoakes [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Y6W22EHKwrTztnJR@murray \
--to=lstoakes@gmail.com \
--cc=agross@kernel.org \
--cc=akpm@linux-foundation.org \
--cc=andersson@kernel.org \
--cc=hch@lst.de \
--cc=iommu@lists.linux.dev \
--cc=konrad.dybcio@linaro.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=linux-remoteproc@vger.kernel.org \
--cc=mathieu.poirier@linaro.org \
--cc=urezki@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.