From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id D0172C4332F for ; Sat, 24 Dec 2022 06:50:00 +0000 (UTC) Received: from alsa1.perex.cz (alsa1.perex.cz [207.180.221.201]) (using TLSv1.2 with cipher ADH-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by alsa0.perex.cz (Postfix) with ESMTPS id D6B55A4A7; Sat, 24 Dec 2022 07:49:08 +0100 (CET) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa0.perex.cz D6B55A4A7 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=alsa-project.org; s=default; t=1671864599; bh=TDbwSX+RZR85hFNOXP679l8Ts/uVY1WswfG1Rm5eWpU=; h=Date:From:To:Subject:References:In-Reply-To:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: Cc:From; b=BlrNmZNQCAxMn1Cdnr0ZxHpWPXNXgpcAGsDA+iB/uGSsWrLIpfUf1JiXGdbIsm30Q iApD047mEplh31rFLi1occwkP2zPDTy13Eu3s6hbh7G6dHH38dJBPzKrxwRIE2OvYf pLVPyTty8XgZfE8m/W2SVN5XF/ddrJqnkZ/wa1O8= Received: from alsa1.perex.cz (localhost.localdomain [127.0.0.1]) by alsa1.perex.cz (Postfix) with ESMTP id 7C764F802E0; Sat, 24 Dec 2022 07:49:08 +0100 (CET) Received: by alsa1.perex.cz (Postfix, from userid 50401) id B1626F80249; Sat, 24 Dec 2022 07:49:07 +0100 (CET) Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by alsa1.perex.cz (Postfix) with ESMTPS id E73F5F80249 for ; Sat, 24 Dec 2022 07:49:05 +0100 (CET) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa1.perex.cz E73F5F80249 Authentication-Results: alsa1.perex.cz; dkim=pass (1024-bit key, unprotected) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.a=rsa-sha256 header.s=korg header.b=NILFU/aF Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 9F92260010; Sat, 24 Dec 2022 06:49:04 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 734A0C433D2; Sat, 24 Dec 2022 06:49:02 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1671864544; bh=TDbwSX+RZR85hFNOXP679l8Ts/uVY1WswfG1Rm5eWpU=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=NILFU/aF5VNT1SOEMGiPNn1U/V5SmGstafo839scVcFjKX+SLxbR3Pgy3usDkVyM+ w3bHMlHzM4YnhAL0fQXqUoDIMLQ/i2+OO7scNTfxlyShzATTa/xgvFBDgkqQN2cwa4 O04xzRtAMjFVVDbLrmJD7ShDnnRA2t1TPbVWl4Oo= Date: Sat, 24 Dec 2022 07:48:59 +0100 From: Greg KH To: Wesley Cheng Subject: Re: [RFC PATCH 05/14] sound: usb: Export USB SND APIs for modules Message-ID: References: <20221223233200.26089-1-quic_wcheng@quicinc.com> <20221223233200.26089-6-quic_wcheng@quicinc.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20221223233200.26089-6-quic_wcheng@quicinc.com> X-BeenThere: alsa-devel@alsa-project.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: devicetree@vger.kernel.org, alsa-devel@alsa-project.org, linux-usb@vger.kernel.org, bgoswami@quicinc.com, mathias.nyman@intel.com, Thinh.Nguyen@synopsys.com, andersson@kernel.org, tiwai@suse.com, lgirdwood@gmail.com, robh+dt@kernel.org, broonie@kernel.org, srinivas.kandagatla@linaro.org, agross@kernel.org, krzysztof.kozlowski+dt@linaro.org, linux-arm-msm@vger.kernel.org, quic_plai@quicinc.com, linux-kernel@vger.kernel.org, quic_jackp@quicinc.com Errors-To: alsa-devel-bounces@alsa-project.org Sender: "Alsa-devel" On Fri, Dec 23, 2022 at 03:31:51PM -0800, Wesley Cheng wrote: > +EXPORT_SYMBOL(snd_usb_autoresume); EXPORT_SYMBOL_GPL()? I have to ask... Same for the other ones here. > +EXPORT_SYMBOL(find_format); That is not a valid global symbol name to use, you know better than this... thanks, greg k-h From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7CB94C10F1B for ; Sat, 24 Dec 2022 06:49:18 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230472AbiLXGtP (ORCPT ); Sat, 24 Dec 2022 01:49:15 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:41778 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231282AbiLXGtJ (ORCPT ); Sat, 24 Dec 2022 01:49:09 -0500 Received: from ams.source.kernel.org (ams.source.kernel.org [IPv6:2604:1380:4601:e00::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 8902A1AA31; Fri, 23 Dec 2022 22:49:06 -0800 (PST) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id 4D4F4B81CD9; Sat, 24 Dec 2022 06:49:05 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 734A0C433D2; Sat, 24 Dec 2022 06:49:02 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1671864544; bh=TDbwSX+RZR85hFNOXP679l8Ts/uVY1WswfG1Rm5eWpU=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=NILFU/aF5VNT1SOEMGiPNn1U/V5SmGstafo839scVcFjKX+SLxbR3Pgy3usDkVyM+ w3bHMlHzM4YnhAL0fQXqUoDIMLQ/i2+OO7scNTfxlyShzATTa/xgvFBDgkqQN2cwa4 O04xzRtAMjFVVDbLrmJD7ShDnnRA2t1TPbVWl4Oo= Date: Sat, 24 Dec 2022 07:48:59 +0100 From: Greg KH To: Wesley Cheng Cc: srinivas.kandagatla@linaro.org, mathias.nyman@intel.com, perex@perex.cz, broonie@kernel.org, lgirdwood@gmail.com, andersson@kernel.org, krzysztof.kozlowski+dt@linaro.org, Thinh.Nguyen@synopsys.com, bgoswami@quicinc.com, tiwai@suse.com, robh+dt@kernel.org, agross@kernel.org, linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org, alsa-devel@alsa-project.org, devicetree@vger.kernel.org, linux-usb@vger.kernel.org, quic_jackp@quicinc.com, quic_plai@quicinc.com Subject: Re: [RFC PATCH 05/14] sound: usb: Export USB SND APIs for modules Message-ID: References: <20221223233200.26089-1-quic_wcheng@quicinc.com> <20221223233200.26089-6-quic_wcheng@quicinc.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20221223233200.26089-6-quic_wcheng@quicinc.com> Precedence: bulk List-ID: X-Mailing-List: linux-arm-msm@vger.kernel.org On Fri, Dec 23, 2022 at 03:31:51PM -0800, Wesley Cheng wrote: > +EXPORT_SYMBOL(snd_usb_autoresume); EXPORT_SYMBOL_GPL()? I have to ask... Same for the other ones here. > +EXPORT_SYMBOL(find_format); That is not a valid global symbol name to use, you know better than this... thanks, greg k-h