From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 01833C4332F for ; Sat, 24 Dec 2022 06:49:03 +0000 (UTC) Received: from alsa1.perex.cz (alsa1.perex.cz [207.180.221.201]) (using TLSv1.2 with cipher ADH-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by alsa0.perex.cz (Postfix) with ESMTPS id A8F2E9D15; Sat, 24 Dec 2022 07:48:11 +0100 (CET) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa0.perex.cz A8F2E9D15 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=alsa-project.org; s=default; t=1671864541; bh=cHfFHGYVOkCPbYTiLNY3UlB2WhZQ8+IgSDnIYQQYy/w=; h=Date:From:To:Subject:References:In-Reply-To:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: Cc:From; b=IPpT4mq71lOApYbx1xfcBoHs0pAvlmrNN7ofPjeV8kNBDbBCHeIYHOWGSIEizy+/j 4s8yb0d9ImFFQih1m6SWDLdqyJYk+8ifjUxhnv4QnGll7M1DP7PwU69t0KjGNrOjg6 YUc1Y10Q/PH5rW7PbnKiRuL8Hqg/mVHh9VzqBP4Y= Received: from alsa1.perex.cz (localhost.localdomain [127.0.0.1]) by alsa1.perex.cz (Postfix) with ESMTP id 4CF60F80423; Sat, 24 Dec 2022 07:48:11 +0100 (CET) Received: by alsa1.perex.cz (Postfix, from userid 50401) id 2308CF80245; Sat, 24 Dec 2022 07:48:10 +0100 (CET) Received: from dfw.source.kernel.org (dfw.source.kernel.org [IPv6:2604:1380:4641:c500::1]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by alsa1.perex.cz (Postfix) with ESMTPS id 31993F80245 for ; Sat, 24 Dec 2022 07:48:07 +0100 (CET) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa1.perex.cz 31993F80245 Authentication-Results: alsa1.perex.cz; dkim=pass (1024-bit key, unprotected) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.a=rsa-sha256 header.s=korg header.b=rkirL3mc Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id CD74B60010; Sat, 24 Dec 2022 06:48:05 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 4C32BC433D2; Sat, 24 Dec 2022 06:48:04 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1671864485; bh=cHfFHGYVOkCPbYTiLNY3UlB2WhZQ8+IgSDnIYQQYy/w=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=rkirL3mc1MlPIOEQj5li9Hu+bfviYBV8N+V2TdQB1+x57LROXcFYoNisgkItvzfKW r23AmF75j2zuCebeKDCtX0MsP+H/JGWtdm9Z7jUC7QzjTY6wRT7sAoFtUugWqjc3NE GiADDFS/mL0Tps1dSLfhCyKdzafBQ0/Gmr4WNgPc= Date: Sat, 24 Dec 2022 07:48:01 +0100 From: Greg KH To: Wesley Cheng Subject: Re: [RFC PATCH 01/14] ASoC: Add SOC USB APIs for adding an USB backend Message-ID: References: <20221223233200.26089-1-quic_wcheng@quicinc.com> <20221223233200.26089-2-quic_wcheng@quicinc.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20221223233200.26089-2-quic_wcheng@quicinc.com> X-BeenThere: alsa-devel@alsa-project.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: devicetree@vger.kernel.org, alsa-devel@alsa-project.org, linux-usb@vger.kernel.org, bgoswami@quicinc.com, mathias.nyman@intel.com, Thinh.Nguyen@synopsys.com, andersson@kernel.org, tiwai@suse.com, lgirdwood@gmail.com, robh+dt@kernel.org, broonie@kernel.org, srinivas.kandagatla@linaro.org, agross@kernel.org, krzysztof.kozlowski+dt@linaro.org, linux-arm-msm@vger.kernel.org, quic_plai@quicinc.com, linux-kernel@vger.kernel.org, quic_jackp@quicinc.com Errors-To: alsa-devel-bounces@alsa-project.org Sender: "Alsa-devel" On Fri, Dec 23, 2022 at 03:31:47PM -0800, Wesley Cheng wrote: > diff --git a/sound/soc/soc-usb.c b/sound/soc/soc-usb.c > new file mode 100644 > index 000000000000..c6c376960e4d > --- /dev/null > +++ b/sound/soc/soc-usb.c > @@ -0,0 +1,66 @@ > +// SPDX-License-Identifier: GPL-2.0 > +/* > + * Copyright (c) 2022 Qualcomm Innovation Center, Inc. All rights reserved. > + */ > +#include > +#include > +#include > +#include "../usb/card.h" > + > +struct snd_soc_usb *ctx; Note, this will not work. You can not only have "one" state for a system like this. That just broke any system with more than one controller, of which we have millions. This has to be dynamic for any number of controllers in the system, like the sound and USB core can handle. Any requirement of "there can be only one!" will obviously never be acceptable as that is not how Linux works. thanks, greg k-h From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 821D6C4167B for ; Sat, 24 Dec 2022 06:48:18 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229680AbiLXGsO (ORCPT ); Sat, 24 Dec 2022 01:48:14 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:41340 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229930AbiLXGsL (ORCPT ); Sat, 24 Dec 2022 01:48:11 -0500 Received: from ams.source.kernel.org (ams.source.kernel.org [145.40.68.75]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 3E894A185; Fri, 23 Dec 2022 22:48:08 -0800 (PST) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id A72D4B8219A; Sat, 24 Dec 2022 06:48:06 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 4C32BC433D2; Sat, 24 Dec 2022 06:48:04 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1671864485; bh=cHfFHGYVOkCPbYTiLNY3UlB2WhZQ8+IgSDnIYQQYy/w=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=rkirL3mc1MlPIOEQj5li9Hu+bfviYBV8N+V2TdQB1+x57LROXcFYoNisgkItvzfKW r23AmF75j2zuCebeKDCtX0MsP+H/JGWtdm9Z7jUC7QzjTY6wRT7sAoFtUugWqjc3NE GiADDFS/mL0Tps1dSLfhCyKdzafBQ0/Gmr4WNgPc= Date: Sat, 24 Dec 2022 07:48:01 +0100 From: Greg KH To: Wesley Cheng Cc: srinivas.kandagatla@linaro.org, mathias.nyman@intel.com, perex@perex.cz, broonie@kernel.org, lgirdwood@gmail.com, andersson@kernel.org, krzysztof.kozlowski+dt@linaro.org, Thinh.Nguyen@synopsys.com, bgoswami@quicinc.com, tiwai@suse.com, robh+dt@kernel.org, agross@kernel.org, linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org, alsa-devel@alsa-project.org, devicetree@vger.kernel.org, linux-usb@vger.kernel.org, quic_jackp@quicinc.com, quic_plai@quicinc.com Subject: Re: [RFC PATCH 01/14] ASoC: Add SOC USB APIs for adding an USB backend Message-ID: References: <20221223233200.26089-1-quic_wcheng@quicinc.com> <20221223233200.26089-2-quic_wcheng@quicinc.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20221223233200.26089-2-quic_wcheng@quicinc.com> Precedence: bulk List-ID: X-Mailing-List: linux-arm-msm@vger.kernel.org On Fri, Dec 23, 2022 at 03:31:47PM -0800, Wesley Cheng wrote: > diff --git a/sound/soc/soc-usb.c b/sound/soc/soc-usb.c > new file mode 100644 > index 000000000000..c6c376960e4d > --- /dev/null > +++ b/sound/soc/soc-usb.c > @@ -0,0 +1,66 @@ > +// SPDX-License-Identifier: GPL-2.0 > +/* > + * Copyright (c) 2022 Qualcomm Innovation Center, Inc. All rights reserved. > + */ > +#include > +#include > +#include > +#include "../usb/card.h" > + > +struct snd_soc_usb *ctx; Note, this will not work. You can not only have "one" state for a system like this. That just broke any system with more than one controller, of which we have millions. This has to be dynamic for any number of controllers in the system, like the sound and USB core can handle. Any requirement of "there can be only one!" will obviously never be acceptable as that is not how Linux works. thanks, greg k-h