From: Jarkko Sakkinen <jarkko@kernel.org>
To: James Bottomley <James.Bottomley@HansenPartnership.com>
Cc: linux-integrity@vger.kernel.org, Ard Biesheuvel <ardb@kernel.org>,
keyrings@vger.kernel.org
Subject: Re: [PATCH 03/11] tpm: add cursor based buffer functions for response parsing
Date: Mon, 26 Dec 2022 20:06:21 +0000 [thread overview]
Message-ID: <Y6n+vZSdE5KEZ4eJ@kernel.org> (raw)
In-Reply-To: <08f138d9df19b508bc4892d34f117ac15db9570a.camel@HansenPartnership.com>
On Sun, Dec 11, 2022 at 10:13:12PM -0500, James Bottomley wrote:
> On Mon, 2022-12-12 at 00:50 +0000, Jarkko Sakkinen wrote:
> > On Fri, Dec 09, 2022 at 11:06:03AM -0500, James Bottomley wrote:
> > > It's very convenient when parsing responses to have a cursor you
> > > simply move over the response extracting the data. Add such cursor
> > > functions for the TPM unsigned integer types.
> > >
> > > Signed-off-by: James Bottomley
> > > <James.Bottomley@HansenPartnership.com>
> >
> > Saying that something is convenient is not really an argument.
> >
> > What you are going to use it for? Is it complex enough that what we
> > have not doesn't scale. I'd just answer these questions and write
> > more reasonable commit message.
>
> It's all used int patch 6 which gets into the complex building of
> authenticated and hmac'd requests and responses via sessions using
> these primitives.
Again state obvious, even if you think it is obvious. It is really useful
to have that kind of that as refresher in the commit log.
I'm setting rpi 3b + tpm2 chip gpio to try this out. I thought it would be
a cool test sytem because later on I can test both fTPM in TZ and SPI dTPM
with it...
BR, Jarkko
next prev parent reply other threads:[~2022-12-26 20:06 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-12-09 16:06 [PATCH 00/11] add integrity and security to TPM2 transactions James Bottomley
2022-12-09 16:06 ` [PATCH 01/11] tpm: move buffer handling from static inlines to real functions James Bottomley
2022-12-09 19:11 ` kernel test robot
2022-12-09 19:42 ` kernel test robot
2022-12-10 2:09 ` Jarkko Sakkinen
2022-12-11 20:01 ` James Bottomley
2022-12-12 0:52 ` Jarkko Sakkinen
2022-12-12 3:16 ` James Bottomley
2022-12-26 20:03 ` Jarkko Sakkinen
2022-12-09 16:06 ` [PATCH 02/11] tpm: add buffer handling for TPM2B types James Bottomley
2022-12-09 16:06 ` [PATCH 03/11] tpm: add cursor based buffer functions for response parsing James Bottomley
2022-12-12 0:50 ` Jarkko Sakkinen
2022-12-12 3:13 ` James Bottomley
2022-12-26 20:06 ` Jarkko Sakkinen [this message]
2022-12-09 16:06 ` [PATCH 04/11] tpm: add buffer function to point to returned parameters James Bottomley
2022-12-09 16:06 ` [PATCH 05/11] tpm: export the context save and load commands James Bottomley
2022-12-09 16:06 ` [PATCH 06/11] tpm: Add full HMAC and encrypt/decrypt session handling code James Bottomley
2022-12-09 16:15 ` James Bottomley
2022-12-09 19:42 ` kernel test robot
2022-12-09 20:32 ` kernel test robot
2022-12-09 16:06 ` [PATCH 07/11] tpm: add hmac checks to tpm2_pcr_extend() James Bottomley
2022-12-09 16:06 ` [PATCH 08/11] tpm: add session encryption protection to tpm2_get_random() James Bottomley
2022-12-09 16:06 ` [PATCH 09/11] KEYS: trusted: Add session encryption protection to the seal/unseal path James Bottomley
2022-12-09 16:06 ` [PATCH 10/11] tpm: add the null key name as a sysfs export James Bottomley
2022-12-09 16:06 ` [PATCH 11/11] Documentation: add tpm-security.rst James Bottomley
-- strict thread matches above, loose matches on Subject: below --
2022-12-10 4:27 [PATCH 06/11] tpm: Add full HMAC and encrypt/decrypt session handling code kernel test robot
2022-12-10 5:17 ` Dan Carpenter
2022-12-11 20:05 ` James Bottomley
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Y6n+vZSdE5KEZ4eJ@kernel.org \
--to=jarkko@kernel.org \
--cc=James.Bottomley@HansenPartnership.com \
--cc=ardb@kernel.org \
--cc=keyrings@vger.kernel.org \
--cc=linux-integrity@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.